[JIRA] (JENKINS-59427) Rename SSH Slaves Plugin

44 views
Skip to first unread message

o.v.nenashev@gmail.com (JIRA)

unread,
Sep 18, 2019, 5:07:03 AM9/18/19
to jenkinsc...@googlegroups.com
Oleg Nenashev created an issue
 
Jenkins / Improvement JENKINS-59427
Rename SSH Slaves Plugin
Issue Type: Improvement Improvement
Assignee: Ivan Fernandez Calvo
Components: ssh-slaves-plugin
Created: 2019-09-18 09:06
Labels: documentation
Priority: Minor Minor
Reporter: Oleg Nenashev

In Jenkins 2 "slaves" have been renamed to "agents". It would be useful to adjust this component, at least the plugin name, UI layout, Wiki and probably Javadoc
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
Sep 18, 2019, 5:08:02 AM9/18/19
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Unassigned
Change By: Oleg Nenashev
Assignee: Ivan Fernandez Calvo

o.v.nenashev@gmail.com (JIRA)

unread,
Sep 18, 2019, 5:10:04 AM9/18/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Labels: documentation newbie-friendly

o.v.nenashev@gmail.com (JIRA)

unread,
Sep 18, 2019, 5:10:04 AM9/18/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
In Jenkins 2 It is a follow-up to JENKINS-42840. The plugin doucmentation has been updated to avoid "slaves" , but we still have been renamed to " agents slave " . It would be useful to adjust this component, at least right in the plugin name . We need to rename it without touching artifactId. It will require README and pom.xml cleanup , UI layout, Wiki and probably Javadoc also additional documentation review.

Possible name options:
* SSH Nodes Plugins ([~ifernandezcalvo])
* SSH Agent Nodes Plugin ([~ifernandezcalvo])
* SSH Build Agents Plugin ([~oleg_nenashev])

 

o.v.nenashev@gmail.com (JIRA)

unread,
Sep 27, 2019, 8:06:04 AM9/27/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Released As: ssh-slaves-1.27

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 25, 2019, 2:51:04 PM12/25/19
to jenkinsc...@googlegroups.com
Oleg Nenashev started work on Improvement JENKINS-59427
 
Change By: Oleg Nenashev
Status: Open In Progress

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 25, 2019, 2:51:04 PM12/25/19
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Oleg Nenashev
Change By: Oleg Nenashev
Assignee: Oleg Nenashev

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 26, 2019, 5:42:02 AM12/26/19
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Improvement JENKINS-59427
 
Re: Rename SSH Slaves Plugin

I would like to mention that SSH Nodes Plugin is not fully correct, because "Node" defines both local and remote executors (hehe, "Nodes"). Agent defines remote ones, but we cannot just call the plugin "SSH Agents Plugin" because of the confusion with ssh-agent. Hence there are options.

 

Running a poll in Twitter: https://twitter.com/oleg_nenashev/status/1210146423888633861

 

CC Ivan Fernandez Calvo

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 30, 2019, 5:03:03 AM12/30/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Attachment: image-2019-12-30-11-02-50-335.png

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 30, 2019, 5:12:03 AM12/30/19
to jenkinsc...@googlegroups.com

So my conclusion is that there is a mess in plugin naming already. We either stick to the "Foo Agents Plugin" terminology, or steer naming to "Foo Agent Launcher" or "Foo Node Launcher". The latter one is more developer-friendly, because the actual extension point under the hood is "NodeLauncher". My sugestion would be to proceed with "SSH Build Agents" or "SSH Node Launcher Plugin".

Ivan Fernandez Calvo could you please select the final name as a maintainer?

 

 

ericsmalling@gmail.com (JIRA)

unread,
Dec 30, 2019, 8:32:02 AM12/30/19
to jenkinsc...@googlegroups.com

FWIW, I think "SSH Build Agents" is a fine choice too.

kuisathaverat@gmail.com (JIRA)

unread,
Dec 30, 2019, 8:46:04 AM12/30/19
to jenkinsc...@googlegroups.com

the poll winner is fine "SSH Build Agents"

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 30, 2019, 12:25:02 PM12/30/19
to jenkinsc...@googlegroups.com

So be it. Just in case, we can always rename it again

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 31, 2019, 5:42:02 PM12/31/19
to jenkinsc...@googlegroups.com

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 31, 2019, 5:42:02 PM12/31/19
to jenkinsc...@googlegroups.com
Change By: Oleg Nenashev
Status: In Progress Review

kuisathaverat@gmail.com (JIRA)

unread,
Jan 1, 2020, 8:41:02 AM1/1/20
to jenkinsc...@googlegroups.com
Change By: Ivan Fernandez Calvo
Status: In Review Fixed but Unreleased
Resolution: Fixed

kuisathaverat@gmail.com (JIRA)

unread,
Feb 1, 2020, 12:07:02 PM2/1/20
to jenkinsc...@googlegroups.com
Status: Fixed but Unreleased Resolved
Released As: ssh-slaves-1.31.1
Reply all
Reply to author
Forward
0 new messages