[JIRA] (JENKINS-59204) NPE when trying to use claim plugin after upgrading to jenkins 2.191

31 views
Skip to first unread message

olivier@vernin.me (JIRA)

unread,
Sep 3, 2019, 8:23:03 AM9/3/19
to jenkinsc...@googlegroups.com
Olivier Vernin moved an issue
 
Jenkins / Bug JENKINS-59204
NPE when trying to use claim plugin after upgrading to jenkins 2.191
Change By: Olivier Vernin
Project: Infrastructure Jenkins
Key: INFRA JENKINS - 2234 59204
Workflow: classic default workflow JNJira + In-Review
Component/s: build-failure-analyzer-plugin
Component/s: jenkins.io
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

christian.ertl@tngtech.com (JIRA)

unread,
Sep 3, 2019, 8:27:02 AM9/3/19
to jenkinsc...@googlegroups.com

mbochenk@tibco.com (JIRA)

unread,
Sep 4, 2019, 6:30:01 AM9/4/19
to jenkinsc...@googlegroups.com
Nikita Bochenko commented on Bug JENKINS-59204
 
Re: NPE when trying to use claim plugin after upgrading to jenkins 2.191

 Same on updating to latest LTS - 2.176.3 - claim plugin stops working. 

kddubb@gmail.com (JIRA)

unread,
Sep 19, 2019, 4:09:01 PM9/19/19
to jenkinsc...@googlegroups.com

Hit this as well on 2.176.3.  Downgraded to 1.20 (the downgrade version offered on the Plugins page) and things work again.

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

gmc-devel@br-automation.com (JIRA)

unread,
Oct 9, 2019, 1:09:03 AM10/9/19
to jenkinsc...@googlegroups.com

It seems to be a kind of compatibility-missmatch between claim- and bfa-plugin.

The claim plugin checks uses following code (see ClaimBuildFailureAnalyzer.java #44):

    public static boolean isBFAEnabled() {
        return (Jenkins.getInstance().getPlugin("build-failure-analyzer") != null
        && Jenkins.getInstance().getPlugin(PluginImpl.class).isGlobalEnabled());
{{    }}}

With release 1.23.0 of the plugin Build Failure Analyzer the class PluginImpl does no longer extends the interface hudson.Plugin, it was changed to jenkins.model.GlobalConfiguration.
I guess, that the core-method getPlugin returns null and therefore, another GlobalConfiguration-compatible implementation has to be used (for this newer bfa-release).

 

gmc-devel@br-automation.com (JIRA)

unread,
Oct 9, 2019, 1:10:03 AM10/9/19
to jenkinsc...@googlegroups.com
It seems to be a kind of compatibility-missmatch between claim- and bfa-plugin.

The claim plugin
checks
uses following code (see ClaimBuildFailureAnalyzer.java #44):
{quote}

{{    public static boolean isBFAEnabled() {}}

{{        return (Jenkins.getInstance().getPlugin("build-failure-analyzer") != null}}
{{        && Jenkins.getInstance().getPlugin(PluginImpl.class).isGlobalEnabled());}}
\ {{    }}}
{quote}
With release 1.23.0 of the
plugin Build Failure Analyzer the class PluginImpl does no longer extends the interface hudson.Plugin , ; it was changed to jenkins.model.GlobalConfiguration.

I guess, that the core-method getPlugin returns null and therefore, another GlobalConfiguration-compatible implementation has to be used (for this newer bfa-release).

 

gmc-devel@br-automation.com (JIRA)

unread,
Oct 9, 2019, 1:12:05 AM10/9/19
to jenkinsc...@googlegroups.com
It seems to be a kind of compatibility-missmatch between claim- and bfa-plugin.

The claim plugin uses following code (see ClaimBuildFailureAnalyzer.java #44):

{quote}{{public static boolean isBFAEnabled() {}}
{{    return (Jenkins.getInstance().getPlugin("build-failure-analyzer") != null}}
{{        && Jenkins.getInstance().getPlugin(PluginImpl.class).isGlobalEnabled());}}
}
{quote}
With release 1.23.0 of the Build Failure Analyzer the class PluginImpl does no longer extends the interface hudson.Plugin; it was changed to jenkins.model.GlobalConfiguration.

I guess, that the core-method getPlugin returns null and therefore, another GlobalConfiguration-compatible implementation has to be used (for this newer bfa-release).

 

gmc-devel@br-automation.com (JIRA)

unread,
Oct 9, 2019, 1:12:05 AM10/9/19
to jenkinsc...@googlegroups.com

nielsk.jensen@man.eu (JIRA)

unread,
Oct 30, 2019, 8:25:04 AM10/30/19
to jenkinsc...@googlegroups.com

I also have the issue in version Jenkins ver. 2.190.1 running on Windows server 2008R2

nielsk.jensen@man.eu (JIRA)

unread,
Oct 30, 2019, 8:36:02 AM10/30/19
to jenkinsc...@googlegroups.com
I also have the issue in version Jenkins ver. 2.190.1 running on Windows server 2008R2


Build Failure Analyzer 1.23.1 and Claim Plugin 2.15

timjacomb1@gmail.com (JIRA)

unread,
Nov 5, 2019, 3:00:06 AM11/5/19
to jenkinsc...@googlegroups.com
Tim Jacomb started work on Bug JENKINS-59204
 
Change By: Tim Jacomb
Status: Open In Progress

timjacomb1@gmail.com (JIRA)

unread,
Nov 5, 2019, 3:00:06 AM11/5/19
to jenkinsc...@googlegroups.com

timjacomb1@gmail.com (JIRA)

unread,
Nov 5, 2019, 3:00:07 AM11/5/19
to jenkinsc...@googlegroups.com

nielsk.jensen@man.eu (JIRA)

unread,
Nov 5, 2019, 10:14:03 AM11/5/19
to jenkinsc...@googlegroups.com
Niels Kristian Jensen commented on Bug JENKINS-59204
 
Re: NPE when trying to use claim plugin after upgrading to jenkins 2.191

Tim Jacomb - the fix works fine. Should I set it to "Fixed but unreleased" or should the author (you) do that?

timjacomb1@gmail.com (JIRA)

unread,
Nov 5, 2019, 10:16:02 AM11/5/19
to jenkinsc...@googlegroups.com

It needs merging by the maintainers, I'm not a maintainer of either plugin

arnaud.dev@gmail.com (JIRA)

unread,
Nov 13, 2019, 9:28:04 AM11/13/19
to jenkinsc...@googlegroups.com

arnaud.dev@gmail.com (JIRA)

unread,
Nov 13, 2019, 5:15:03 PM11/13/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages