[JIRA] (JENKINS-59010) As User I would like to have control over the deployment mode

[peter.niederlag@datenbetrieb.de (JIRA)]

Peter Niederlag created an issue

Jenkins / JENKINS-59010 As User I would like to have control over the deployment mode Issue Type: Improvement Assignee: Azure DevOps Components: azure-function-plugin Created: 2019-08-20 14:08 Priority: Minor Reporter: Peter Niederlag currently it seems the azure-function-plugin has some super cow power and decides the deployment strategy based on: it's a java app, use zip deployment otherwise, use git deployment It would be cool if the decision on the deployment mode could be made by the user. Also it would be important to drop a note somewhere on these decisions as - to my knowledge - the settings in the function app must correspond to the deployment mode used. (WEBSITE_RUN_FROM_PACKAGE = "1") Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[jieshe@microsoft.com (JIRA)]

Jie Shen assigned an issue to Jie Shen

Jenkins / JENKINS-59010 As User I would like to have control over the deployment mode

Change By: Jie Shen Assignee: Azure DevOps Jie Shen

Add Comment

[jieshe@microsoft.com (JIRA)]

Jie Shen commented on JENKINS-59010

Re: As User I would like to have control over the deployment mode Make sense. But it may be a little difficult to achieve.

Add Comment

[peter.niederlag@datenbetrieb.de (JIRA)]

Peter Niederlag commented on JENKINS-59010

Re: As User I would like to have control over the deployment mode

first of all, thx for getting back on this. Shouldn't it be possible to add another parameter "deploymentMode" (zip|git) to the plugin in here? https://github.com/jenkinsci/azure-function-plugin/tree/dev/src/main/resources/com/microsoft/jenkins/function/FunctionAppDeploymentRecorder And then override the isJava logic when this parameter is set to zip|git in here: https://github.com/jenkinsci/azure-function-plugin/blob/dev/src/main/java/com/microsoft/jenkins/function/FunctionAppDeploymentCommandContext.java Could this be a valid approach? Is there any further logic baked into the zip|git deployment strategies that makes them dependent on the type of the function app (java, nodejs, ...)?

Add Comment

[jieshe@microsoft.com (JIRA)]

Jie Shen commented on JENKINS-59010

Re: As User I would like to have control over the deployment mode

Peter Niederlag The basic logic should be like that. You just need to be careful not to introduce any incompatible changes to existing users.

Add Comment