[JIRA] (JENKINS-58964) Git not considered modern SCM for git-3.11.0+

[ogondza@gmail.com (JIRA)]

Oliver Gondža created an issue

Jenkins / JENKINS-58964 Git not considered modern SCM for git-3.11.0+ Issue Type: Bug Assignee: Oliver Gondža Components: git-plugin, workflow-cps-global-lib-plugin Created: 2019-08-16 10:59 Environment: git-3.11.0 workflow-cps-global-lib:2.11 Labels: regression Priority: Major Reporter: Oliver Gondža Innocently looking refactoring has caused git not to be considered a modern SCM implementation, until a correction in workflow-cps-global-lib-2.14. If newer `git` is used with older `workflow-cps-global-lib`, git is legacy. Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[ogondza@gmail.com (JIRA)]

Oliver Gondža started work on JENKINS-58964

Change By: Oliver Gondža Status: Open In Progress

Add Comment

[ogondza@gmail.com (JIRA)]

Oliver Gondža commented on JENKINS-58964

Re: Git not considered modern SCM for git-3.11.0+ Fix proposed.

Add Comment

[ogondza@gmail.com (JIRA)]

Oliver Gondža updated JENKINS-58964

Jenkins / JENKINS-58964

Git not considered modern SCM for git-3.11.0+

Change By: Oliver Gondža Status: In Progress Review

Add Comment

[dnusbaum@cloudbees.com (JIRA)]

Devin Nusbaum commented on JENKINS-58964

Re: Git not considered modern SCM for git-3.11.0+ I think you have the order of operations backwards in your description, see this PR comment for details. Essentially, workflow-cps-global-lib 2.14 preceded git 3.11.0. Because of that, I'm not really sure how we could automatically catch this kind of thing in the future without specifically testing old versions of some plugins with new versions of others in the PCT.

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev commented on JENKINS-58964

Re: Git not considered modern SCM for git-3.11.0+

Devin Nusbaum Hi. Is there a ETA for the https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/78 release?

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[dnusbaum@cloudbees.com (JIRA)]

Devin Nusbaum commented on JENKINS-58964

Re: Git not considered modern SCM for git-3.11.0+

Oleg Nenashev No, but I can try to release in the next few weeks. Note though that neither the git nor workflow-cps-global-lib PRs fix the problem, the fix in this case is to only run git 3.11.0 or newer along with workflow-cps-global-lib 2.14 or newer. If you run git 3.11.0 or newer with an older version of workflow-cps-global-lib, that is how you run into the issue.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-58964

Re: Git not considered modern SCM for git-3.11.0+

I believe this is resolved by using git plugin 3.12.0 or later. As far as understand from Oliver Gondža, the bug was in the git plugin and the fix is also in the git plugin.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated JENKINS-58964

Jenkins / JENKINS-58964

Git not considered modern SCM for git-3.11.0+

Change By: Mark Waite Status: In Review Resolved Resolution: Fixed

Add Comment

[dnusbaum@cloudbees.com (JIRA)]

Devin Nusbaum commented on JENKINS-58964

Re: Git not considered modern SCM for git-3.11.0+ I think that Oliver Gondža thought that workflow-cps-global-lib was a compile scope dependency in git plugin, so that https://github.com/jenkinsci/git-plugin/pull/742 would enforce the dependency requirements for all users, but it is actually test scope, so 3.12.0 should be functionally the same as 3.11.0, and the only fix is to manually make sure you only use those versions with workflow-cps-global 2.14 or newer.

Add Comment

[dnusbaum@cloudbees.com (JIRA)]

Devin Nusbaum edited a comment on JENKINS-58964

Re: Git not considered modern SCM for git-3.11.0+

I think that [~olivergondza] thought that workflow-cps-global-lib was a compile scope dependency in git plugin, so that [ https://github.com/jenkinsci/git-plugin/pull/742 ] would enforce the dependency requirements for all users, [but it is actually test scope|https://github.com/jenkinsci/git-plugin/pull/742/files#r315197236], so 3.12.0 should be functionally the same as 3.11.0, and the only fix is to manually make sure you only use those versions of git plugin with workflow-cps-global -lib 2.14 or newer.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-58964

Re: Git not considered modern SCM for git-3.11.0+

Thanks for the clarification Devin Nusbaum. I think you're correct based on the comment in that pull request. Fix is to run git plugin 3.12.x with workflow-cps-global-lib 2.14 or newer.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite closed an issue as Fixed

Jenkins / JENKINS-58964

Git not considered modern SCM for git-3.11.0+

Change By: Mark Waite Status: Resolved Closed

Add Comment