[JIRA] (JENKINS-58915) Change timeout

0 views
Skip to first unread message

cawa007@gmail.com (JIRA)

unread,
Aug 14, 2019, 2:05:02 AM8/14/19
to jenkinsc...@googlegroups.com
Alex Mac created an issue
 
Jenkins / Improvement JENKINS-58915
Change timeout
Issue Type: Improvement Improvement
Assignee: Mez Pahlan
Components: appcenter-plugin
Created: 2019-08-14 06:04
Labels: plugin
Priority: Minor Minor
Reporter: Alex Mac

Now default upload timeout is 10 seconds. it's too fast.  Need to raise the timeout to at least 60 seconds.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

mez.pahlan@gmail.com (JIRA)

unread,
Aug 14, 2019, 2:50:03 AM8/14/19
to jenkinsc...@googlegroups.com
Mez Pahlan started work on Improvement JENKINS-58915
 
Change By: Mez Pahlan
Status: Open In Progress

mez.pahlan@gmail.com (JIRA)

unread,
Aug 14, 2019, 2:59:04 AM8/14/19
to jenkinsc...@googlegroups.com
Mez Pahlan commented on Improvement JENKINS-58915
 
Re: Change timeout

Hi Alex Mac thanks for the report. From your PR you have increased not just the write timeout but the read, connection, and call timeout values to 60 seconds. Can you let me know why all four values need to be increased?

Also, why have you selected to increase the timeout specifically to 60 seconds?

cawa007@gmail.com (JIRA)

unread,
Aug 14, 2019, 3:50:03 AM8/14/19
to jenkinsc...@googlegroups.com
Alex Mac commented on Improvement JENKINS-58915
 
Re: Change timeout

Hi Mez Pahlan. A value of 60 seconds is taken approximately.
I agree that the increase in all 4 parameters is redundant. It is enough to increase 2 parameters: connectTimeout and writeTimeout.
More information about timeouts can be found here https://futurestud.io/tutorials/retrofit-2-customize-network-timeouts

clark@hiddenvariable.com (JIRA)

unread,
Aug 15, 2019, 8:28:03 PM8/15/19
to jenkinsc...@googlegroups.com
Clark Kromenaker edited a comment on Improvement JENKINS-58915
 
Re: Change timeout
I came here to create a ticket for this issue. I noticed that I'd frequently (but not always) get this output for my Jenkins jobs:


Creating an upload resource.
Upload resource successful.
Uploading app to resource.
Upload app unsuccessful.
java.net.SocketTimeoutException: timeout
io.jenkins.plugins.appcenter.AppCenterException: java.util.concurrent.ExecutionException: java.net.SocketTimeoutException: timeout
Build step 'Upload app to AppCenter' changed build result to FAILURE


You might say it's a network connection issue...but the HockeyApp plugin I used previously would very consistently upload without failure or timeout.

Please resolve, since it makes my Jenkins builds fail about 80% of the time! I'm uploading an app that is about 80MB, if that makes any difference.

clark@hiddenvariable.com (JIRA)

unread,
Aug 15, 2019, 8:28:03 PM8/15/19
to jenkinsc...@googlegroups.com

clark@hiddenvariable.com (JIRA)

unread,
Aug 15, 2019, 8:29:01 PM8/15/19
to jenkinsc...@googlegroups.com
I came here to create a ticket for this issue. I noticed that I'd frequently (but not always) get this output for my Jenkins jobs:
{code:java}

Creating an upload resource.
Upload resource successful.
Uploading app to resource.
Upload app unsuccessful.
java.net.SocketTimeoutException: timeout
io.jenkins.plugins.appcenter.AppCenterException: java.util.concurrent.ExecutionException: java.net.SocketTimeoutException: timeout
Build step 'Upload app to AppCenter' changed build result to FAILURE {code}


You might say it's a network connection issue...but the HockeyApp plugin I used previously would very consistently upload without failure or timeout.

Please resolve, since it makes my Jenkins builds fail about 80% of the time! I'm uploading an app that is about 80MB, if that makes any difference.

mez.pahlan@gmail.com (JIRA)

unread,
Aug 17, 2019, 10:43:03 AM8/17/19
to jenkinsc...@googlegroups.com
Mez Pahlan commented on Improvement JENKINS-58915
 
Re: Change timeout

Hi Alex Mac and Clark Kromenaker apologies for the delay I wanted to be sure that 60 seconds is a safe value to set before I looked further into the PR. But I've satisfied myself that it is fine in this case. I'll look to either get some comments back on the main PR or merge this into master. Thanks.

mez.pahlan@gmail.com (JIRA)

unread,
Aug 17, 2019, 11:04:03 AM8/17/19
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Status: In Progress Fixed but Unreleased
Resolution: Fixed

mez.pahlan@gmail.com (JIRA)

unread,
Aug 17, 2019, 11:33:03 AM8/17/19
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Status: Fixed but Unreleased Resolved
Released As: 0.3.1

clark@hiddenvariable.com (JIRA)

unread,
Aug 20, 2019, 2:10:01 PM8/20/19
to jenkinsc...@googlegroups.com
Clark Kromenaker commented on Improvement JENKINS-58915
 
Re: Change timeout

Hi, no problem - thanks for taking the time to look into this!

Reply all
Reply to author
Forward
0 new messages