[JIRA] (JENKINS-58753) Add proxy support for the zoom plugin

0 views
Skip to first unread message

pibeitz@gmail.com (JIRA)

unread,
Aug 1, 2019, 5:31:02 AM8/1/19
to jenkinsc...@googlegroups.com
Pierre Beitz created an issue
 
Jenkins / Bug JENKINS-58753
Add proxy support for the zoom plugin
Issue Type: Bug Bug
Assignee: zoom us
Components: zoom-plugin
Created: 2019-08-01 09:30
Priority: Major Major
Reporter: Pierre Beitz

Currently the plugin doesn't seem to take proxy settings into account and direct connects.

Plugin version: 1.1
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

531276579@qq.com (JIRA)

unread,
Dec 8, 2019, 8:24:02 PM12/8/19
to jenkinsc...@googlegroups.com
chao qian commented on Bug JENKINS-58753
 
Re: Add proxy support for the zoom plugin

 

I also met this problem, my Jenkins environment is in internal network, it need use proxy to connect internet.  

Now I can't use zoom plugin to push notifications. 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

jyanes@notariado.org (JIRA)

unread,
Mar 27, 2020, 3:23:02 PM3/27/20
to jenkinsc...@googlegroups.com

I also have this problem.

2020-03-27 18:34:06.404+0000 [id=159] INFO i.j.p.zoom.ZoomNotifyClient#notify: Send notification to https://applications.zoom.us/addon/v2/jenkins/webhooks/xxxxxxxxxxxxxx_xxxxxxx, message: null

2020-03-27 18:34:27.464+0000 [id=159] SEVERE i.j.p.zoom.ZoomNotifyClient#notify: Error posting to Zoom, url: https://applications.zoom.us/addon/v2/jenkins/webhooks/xxxxxxxxxxxxxx_xxxxxxx, message: null

 

At first I thought it was just ignoring the proxy settings on the advanced tab of the plugins management page, and that setting the following java opts could work

-Dhttp.proxyHost="proxy.xxxxxx.com" -Dhttp.proxyPort=3128 -Dhttps.proxyHost="proxy.xxxxxx.com" -Dhttps.proxyPort=3128 -Dhttp.nonProxyHosts="localhost|aaaa|aaaa.xxxxxx.com|bbbb|bbbb.xxxxxx.com"

but it did not.

 

I can access the URL both with Chrome and with the following in the Jenkins script console

ProxyConfiguration.open(new java.net.URL("https://applications.zoom.us/addon/v2/jenkins/webhooks/")).content

I get a 401 error, but that's ok, because this test is not providing the API token.

 

So it is not a connectivity issue. It is clearly a code problem.

I found the plugin's code here: https://github.com/jenkinsci/zoom-plugin/blob/master/src/main/java/io/jenkins/plugins/zoom/ZoomNotifyClient.java

And it using the apache HTTP client to post to the API url, but it never takes any proxy into account.

 

Something like this example must be implemented: https://hc.apache.org/httpcomponents-client-4.5.x/httpclient/examples/org/apache/http/examples/client/ClientExecuteProxy.java

There's another explanation here: https://www.tutorialspoint.com/apache_httpclient/apache_httpclient_using_proxy.htm

 

If I have time this weekend I might open a pull request. This doesn't seem difficult to do at all.

 

 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

jyanes@notariado.org (JIRA)

unread,
Mar 27, 2020, 3:26:03 PM3/27/20
to jenkinsc...@googlegroups.com
Jorge Yanes edited a comment on Bug JENKINS-58753
I also have this problem.
{code:java}

2020-03-27 18:34:06.404+0000 [id=159] INFO i.j.p.zoom.ZoomNotifyClient#notify: Send notification to https://applications.zoom.us/addon/v2/jenkins/webhooks/xxxxxxxxxxxxxx_xxxxxxx, message: null

2020-03-27 18:34:27.464+0000 [id=159] SEVERE i.j.p.zoom.ZoomNotifyClient#notify: Error posting to Zoom, url: https://applications.zoom.us/addon/v2/jenkins/webhooks/xxxxxxxxxxxxxx_xxxxxxx, message: null{code}

 

At first I thought it was just ignoring the proxy settings on the advanced tab of the plugins management page, and that setting the following java opts could work
{code:java}

-Dhttp.proxyHost="proxy.xxxxxx.com" -Dhttp.proxyPort=3128 -Dhttps.proxyHost="proxy.xxxxxx.com" -Dhttps.proxyPort=3128 -Dhttp.nonProxyHosts="localhost|aaaa|aaaa.xxxxxx.com|bbbb|bbbb.xxxxxx.com"
{code}

but it did not.

 

I can access the URL both with Chrome and with the following in the Jenkins script console
{code:java}

ProxyConfiguration.open(new java.net.URL("https://applications.zoom.us/addon/v2/jenkins/webhooks/")).content
{code}

I get a 401 error, but that's ok, because this test is not providing the API token.

 
So it is not a connectivity issue. It is clearly a code problem.

  

 I found the plugin's code [ here :  | [https://github.com/jenkinsci/zoom-plugin/blob/master/src/main/java/io/jenkins/plugins/zoom/ZoomNotifyClient.java] ]


And it 's using the apache Apache HTTP client to post to the API url URL , but it never takes any proxy into account.

 

Something like this example must be implemented: [ Example|[ https://hc.apache.org/httpcomponents-client-4.5.x/httpclient/examples/org/apache/http/examples/client/ClientExecuteProxy.java] ]

There's another explanation here: [ Tutorial| [ https://www.tutorialspoint.com/apache_httpclient/apache_httpclient_using_proxy.htm] ]

 

If I have time this weekend I might open a pull request. This doesn't seem difficult to do at all.

jyanes@notariado.org (JIRA)

unread,
Mar 27, 2020, 3:27:02 PM3/27/20
to jenkinsc...@googlegroups.com
Jorge Yanes edited a comment on Bug JENKINS-58753
I also have this problem.
{code:java}
2020-03-27 18:34:06.404+0000 [id=159] INFO i.j.p.zoom.ZoomNotifyClient#notify: Send notification to https://applications.zoom.us/addon/v2/jenkins/webhooks/xxxxxxxxxxxxxx_xxxxxxx, message: null

2020-03-27 18:34:27.464+0000 [id=159] SEVERE i.j.p.zoom.ZoomNotifyClient#notify: Error posting to Zoom, url: https://applications.zoom.us/addon/v2/jenkins/webhooks/xxxxxxxxxxxxxx_xxxxxxx, message: null{code}
 

At first I thought it was just ignoring the proxy settings on the advanced tab of the plugins management page, and that setting the following java opts could work
{code:java}
-Dhttp.proxyHost="proxy.xxxxxx.com" -Dhttp.proxyPort=3128 -Dhttps.proxyHost="proxy.xxxxxx.com" -Dhttps.proxyPort=3128 -Dhttp.nonProxyHosts="localhost|aaaa|aaaa.xxxxxx.com|bbbb|bbbb.xxxxxx.com"
{code}
but it did not.

 

I can access the URL both with Chrome and with the following in the Jenkins script console
{code:java}
ProxyConfiguration.open(new java.net.URL("https://applications.zoom.us/addon/v2/jenkins/webhooks/")).content
{code}
I get a 401 error, but that's ok, because this test is not providing the API token.

 So it is not a connectivity issue. It is clearly a code problem.

 

I found the plugin's code [ link here| [https://github.com/jenkinsci/zoom-plugin/blob/master/src/main/java/io/jenkins/plugins/zoom/ZoomNotifyClient.java]]

And it's using the Apache HTTP client to post to the API URL, but it never takes any proxy into account.

 

Something like this example must be implemented: [ link Example|[https://hc.apache.org/httpcomponents-client-4.5.x/httpclient/examples/org/apache/http/examples/client/ClientExecuteProxy.java]]

There's another explanation here: [ link Tutorial| [https://www.tutorialspoint.com/apache_httpclient/apache_httpclient_using_proxy.htm]]


 

If I have time this weekend I might open a pull request. This doesn't seem difficult to do at all.

jyanes@notariado.org (JIRA)

unread,
Mar 27, 2020, 3:29:03 PM3/27/20
to jenkinsc...@googlegroups.com
Jorge Yanes edited a comment on Bug JENKINS-58753
I also have this problem.
{code:java}
2020-03-27 18:34:06.404+0000 [id=159] INFO i.j.p.zoom.ZoomNotifyClient#notify: Send notification to https://applications.zoom.us/addon/v2/jenkins/webhooks/xxxxxxxxxxxxxx_xxxxxxx, message: null

2020-03-27 18:34:27.464+0000 [id=159] SEVERE i.j.p.zoom.ZoomNotifyClient#notify: Error posting to Zoom, url: https://applications.zoom.us/addon/v2/jenkins/webhooks/xxxxxxxxxxxxxx_xxxxxxx, message: null{code}
 

At first I thought it was just ignoring the proxy settings on the advanced tab of the plugins management page, and that setting the following java opts could work
{code:java}
-Dhttp.proxyHost="proxy.xxxxxx.com" -Dhttp.proxyPort=3128 -Dhttps.proxyHost="proxy.xxxxxx.com" -Dhttps.proxyPort=3128 -Dhttp.nonProxyHosts="localhost|aaaa|aaaa.xxxxxx.com|bbbb|bbbb.xxxxxx.com"
{code}
but it did not.

 

I can access the URL both with Chrome and with the following in the Jenkins script console
{code:java}
ProxyConfiguration.open(new java.net.URL("https://applications.zoom.us/addon/v2/jenkins/webhooks/")).content
{code}
I get a 401 error, but that's ok, because this test is not providing the API token.

 So it is not a connectivity issue. It is clearly a code problem.

 


And it's using the Apache HTTP client to post to the API URL, but it never takes any proxy into account.

 

Something like this example must be implemented: [link Example|[https://hc.apache.org/httpcomponents-client-4.5.x/httpclient/examples/org/apache/http/examples/client/ClientExecuteProxy.java]]

There's another explanation here: [link Tutorial| [https://www.tutorialspoint.com/apache_httpclient/apache_httpclient_using_proxy.htm]]

 

If I have time this weekend I might open a pull request. This doesn't seem difficult to do at all.

jyanes@notariado.org (JIRA)

unread,
Mar 27, 2020, 3:30:04 PM3/27/20
to jenkinsc...@googlegroups.com
Jorge Yanes edited a comment on Bug JENKINS-58753
I also have this problem.
{code:java}
2020-03-27 18:34:06.404+0000 [id=159] INFO i.j.p.zoom.ZoomNotifyClient#notify: Send notification to https://applications.zoom.us/addon/v2/jenkins/webhooks/xxxxxxxxxxxxxx_xxxxxxx, message: null

2020-03-27 18:34:27.464+0000 [id=159] SEVERE i.j.p.zoom.ZoomNotifyClient#notify: Error posting to Zoom, url: https://applications.zoom.us/addon/v2/jenkins/webhooks/xxxxxxxxxxxxxx_xxxxxxx, message: null{code}
 

At first I thought it was just ignoring the proxy settings on the advanced tab of the plugins management page, and that setting the following java opts could work
{code:java}
-Dhttp.proxyHost="proxy.xxxxxx.com" -Dhttp.proxyPort=3128 -Dhttps.proxyHost="proxy.xxxxxx.com" -Dhttps.proxyPort=3128 -Dhttp.nonProxyHosts="localhost|aaaa|aaaa.xxxxxx.com|bbbb|bbbb.xxxxxx.com"
{code}
but it did not.

 

I can access the URL both with Chrome and with the following in the Jenkins script console
{code:java}
ProxyConfiguration.open(new java.net.URL("https://applications.zoom.us/addon/v2/jenkins/webhooks/")).content
{code}
I get a 401 error, but that's ok, because this test is not providing the API token.

 So it is not a connectivity issue. It is clearly a code problem.

 



And it's using the Apache HTTP client to post to the API URL, but it never takes any proxy into account.

 


 

If I have time this weekend I might open a pull request. This doesn't seem difficult to do at all.

jyanes@notariado.org (JIRA)

unread,
Mar 28, 2020, 2:18:02 PM3/28/20
to jenkinsc...@googlegroups.com
Jorge Yanes updated an issue
 
Change By: Jorge Yanes
Attachment: image-2020-03-28-19-17-24-692.png

jyanes@notariado.org (JIRA)

unread,
Mar 28, 2020, 2:20:03 PM3/28/20
to jenkinsc...@googlegroups.com
Jorge Yanes updated an issue
Change By: Jorge Yanes
Attachment: image-2020-03-28-19-19-54-086.png

jyanes@notariado.org (JIRA)

unread,
Mar 28, 2020, 2:21:02 PM3/28/20
to jenkinsc...@googlegroups.com

jyanes@notariado.org (JIRA)

unread,
Mar 28, 2020, 2:22:03 PM3/28/20
to jenkinsc...@googlegroups.com
Jorge Yanes updated an issue
Change By: Jorge Yanes
Attachment: image-2020-03-28-19-17-24-692.png

jyanes@notariado.org (JIRA)

unread,
Mar 28, 2020, 3:19:02 PM3/28/20
to jenkinsc...@googlegroups.com
Jorge Yanes edited a comment on Bug JENKINS-58753
Done! [https://github.com/jenkinsci/zoom-plugin/pull/4]

It is working for me, I hope they merge it ;)

  

 !image-2020-03-28-19-19-54-086.png!
Reply all
Reply to author
Forward
0 new messages