[JIRA] (JENKINS-58717) Modify ATH to be compatible with new GitHub Branch Source UI

0 views
Skip to first unread message

kshultz@cloudbees.com (JIRA)

unread,
Jul 29, 2019, 4:27:02 PM7/29/19
to jenkinsc...@googlegroups.com
Karl Shultz created an issue
 
Jenkins / Bug JENKINS-58717
Modify ATH to be compatible with new GitHub Branch Source UI
Issue Type: Bug Bug
Assignee: Oliver Gondža
Attachments: image-2019-07-29-16-25-51-544.png
Components: acceptance-test-harness
Created: 2019-07-29 20:26
Environment: GitHub Branch Source 2.5.5
Priority: Minor Minor
Reporter: Karl Shultz

Summary
Starting with Git

The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a git clone command. The ATH needs to be modified to accomodate this.

The page now looks like this when creating a new project:

It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

kshultz@cloudbees.com (JIRA)

unread,
Jul 29, 2019, 4:28:03 PM7/29/19
to jenkinsc...@googlegroups.com
Karl Shultz updated an issue
 
Jenkins / Improvement JENKINS-58717
Change By: Karl Shultz
Issue Type: Bug Improvement

kshultz@cloudbees.com (JIRA)

unread,
Jul 29, 2019, 4:35:02 PM7/29/19
to jenkinsc...@googlegroups.com
Karl Shultz updated an issue
*Summary*
Starting with Git GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

*Details*
The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.
Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why the test was being [{{@Ignore}} d|https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/WorkflowMultibranchTest.java#L37].
The page now looks like this when creating a new project:
!image-2019-07-29-16-25-51-544.png|thumbnail!

It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.

kshultz@cloudbees.com (JIRA)

unread,
Jul 29, 2019, 4:35:03 PM7/29/19
to jenkinsc...@googlegroups.com
Karl Shultz updated an issue
*Summary*
Starting with GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.


*Details*
The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why the test was being set to [{{@Ignore}} d|https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/WorkflowMultibranchTest.java#L37].


The page now looks like this when creating a new project:
!image-2019-07-29-16-25-51-544.png|thumbnail!

It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.

kshultz@cloudbees.com (JIRA)

unread,
Jul 29, 2019, 4:36:03 PM7/29/19
to jenkinsc...@googlegroups.com
Karl Shultz updated an issue
*Summary*
Starting with GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

*Details*
The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why the test was set to [{{@Ignore}} d |https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/WorkflowMultibranchTest.java#L37].


The page now looks like this when creating a new project:
!image-2019-07-29-16-25-51-544.png|thumbnail!

It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.

kshultz@cloudbees.com (JIRA)

unread,
Jul 29, 2019, 4:37:01 PM7/29/19
to jenkinsc...@googlegroups.com
Karl Shultz updated an issue
*Summary*
Starting with GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

*Details*
The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why [ the test was set to [ {{@Ignore}}|https://github.com/jenkinsci/acceptance-test-harness/blob/ master e538cb7ffeeeb11ce5aad4de3b6bc59d03b9a56d /src/test/java/plugins/WorkflowMultibranchTest.java#L37].


The page now looks like this when creating a new project:
!image-2019-07-29-16-25-51-544.png|thumbnail!

It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.

kshultz@cloudbees.com (JIRA)

unread,
Jul 30, 2019, 10:59:02 AM7/30/19
to jenkinsc...@googlegroups.com
Karl Shultz assigned an issue to Karl Shultz
Change By: Karl Shultz
Assignee: Oliver Gondža Karl Shultz

kshultz@cloudbees.com (JIRA)

unread,
Jul 30, 2019, 11:05:02 AM7/30/19
to jenkinsc...@googlegroups.com

kshultz@cloudbees.com (JIRA)

unread,
Jul 30, 2019, 11:59:02 AM7/30/19
to jenkinsc...@googlegroups.com
Karl Shultz started work on Improvement JENKINS-58717
 
Change By: Karl Shultz
Status: Open In Progress

kshultz@cloudbees.com (JIRA)

unread,
Jul 30, 2019, 5:02:02 PM7/30/19
to jenkinsc...@googlegroups.com

I found a way to get past this, so I'm no longer blocked against 58071. But 58071 is still worth looking at.

The behavior was, when working on the ATH from IntelliJ IDEA, I wanted to set an environment variable specifying a war file. Something like this:

JENKINS_LOCAL_HOSTNAME=127.0.0.1;BROWSER=chrome;JENKINS_WAR=/some/path/to/jenkins.war

When running that way, I was having problems getting the UI to load correctly. The trace itself can be seen here.

kshultz@cloudbees.com (JIRA)

unread,
Jul 30, 2019, 5:03:02 PM7/30/19
to jenkinsc...@googlegroups.com

I've got a simple pull request up for review that adds the ability to set a single repository URL from a test, via the new field in GitHub Branch Source 2.5.5.

kshultz@cloudbees.com (JIRA)

unread,
Jul 30, 2019, 5:03:02 PM7/30/19
to jenkinsc...@googlegroups.com
Change By: Karl Shultz
Status: In Progress Review

kshultz@cloudbees.com (JIRA)

unread,
Jan 14, 2020, 12:03:09 PM1/14/20
to jenkinsc...@googlegroups.com
 

This was fixed with 541.
Change By: Karl Shultz
Status: In Review Resolved
Resolution: Fixed
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

kshultz@cloudbees.com (JIRA)

unread,
Jan 14, 2020, 12:03:09 PM1/14/20
to jenkinsc...@googlegroups.com
Karl Shultz closed an issue as Fixed
Change By: Karl Shultz
Status: Resolved Closed
Reply all
Reply to author
Forward
0 new messages