[JIRA] (JENKINS-58681) AbstractItem#checkRename() is NOOP while AbstractItem#doCheckNewName performans checks

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev created an issue

Jenkins / JENKINS-58681 AbstractItem#checkRename() is NOOP while AbstractItem#doCheckNewName performans checks Issue Type: Bug Assignee: Unassigned Components: core Created: 2019-07-26 14:01 Priority: Minor Reporter: Oleg Nenashev See AbstractItem.java #checkRename(@Nonnull String newName). This old method does not do anything by default whilst there is a new FormValidation doCheckNewName(@QueryParameter String newName) metod which does something. Somebody needs to investigate the reasons of two method existence and then integrate them somehow (if relevant) It is senseitive, because the Web UI method invokes Jenkins.checkGoodName() which invokes extension points to verify the correctness of the new name. Maybe we need the same for Plugin APIs     Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated an issue

Jenkins / JENKINS-58681 AbstractItem#checkRename() is NOOP while AbstractItem#doCheckNewName performans checks

Change By: Oleg Nenashev See [AbstractItem.java|https://github.com/jenkinsci/jenkins/pull/4122/files#diff-7703322191e82930e0d5d450dc9ba1ad] #checkRename(@Nonnull String newName). This old method does not do anything by default whilst there is a new FormValidation doCheckNewName(@QueryParameter String newName) metod which does something.

Somebody needs to investigate the reasons of two method existence and then integrate them somehow (if relevant)

It is senseitive, because the Web UI method invokes Jenkins.checkGoodName() which invokes ProjectNamingStrategy extension points to verify the correctness of the new name. Maybe we need the same for Plugin APIs

Add Comment