[JIRA] (JENKINS-58667) NumberFormatException when parsing deploy url

[reiner.wirtz@ser.de (JIRA)]

Reiner Wirtz updated an issue

Jenkins / JENKINS-58667 NumberFormatException when parsing deploy url Change By: Reiner Wirtz Summary: NumNumberFormatException NumberFormatException when parsing deploy url Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[robin.jansohn@zf.com (JIRA)]

Robin Jansohn commented on JENKINS-58667

Re: NumberFormatException when parsing deploy url OK, I found out what is causing the problem. In freestyle jobs the configurations are not updated automatically and the newly introduced path variable is undefined and therefore null}. As soon as the configuration is updated (it's enough to just press save without changes) the {{path variable is defined and everything works as expected. I just took over this plugin and I do not know if this kind of problem could have been prevented somehow. Oleg Nenashev Jesse Glick maybe you can tell us more about this?

Add Comment

[robin.jansohn@zf.com (JIRA)]

Robin Jansohn edited a comment on JENKINS-58667

Re: NumberFormatException when parsing deploy url

OK, I found out what is causing the problem. In freestyle jobs the configurations are not updated automatically and the newly introduced {{path}} variable is undefined and therefore {{null} }

. As soon as the configuration is updated (it's enough to just press save without changes) the {{path}} variable is defined and everything works as expected. I just took over this plugin and I do not know if this kind of problem could have been prevented somehow. [~oleg_nenashev] [~jglick] maybe you can tell us more about this?

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick commented on JENKINS-58667

Re: NumberFormatException when parsing deploy url

I am afraid I know very little about this plugin.

Add Comment

[robin.jansohn@zf.com (JIRA)]

Robin Jansohn commented on JENKINS-58667

Re: NumberFormatException when parsing deploy url

Jesse Glick it's more of a general question regarding Jenkins plugins. Is there any best practice to introduce new plugin configuration variables (with a default value) without needing to manually refresh freestyle job configurations? Here's the actual commit and the line which caused the trouble because it was always null until the job configuration was updated to the new plugin version: https://github.com/jenkinsci/deploy-plugin/commit/db254d7c8c70214c7da91308c50bedb25fbf4eb8#diff-b2a541c8af2e6626b795634cc9d7143dR48

Add Comment

[reiner.wirtz@ser.de (JIRA)]

Reiner Wirtz commented on JENKINS-58667

Re: NumberFormatException when parsing deploy url

I did the update to version 1.14 again and followed the hints given by Robin Jansohn. I saved the job, which used the plugin without any changes. Now the deploy worked again. Thanks for the help!

Add Comment

[reiner.wirtz@ser.de (JIRA)]

Reiner Wirtz commented on JENKINS-58667

Re: NumberFormatException when parsing deploy url

If there is a new version available, please let me know.

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick commented on JENKINS-58667

Re: NumberFormatException when parsing deploy url

Is there any best practice to introduce new plugin configuration variables (with a default value) without needing to manually refresh freestyle job configurations? Yes. https://jenkins.io/doc/developer/persistence/

Add Comment

[robin.jansohn@zf.com (JIRA)]

Robin Jansohn commented on JENKINS-58667

Re: NumberFormatException when parsing deploy url

Not sure I can follow. The introduced variable is a string and should be automatically serializable? Do you have an example where a new configuration option was introduced and did not require a manual refresh?

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick commented on JENKINS-58667

Re: NumberFormatException when parsing deploy url

I probably do not know what you are really asking here. Best to ask on the dev list with a concrete example.

Add Comment

[snoopi30@web.de (JIRA)]

Robin Jansohn started work on JENKINS-58667

Change By: Robin Jansohn Status: Open In Progress

Add Comment

[snoopi30@web.de (JIRA)]

Robin Jansohn resolved as Fixed

I just released v1.15 which should solve this kind of problem. It will be available in Jenkins in the next few hours.

Jenkins / JENKINS-58667

NumberFormatException when parsing deploy url

Change By: Robin Jansohn Status: In Progress Resolved Assignee: Robin Jansohn Resolution: Fixed Released As: https://github.com/jenkinsci/deploy-plugin/releases/tag/1.15

Add Comment