[JIRA] (JENKINS-58548) scriptText URL returns extra newlines

37 views
Skip to first unread message

szekeres@iii.hu (JIRA)

unread,
Jul 18, 2019, 8:28:02 AM7/18/19
to jenkinsc...@googlegroups.com
Istvan Szekeres created an issue
 
Jenkins / Bug JENKINS-58548
scriptText URL returns extra newlines
Issue Type: Bug Bug
Assignee: Unassigned
Components: core
Created: 2019-07-18 12:27
Priority: Major Major
Reporter: Istvan Szekeres

Between 2.184 and 2.186 it seems to have changed how the /scriptText endpoint returns the data, in 2.186 there are extra newlines at the start of the output which break some of our scripts that use this API to run scripts.

Running the command

curl -X POST https://jenkins/scriptText -F 'script=println "hello"'

produces the following output on 2.184:

hello 

but it produces this on on 2.186:



    hello

 

(On our servers we use crumb issuer and auth but for the sake of simplicity I omitted those from the curl command as I think it is probably irrelevant wrt the issue).

 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

dbeck@cloudbees.com (JIRA)

unread,
Jul 19, 2019, 4:15:02 AM7/19/19
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Labels: regression

dbeck@cloudbees.com (JIRA)

unread,
Jul 19, 2019, 4:15:03 AM7/19/19
to jenkinsc...@googlegroups.com

dbeck@cloudbees.com (JIRA)

unread,
Jul 19, 2019, 4:15:03 AM7/19/19
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Priority: Major Minor

boards@gmail.com (JIRA)

unread,
Jul 19, 2019, 11:04:02 AM7/19/19
to jenkinsc...@googlegroups.com
Matt Sicker commented on Bug JENKINS-58548
 
Re: scriptText URL returns extra newlines

Yeah, that could be. Perhaps we can revert the jelly file and just annotate the base model class?

boards@gmail.com (JIRA)

unread,
Jul 29, 2019, 2:16:02 PM7/29/19
to jenkinsc...@googlegroups.com
Matt Sicker assigned an issue to Matt Sicker
 
Change By: Matt Sicker
Assignee: Matt Sicker

boards@gmail.com (JIRA)

unread,
Jul 29, 2019, 2:16:03 PM7/29/19
to jenkinsc...@googlegroups.com
Matt Sicker started work on Bug JENKINS-58548
 
Change By: Matt Sicker
Status: Open In Progress

boards@gmail.com (JIRA)

unread,
Jul 29, 2019, 3:00:02 PM7/29/19
to jenkinsc...@googlegroups.com

boards@gmail.com (JIRA)

unread,
Jul 29, 2019, 3:01:02 PM7/29/19
to jenkinsc...@googlegroups.com
 
Re: scriptText URL returns extra newlines

https://github.com/jenkinsci/jenkins/pull/4133

Figured out the problem. Jelly will trim things by default, but a JEXL expression in l:view was introducing untrimmed whitespace for some reason. Refactoring the JEXL expression into vanilla Jelly tags fixed the whitespace issue.

dbeck@cloudbees.com (JIRA)

unread,
Aug 8, 2019, 5:47:02 AM8/8/19
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Labels: lts-candidate regression

o.v.nenashev@gmail.com (JIRA)

unread,
Aug 8, 2019, 10:45:05 AM8/8/19
to jenkinsc...@googlegroups.com
Change By: Oleg Nenashev
Status: In Review Resolved
Resolution: Fixed
Released As: Jenkins 2.189

dbeck@cloudbees.com (JIRA)

unread,
Aug 13, 2019, 8:29:02 AM8/13/19
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Labels: lts-candidate regression security-534

dbeck@cloudbees.com (JIRA)

unread,
Sep 5, 2019, 5:55:04 AM9/5/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages