[JIRA] (JENKINS-58403) Issue marked as new when the issue did exist in a previous build but on a different line

juliehirani@hotmail.com (JIRA)

unread,

Jul 9, 2019, 7:36:03 AM7/9/19

to jenkinsc...@googlegroups.com

Julie Shamji created an issue

Jenkins /

JENKINS-58403

Issue marked as new when the issue did exist in a previous build but on a different line

Issue Type:	Improvement
Assignee:	Ulli Hafner
Components:	warnings-ng-plugin
Created:	2019-07-09 11:35
Priority:	Minor
Reporter:	Julie Shamji

We have an issue which existed for a while, which is logged as which shows the issue is 24 days old:

RequestAccessMergeProcessor.java:432

com.unisys.holmes2.h2ng.workflow.business.requestaccess

In the next build, a change has been made to this file which moved this method to a new line, but the method remained unchanged. It is now logged as:

RequestAccessMergeProcessor.java:434

com.unisys.holmes2.h2ng.workflow.business.requestaccess

Metrics

JavaNCSSCheck

Normal

1

Are the new issues identified by line number or the line of code? The latter would be better as it is not a new issue even though it has moved lines.

This issue is a check style issue but this probably applies to all plugins.

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ullrich.hafner@gmail.com (JIRA)

unread,

Jul 9, 2019, 4:18:01 PM7/9/19

to jenkinsc...@googlegroups.com

Ulli Hafner commented on

JENKINS-58403

Re: Issue marked as new when the issue did exist in a previous build but on a different line

The comparison is using a two pass algorithm: in the first pass the properties of the warning are compared. If one property differs (e.g., line number) then this warning is moved to a second pass. In the second pass, the actual code is compared. This is currently done by checking the context above and below the warning (5 lines). Did the content (or whitespace) in the surrounding lines change?