[JIRA] (JENKINS-58315) Allow to customize serverUrl while using rocketSend step

25 views
Skip to first unread message

48c1375a@opayq.com (JIRA)

unread,
Jul 3, 2019, 5:48:02 AM7/3/19
to jenkinsc...@googlegroups.com
Maxime KILT created an issue
 
Jenkins / New Feature JENKINS-58315
Allow to customize serverUrl while using rocketSend step
Issue Type: New Feature New Feature
Assignee: Martin Reinhardt
Components: rocket-chat-notifier-plugin
Created: 2019-07-03 09:47
Priority: Major Major
Reporter: Maxime KILT

Today we can only use one RocketChat instance defined in general settings to send notifications. In our team we use multi RocketChat instances so we cannot use this plugin.

Would be nice if we can define a serverUrl directly in rocketSend step.

Example :

rocketSend serverUrl: 'https://myrocket.example.com', channel: 'general', message: 'My message'

Thanks!
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

hypery2k@web.de (JIRA)

unread,
Jul 3, 2019, 10:50:03 PM7/3/19
to jenkinsc...@googlegroups.com
Martin Reinhardt started work on New Feature JENKINS-58315
 
Change By: Martin Reinhardt
Status: Open In Progress

hypery2k@web.de (JIRA)

unread,
Jul 3, 2019, 10:50:04 PM7/3/19
to jenkinsc...@googlegroups.com
Martin Reinhardt commented on New Feature JENKINS-58315
 
Re: Allow to customize serverUrl while using rocketSend step

I see the issue, but how would you pass the login info the step? If we add this feature you also need to pass the login info here..

hypery2k@web.de (JIRA)

unread,
Jul 3, 2019, 10:50:04 PM7/3/19
to jenkinsc...@googlegroups.com
Martin Reinhardt assigned an issue to Maxime KILT
 
Change By: Martin Reinhardt
Assignee: Martin Reinhardt Maxime KILT

48c1375a@opayq.com (JIRA)

unread,
Jul 4, 2019, 3:49:02 AM7/4/19
to jenkinsc...@googlegroups.com
Maxime KILT commented on New Feature JENKINS-58315
 
Re: Allow to customize serverUrl while using rocketSend step

I don't think username/password are necessary when using a token. What are they for anyway?

48c1375a@opayq.com (JIRA)

unread,
Jul 4, 2019, 3:49:02 AM7/4/19
to jenkinsc...@googlegroups.com
Maxime KILT edited a comment on New Feature JENKINS-58315
I don't think username/password are necessary when using a token for our incoming webhook . What are they for anyway?

48c1375a@opayq.com (JIRA)

unread,
Jul 4, 2019, 3:54:03 AM7/4/19
to jenkinsc...@googlegroups.com
Maxime KILT edited a comment on New Feature JENKINS-58315
I don't think username/password are necessary when using a token for our incoming webhook. What are they for anyway?

For info, today we use the [Slack plugin|https://github.com/jenkinsci/slack-plugin#security] in a roundabout way for RocketChat but we cannot user the latest version:
{code:java}
slackSend(
    channel: 'jenkins',
    message: 'my message',
    baseUrl: 'https://myrocket.example.com/hooks/',
    teamDomain: 'myrocket',
    token: '0123456789'
)
{code}
 

48c1375a@opayq.com (JIRA)

unread,
Jul 4, 2019, 3:55:02 AM7/4/19
to jenkinsc...@googlegroups.com
Maxime KILT edited a comment on New Feature JENKINS-58315
I don't think username/password are necessary when using a token for our incoming webhook. What are they for anyway?

For info, today we use the [Slack plugin|https://github.com/jenkinsci/slack-plugin] in a roundabout way for RocketChat but we cannot user use the latest version:

{code:java}
slackSend(
    channel: 'jenkins',
    message: 'my message',
    baseUrl: 'https://myrocket.example.com/hooks/',
    teamDomain: 'myrocket',
    token: '0123456789'
)
{code}
 

48c1375a@opayq.com (JIRA)

unread,
Jul 4, 2019, 3:55:03 AM7/4/19
to jenkinsc...@googlegroups.com
Maxime KILT edited a comment on New Feature JENKINS-58315
I don't think username/password are necessary when using a token for our incoming webhook. What are they for anyway?

For info, today we use the [Slack plugin|https://github.com/jenkinsci/slack-plugin #security ] in a roundabout way for RocketChat but we cannot user the latest version:

{code:java}
slackSend(
    channel: 'jenkins',
    message: 'my message',
    baseUrl: 'https://myrocket.example.com/hooks/',
    teamDomain: 'myrocket',
    token: '0123456789'
)
{code}
 

48c1375a@opayq.com (JIRA)

unread,
Jul 4, 2019, 3:56:01 AM7/4/19
to jenkinsc...@googlegroups.com
Maxime KILT edited a comment on New Feature JENKINS-58315
I don't think username/password are necessary when using a token for our incoming webhook. What are they for anyway?

For info, today we use the [Slack plugin|https://github.com/jenkinsci/slack-plugin] v2.17 (latest version not working) in a roundabout way for RocketChat but we cannot use the latest version :

{code:java}
slackSend(
    channel: 'jenkins',
    message: 'my message',
    baseUrl: 'https://myrocket.example.com/hooks/',
    teamDomain: 'myrocket',
    token: '0123456789'
)
{code}
 

hypery2k@web.de (JIRA)

unread,
Jul 4, 2019, 4:47:01 AM7/4/19
to jenkinsc...@googlegroups.com

ok, I like the idea, i think could be easily added. But already struggeling with issues on the latest RocketChat API and will take some time to get it fixed

 

Nevertheless any PR with this feature is welcome

48c1375a@opayq.com (JIRA)

unread,
Jul 4, 2019, 9:51:01 AM7/4/19
to jenkinsc...@googlegroups.com

Yeah I think I will create a PR

48c1375a@opayq.com (JIRA)

unread,
Jul 4, 2019, 10:56:03 AM7/4/19
to jenkinsc...@googlegroups.com

hypery2k@web.de (JIRA)

unread,
Jul 4, 2019, 3:59:02 PM7/4/19
to jenkinsc...@googlegroups.com
Change By: Martin Reinhardt
Status: In Progress Fixed but Unreleased
Resolution: Fixed

hypery2k@web.de (JIRA)

unread,
Jul 4, 2019, 3:59:02 PM7/4/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages