[JIRA] (JENKINS-58205) GenerateTestHpl task should be reusable and declare its inputs and dependencies

[mail@marcphilipp.de (JIRA)]

Marc Philipp created an issue

Jenkins / JENKINS-58205 GenerateTestHpl task should be reusable and declare its inputs and dependencies Issue Type: Improvement Assignee: Steve Hill Components: gradle-jpi-plugin Created: 2019-06-26 08:27 Priority: Major Reporter: Marc Philipp We're using the gradle-jpi-plugin for one subproject in a multi-module build. We needed to consume a .hpl file in another subproject. Thus, we used the GenerateTestHpl task to generate the.hpl and noticed a few problems: The task does not declare its dependencies, i.e. if the Jenkins plugin subproject is not built, the Resource-Path property in the resulting file was incomplete because the classes directories did not exist at the time it was written. The task does not declare its inputs, i.e. if a relevant property such as the shortName changes, it is still up-to-date. The server task also generates a .hpl file but does not use the GenerateTestHpl task. It would be more idiomatic and reduce duplication to have a generic task that can generate a .hpl file and configure it once for the server task and once for the generate-test-hpl task. Proposals: Introduce "generic" GenerateHpl task that properly declares its inputs, outputs, and dependencies and use it for both the server and generate-test-hpl task. If you agree with the above proposal, we could submit a PR. Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[sghill.dev@gmail.com (JIRA)]

Steve Hill commented on JENKINS-58205

Re: GenerateTestHpl task should be reusable and declare its inputs and dependencies Marc Philipp sounds good to me! Feel free to send in a PR.

Add Comment