[JIRA] (JENKINS-58149) p4-plugin 1.10.0 does not sync to label correctly

0 views
Skip to first unread message

eric.boehm@broadcom.com (JIRA)

unread,
Jun 21, 2019, 3:40:02 PM6/21/19
to jenkinsc...@googlegroups.com
Eric Boehm updated an issue
 
Jenkins / Bug JENKINS-58149
p4-plugin 1.10.0 does not sync to label correctly
Change By: Eric Boehm
If you try to sync to a label, the p4plugin p4-plugin syncs to latest changelist instead.

This does not happen in p4plugin 1.9.7

Output from same client, different version of plugin

p4-plugin 1.10.0
P4 Task: syncing files at change: 230943
p4 sync -q /auto/wksp/test_client/...@230943
duration: 0m 26s

p4-plugin 1.9.7
p4 label -o REL_XXX +
P4 Task: syncing files at client/label: REL_XXX
p4 sync -q /auto/wksp/test_client/...@REL_XXX +
00:00:39 duration: (280ms)

Note that there is no p4 label -o REL_XXX output for p4-plugin 1.10.0
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

eric.boehm@broadcom.com (JIRA)

unread,
Jun 21, 2019, 3:40:02 PM6/21/19
to jenkinsc...@googlegroups.com
Eric Boehm updated an issue
Change By: Eric Boehm
Summary: P4 Pluging p4-plugin 1.10.0 does not sync to label correctly

dwhitfield@perforce.com (JIRA)

unread,
Jun 21, 2019, 5:19:01 PM6/21/19
to jenkinsc...@googlegroups.com
Doug Whitfield commented on Bug JENKINS-58149
 
Re: p4-plugin 1.10.0 does not sync to label correctly

label worked for me on 1.9.7, but I see this in the 1.10.0 console:

 

 

(p4):stop:10
P4: Warning label is static and cannot be used with polling!
(p4):cmd:... p4 counter DCIlabel
p4 counter DCIlabel

 

looks like there are some related issues. Will investigate

dwhitfield@perforce.com (JIRA)

unread,
Jun 21, 2019, 5:26:02 PM6/21/19
to jenkinsc...@googlegroups.com

the suggested "Similar Issues" do not seem to relevant

dwhitfield@perforce.com (JIRA)

unread,
Jun 21, 2019, 5:27:01 PM6/21/19
to jenkinsc...@googlegroups.com

dwhitfield@perforce.com (JIRA)

unread,
Jun 21, 2019, 5:27:02 PM6/21/19
to jenkinsc...@googlegroups.com

dwhitfield@perforce.com (JIRA)

unread,
Jun 21, 2019, 5:30:01 PM6/21/19
to jenkinsc...@googlegroups.com

dwhitfield@perforce.com (JIRA)

unread,
Jun 24, 2019, 11:25:02 AM6/24/19
to jenkinsc...@googlegroups.com
 
Re: p4-plugin 1.10.0 does not sync to label correctly

Eric noted in the ticket that the Warning is there in 1.7.2. Upon reviewing my 1.9.7 console, I can confirm I also see that. That was just the first thing I saw that looked off, so I didn't post the rest of the console. You can see below that the behavior in mine is slightly different. Instead of using the latest changelist, mine uses change -1 for some reason. My assumption is these are the same issue, but I could not say for sure. In any case, the fact remains that 1.9.7 works and 1.10.0 doesn't.

 

My 1.10.0 output is a little different:

 
P4: no revisions under //jenkins-notaclientyettest/...@DCIlabel using change: -1... p4 repos -C -
p4 repos -C
P4: builds: -1 ... p4 client -o jenkins-notaclientyettest -
p4 client -o jenkins-notaclientyettest
... p4 info +
 
... p4 info +
 
... p4 client -o jenkins-notaclientyettest +
 
P4 Task: establishing connection.
... server: 10.5.10.123:10000
... node: dwhitfield-CentOS7-p4d-withgui
Building on Node: master... p4 client -o jenkins-notaclientyettest +
 
... p4 info +
 
... p4 info +
 
... p4 client -o jenkins-notaclientyettest +
 
P4 Task: establishing connection.
... server: 10.5.10.123:10000
... node: dwhitfield-CentOS7-p4d-withgui

P4 Task: syncing files at change: -1... p4 sync -q /var/lib/jenkins/workspace/testing labels/...@-1 +
 
P4 Task: attempt: 1
ERROR: P4: Task Exception: com.perforce.p4java.exception.P4JavaException: com.perforce.p4java.exception.P4JavaException: hudson.AbortException: P4JAVA: Error(s):
Invalid changelist/client/label/date '@-1'.

wbasu@perforce.com (JIRA)

unread,
Sep 26, 2019, 6:56:02 AM9/26/19
to jenkinsc...@googlegroups.com
W Basu Perforce assigned an issue to Paul Allen
 

Hi Paul Allen, as discussed please have a look at this issue.

Change By: W Basu Perforce
Assignee: Paul Allen
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

pallen@perforce.com (JIRA)

unread,
Sep 26, 2019, 8:36:03 AM9/26/19
to jenkinsc...@googlegroups.com
Paul Allen commented on Bug JENKINS-58149
 
Re: p4-plugin 1.10.0 does not sync to label correctly

`P4: Warning label is static and cannot be used with polling!`

Static labels are not supported as they may represent more than one changelist number.  Please use an automatic label.

pallen@perforce.com (JIRA)

unread,
Sep 26, 2019, 8:36:04 AM9/26/19
to jenkinsc...@googlegroups.com
Paul Allen closed an issue as Won't Fix
 
Change By: Paul Allen
Status: Open Closed
Resolution: Won't Fix

eric.boehm@broadcom.com (JIRA)

unread,
Sep 26, 2019, 8:50:02 AM9/26/19
to jenkinsc...@googlegroups.com
Eric Boehm commented on Bug JENKINS-58149
 
Re: p4-plugin 1.10.0 does not sync to label correctly

This is pretty disappointing as 1.9.7 and earlier had no problem with static labels. Our workflow is dependent on static labels

eric.boehm@broadcom.com (JIRA)

unread,
Sep 26, 2019, 9:20:07 AM9/26/19
to jenkinsc...@googlegroups.com

We can work around it by doing the p4 sync @label in a build step but that means re-configuring a bunch of jobs.

wbasu@perforce.com (JIRA)

unread,
Sep 26, 2019, 9:35:04 AM9/26/19
to jenkinsc...@googlegroups.com

Hi Eric Boehm, we will interested to know why automatic labels are not an option for your workflow, so if you could explain that would be great. Happy to reach out via our customer support and have call with you if needed.

 

pallen@perforce.com (JIRA)

unread,
Oct 1, 2019, 6:20:02 AM10/1/19
to jenkinsc...@googlegroups.com
Paul Allen reopened an issue
 

Verified Static labels can be used to sync source:

P4 Task: syncing files at client/label: static1
p4 sync -q /var/xxx/workspace/staticLabelSync/...@static1
Change By: Paul Allen
Resolution: Won't Fix
Status: Closed Reopened

pallen@perforce.com (JIRA)

unread,
Oct 1, 2019, 6:44:02 AM10/1/19
to jenkinsc...@googlegroups.com
Paul Allen edited a comment on Bug JENKINS-58149
 
Re: p4-plugin 1.10.0 does not sync to label correctly
Verified (master codeline) Static labels can be used to sync source:
{code:java}
P4
: Warning label is static and cannot be used with polling!
... p4 counter static1 +
P4: builds: static1

###

P4
Task: syncing files at client/label: static1
p4 sync -q /var/
xxx ### /workspace/staticLabelSync/...@static1{code}

pallen@perforce.com (JIRA)

unread,
Oct 1, 2019, 8:05:02 AM10/1/19
to jenkinsc...@googlegroups.com

I'll look into the polling logic and see if it can manage static labels. 

Polling will need to poll against the old label name (e.g. static1), so changes will only get found if a new label (e.g. static2) is used and has newer revisions.  Updating the original label (e.g. static1) would have no effect as the comparison is using the label's name and not its content.

pallen@perforce.com (JIRA)

unread,
Oct 1, 2019, 12:22:05 PM10/1/19
to jenkinsc...@googlegroups.com

pallen@perforce.com (JIRA)

unread,
Oct 1, 2019, 12:24:02 PM10/1/19
to jenkinsc...@googlegroups.com
Paul Allen updated Bug JENKINS-58149
 

Ready for release.

Change By: Paul Allen
Status: Reopened Fixed but Unreleased
Resolution: Fixed

pallen@perforce.com (JIRA)

unread,
Oct 1, 2019, 12:24:03 PM10/1/19
to jenkinsc...@googlegroups.com
Paul Allen updated an issue
Change By: Paul Allen
Comment: Ready for release.

eric.boehm@broadcom.com (JIRA)

unread,
Oct 1, 2019, 12:26:04 PM10/1/19
to jenkinsc...@googlegroups.com
Eric Boehm commented on Bug JENKINS-58149
 
Re: p4-plugin 1.10.0 does not sync to label correctly

Is there a way to download so that I can test it?

eric.boehm@broadcom.com (JIRA)

unread,
Oct 1, 2019, 1:53:03 PM10/1/19
to jenkinsc...@googlegroups.com

I downloaded and built it and it syncs correctly with a static label.

pallen@perforce.com (JIRA)

unread,
Oct 2, 2019, 10:54:05 AM10/2/19
to jenkinsc...@googlegroups.com
 

Released in 1.10.4

Change By: Paul Allen
Status: Fixed but Unreleased Closed
Reply all
Reply to author
Forward
0 new messages