[JIRA] (JENKINS-57877) PromotionBadge compatibility with pipelines

27 views
Skip to first unread message

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 6, 2019, 5:23:03 AM6/6/19
to jenkinsc...@googlegroups.com
Prastik Gyawali started work on Task JENKINS-57877
 
Change By: Prastik Gyawali
Status: Open In Progress
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 6, 2019, 5:23:03 AM6/6/19
to jenkinsc...@googlegroups.com
Prastik Gyawali created an issue
 
Jenkins / Task JENKINS-57877
PromotionBadge compatibility with pipelines
Issue Type: Task Task
Assignee: Prastik Gyawali
Components: promoted-builds-plugin
Created: 2019-06-06 09:22
Labels: gsoc-2019 gsoc2019-artifact-promotion-in-pipeline
Priority: Minor Minor
Reporter: Prastik Gyawali

PromotionBadge class is to be made pipeline compatible:

Required changes during the course:

  • Refactor the PromotionBadge class
  • Make a new interface analogous to Promotion.java
  • Refactor both ManualCondition and GroovyCondition which are the implementations of buildEnvVars.

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 6, 2019, 6:56:02 AM6/6/19
to jenkinsc...@googlegroups.com
Prastik Gyawali updated an issue
Change By: Prastik Gyawali
[Note]: Pipeline Steps are not incorporated in this task.
PromotionBadge class is to be made pipeline compatible:

Required changes during the course:
* Refactor the PromotionBadge class
* Make a new interface analogous to Promotion.java
* Refactor both ManualCondition and GroovyCondition which are the implementations of buildEnvVars.

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 7, 2019, 9:36:02 PM6/7/19
to jenkinsc...@googlegroups.com
Change By: Prastik Gyawali
Status: In Progress Review

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 8, 2019, 9:44:02 AM6/8/19
to jenkinsc...@googlegroups.com
Change By: Prastik Gyawali
Status: In Review Resolved
Resolution: Fixed

o.v.nenashev@gmail.com (JIRA)

unread,
Jun 9, 2019, 12:59:01 PM6/9/19
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Task JENKINS-57877
 
Re: PromotionBadge compatibility with pipelines

The ticket is marked as resolved, but there was no final implementation suggested in a PR and merged into Promoted Builds. Am I missing something?

jnz@topdanmark.dk (JIRA)

unread,
Jun 10, 2019, 8:20:03 AM6/10/19
to jenkinsc...@googlegroups.com
Jon Brohauge reopened an issue
 

Status should not be resolved prior to merge on the relevant PR
Change By: Jon Brohauge
Resolution: Fixed
Status: Resolved Reopened

jnz@topdanmark.dk (JIRA)

unread,
Jun 10, 2019, 8:21:01 AM6/10/19
to jenkinsc...@googlegroups.com
Jon Brohauge started work on Task JENKINS-57877
 
Change By: Jon Brohauge
Status: Reopened In Progress

jnz@topdanmark.dk (JIRA)

unread,
Jun 10, 2019, 8:22:02 AM6/10/19
to jenkinsc...@googlegroups.com
Jon Brohauge edited a comment on Task JENKINS-57877
Status should not be resolved prior to merge on the relevant PR


Status set to be _in progress,_ since __ there is no PR, or other solution presented to resolve this ticket.

jnz@topdanmark.dk (JIRA)

unread,
Jun 10, 2019, 8:22:03 AM6/10/19
to jenkinsc...@googlegroups.com

o.v.nenashev@gmail.com (JIRA)

unread,
Jun 12, 2019, 6:38:02 AM6/12/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
[Note]: Pipeline Steps are not incorporated in this task.

PromotionBadge class is to be made pipeline compatible:

Required changes during the course:
* Refactor the PromotionBadge class
* Make a new interface analogous to Promotion.java
* Refactor both ManualCondition and GroovyCondition which are the implementations of buildEnvVars .

* There is a "addPromotionBadge()" pipeline step which demonstrates the compatibility
* There is is a documentation sample which shows how to use the feature in Pipeline

2017uec1250@mnit.ac.in (JIRA)

unread,
Jun 13, 2019, 6:23:02 AM6/13/19
to jenkinsc...@googlegroups.com
Prastik Gyawali updated an issue
Change By: Prastik Gyawali
[Note]: Pipeline Steps are not incorporated in this task.

PromotionBadge class is to be made pipeline compatible:

Required changes during the course:
* Refactor the PromotionBadge class
* Make a new interface analogous to Promotion.java
* Refactor both ManualCondition and GroovyCondition which are the implementations of buildEnvVars
* There is a "addPromotionBadge()" pipeline step which demonstrates the compatibility
* There is is a documentation sample which shows how to use the feature in Pipeline


 Acceptance Criteria:
* Refactor the PromotionBadge class for pipeline compatibility.
* Changes made to Groovy+Manual Condition for binary compatibility.
* Changes made to Promotion and Status classes for binary compatibility.
* Introduction of a new Interface PromotionRun.
* Add the "AddPromotionBadge" class for checking on-spot.
* Unit/Compilation Tests before Merge.

o.v.nenashev@gmail.com (JIRA)

unread,
Jul 2, 2019, 2:46:05 AM7/2/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Sprint: GSoC 2019. Coding Phase 1 , GSoC 2019. Coding Phase 2

o.v.nenashev@gmail.com (JIRA)

unread,
Jul 30, 2019, 3:29:15 AM7/30/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Sprint: GSoC 2019. Coding Phase 1, GSoC 2019. Coding Phase 2 , GSoC 2019. Coding Phase 3

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 16, 2019, 7:31:06 AM12/16/19
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Unassigned
 

Moving the issue to the JENKINS-36089 EPIC
Change By: Oleg Nenashev
Assignee: Prastik Gyawali
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 16, 2019, 7:35:06 AM12/16/19
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Oleg Nenashev
Change By: Oleg Nenashev
Assignee: Oleg Nenashev
Reply all
Reply to author
Forward
0 new messages