[JIRA] (JENKINS-57804) Typo in JenkinsDatabaseSecurityRealm pageobject breaks allowSignup method

8 views
Skip to first unread message

mikecirioli@gmail.com (JIRA)

unread,
May 31, 2019, 4:12:01 PM5/31/19
to jenkinsc...@googlegroups.com
mike cirioli created an issue
 
Jenkins / Bug JENKINS-57804
Typo in JenkinsDatabaseSecurityRealm pageobject breaks allowSignup method
Issue Type: Bug Bug
Assignee: mike cirioli
Components: acceptance-test-harness
Created: 2019-05-31 20:11
Priority: Minor Minor
Reporter: mike cirioli

The page object that can be used to configure the JenkinsDatabaseSecurityRealm in acceptance tests has a typo in the element name used to enable/disable the ability for users to self-register (ie. signup) when using this realm. The jelly form control is named allowsSignup but the pageobject references it using the name "allowSignup". This causes any ATH tests that rely on manipulating that element to fail with an element not found/Timeout exception.

This was brought to light as the result of a recent change that forces the UI behavior to disable user signup by default (as a security precaution)., which in turn caused some tests, which expected this to be enabled by default, to break.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

mikecirioli@gmail.com (JIRA)

unread,
May 31, 2019, 4:12:02 PM5/31/19
to jenkinsc...@googlegroups.com
mike cirioli updated an issue
Change By: mike cirioli
The page object that can be used to configure the {{JenkinsDatabaseSecurityRealm}} in acceptance tests has a typo in the element name used to enable/disable the ability for users to self-register (ie. signup) when using this realm.  The jelly form control is named {{allowsSignup}} but the pageobject references it using the name " {{ allowSignup }}
".  This causes any ATH tests that rely on manipulating that element to fail with an element not found/Timeout  exception.

[This was brought to light as the result of a recent change that forces the UI behavior to disable user signup by default (as a security precaution).|https://github.com/jenkinsci/jenkins/pull/3954/files#diff-aec8de1c6c772be0d3ecb3573c46ead8L29], which in turn caused some tests, which expected this to be enabled by default, to break.

mikecirioli@gmail.com (JIRA)

unread,
May 31, 2019, 4:13:01 PM5/31/19
to jenkinsc...@googlegroups.com

jnord@cloudbees.com (JIRA)

unread,
Jul 2, 2019, 12:31:02 PM7/2/19
to jenkinsc...@googlegroups.com
James Nord closed an issue as Fixed
Change By: James Nord
Status: Open Closed
Resolution: Fixed
Reply all
Reply to author
Forward
0 new messages