[JIRA] (JENKINS-57784) Add a `none` option when no credential is added to server configuration

10 views
Skip to first unread message

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 6:33:01 AM5/31/19
to jenkinsc...@googlegroups.com
Parichay Barpanda created an issue
 
Jenkins / Improvement JENKINS-57784
Add a `none` option when no credential is added to server configuration
Issue Type: Improvement Improvement
Assignee: Parichay Barpanda
Components: gitlab-branch-source-plugin, gitlab-plugin
Created: 2019-05-31 10:32
Labels: gsoc-2019
Priority: Major Major
Reporter: Parichay Barpanda

1) Add Java 8 functional interfaces for behavioural design pattern

4) Add a `none` option when no credential is added to server configuration

5) The credentials list box also enlists credentials generated for other SCMs, same with Gitea Plugin. See how gitlab-plugin and github-plugin do it. Fixed it by adding a lambda to check if credentials belong our plugin personal Token implementation. Also send PR to Gitea Plugin.

6) Add text descriptions to the text boxes for help like GitLab Plugin.

All features with strikethroughs are implemented.
 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 6:35:02 AM5/31/19
to jenkinsc...@googlegroups.com
Parichay Barpanda started work on Improvement JENKINS-57784
 
Change By: Parichay Barpanda
Status: Open In Progress

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 6:35:02 AM5/31/19
to jenkinsc...@googlegroups.com
Parichay Barpanda updated an issue
Change By: Parichay Barpanda
Sprint: GSoC 2019. Coding Phase 1
1) Add Java 8 functional interfaces for behavioural design pattern

4) -Add a `none` option when no credential is added to server configuration-

5) -The credentials list box also enlists credentials generated for other SCMs
In some cases , same with Gitea Plugin. See how gitlab-plugin and github-plugin do it.- Fixed it by adding a lambda user might not require to check if supply credentials belong our plugin personal Token implementation. Also send PR to Gitea Plugin.

6) -Add text descriptions to
or maybe the text boxes for help like GitLab Plugin credentials listbox is empty . -

All features with strikethroughs are implemented
So in that case, credentialsId listbox should display an empty value .
 

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 6:38:01 AM5/31/19
to jenkinsc...@googlegroups.com
Parichay Barpanda edited a comment on Improvement JENKINS-57784
 
Re: Add a `none` option when no credential is added to server configuration
This was fixed by chaining a method to the StandardListBox object returned from the `doFillCredentialsIdItems` method.

The ListBox returned is:

{{ new StandardListBoxModel()
                .includeEmptyValue()
                .includeMatchingAs(...)
}}

This was inspired from GitHub Plugin. Can also be implemented in Gitea Plugin.

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 6:38:02 AM5/31/19
to jenkinsc...@googlegroups.com
Parichay Barpanda resolved as Fixed
 

This was fixed by chaining a method to the StandardListBox object returned from the `doFillCredentialsIdItems` method.

The ListBox returned is:

{{new StandardListBoxModel()
.includeEmptyValue()
.includeMatchingAs(...)}}

This was inspired from GitHub Plugin. Can also be implemented in Gitea Plugin.

Change By: Parichay Barpanda
Status: In Progress Resolved
Resolution: Fixed

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 3:02:01 PM5/31/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages