[JIRA] (JENKINS-57783) Make manage hooks independent of credentials

8 views
Skip to first unread message

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 6:30:02 AM5/31/19
to jenkinsc...@googlegroups.com
Parichay Barpanda created an issue
 
Jenkins / Improvement JENKINS-57783
Make manage hooks independent of credentials
Issue Type: Improvement Improvement
Assignee: Parichay Barpanda
Components: gitlab-branch-source-plugin, gitlab-plugin
Created: 2019-05-31 10:29
Labels: gsoc-2019
Priority: Major Major
Reporter: Parichay Barpanda

1) Add Java 8 functional interfaces for behavioural design pattern

4) Add a `none` option when no credential is added to server configuration

5) The credentials list box also enlists credentials generated for other SCMs, same with Gitea Plugin. See how gitlab-plugin and github-plugin do it. Fixed it by adding a lambda to check if credentials belong our plugin personal Token implementation. Also send PR to Gitea Plugin.

6) Add text descriptions to the text boxes for help like GitLab Plugin.

All features with strikethroughs are implemented.
 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 6:32:01 AM5/31/19
to jenkinsc...@googlegroups.com
Parichay Barpanda updated an issue
Change By: Parichay Barpanda
1) Add Java 8 functional interfaces for behavioural design pattern

4) -Add a `none` option when no credential In Gitea Plugin, the webhooks management is added related to server configuration-

5) -The
the credentials list box also enlists credentials generated for other SCMs, same with Gitea Plugin . See how gitlab-plugin and github-plugin do it Initially the configuration was made like that but in some case user might not require setting up webhooks . - Fixed Or the in simple words, it by adding a lambda is better to keep them uncorrelated. Although a check during `manage webhooks` is required if credentials belong our plugin personal Token implementation. Also send PR to Gitea Plugin.

6) -Add text descriptions to
the text boxes for help like GitLab Plugin.-

All features with strikethroughs
credentials are implemented supplied .
 

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 6:32:02 AM5/31/19
to jenkinsc...@googlegroups.com
Parichay Barpanda started work on Improvement JENKINS-57783
 
Change By: Parichay Barpanda
Status: Open In Progress

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 6:33:01 AM5/31/19
to jenkinsc...@googlegroups.com
Parichay Barpanda resolved as Fixed
 

Made both credentials and managehooks field independent of each other. Will later add credentials check during web hooks selection.

Change By: Parichay Barpanda
Status: In Progress Resolved
Resolution: Fixed

parichay.barpanda@gmail.com (JIRA)

unread,
May 31, 2019, 3:01:01 PM5/31/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages