[JIRA] (JENKINS-57677) Create new repo for GSoC gitlab-branch-source-plugin

29 views
Skip to first unread message

marky.r.jackson@gmail.com (JIRA)

unread,
May 24, 2019, 3:49:02 PM5/24/19
to jenkinsc...@googlegroups.com
Marky Jackson created an issue
 
Jenkins / Task JENKINS-57677
Create new repo for GSoC gitlab-branch-source-plugin
Issue Type: Task Task
Assignee: Oleg Nenashev
Components: gitlab-branch-source-plugin
Created: 2019-05-24 19:48
Priority: Minor Minor
Reporter: Marky Jackson

For the GSoC project   gitlab-branch-source-plugin the student is requesting a new repo be created titled "gitlab-branch-plugin

 

Detailed reasoning for this is here: 

2) I read the documentation of SCM API}}and {{Branch API Plugins to understand the classes needs to be implemented in GitLab Branch Source Plugin. Based on which I prepared the design document. This design document will be improved throughout the course of development. Will add apis, workflow, issues etc to it.

3) I have been studing the codebases of ArgelBargel's GitLab Branch Source Plugin, GitHub Branch Source Plugin}}and {{Gitea Plugin. My takeaway was GitLab BS has been implemented in a way that is not very different from the other Branch Source Plugins in terms of the underlying APIs implementation but still exists some differences that cannot be ignored. For example,

i) The class names are different and many code refractories has been done so it creates a difficulty in implementing the same logic while extending the plugin. Like SCMSource has been broken down to other sub classes , SCMHeadCategory has some different implementation, SCMFileSystem is not implemented, APIs implementation also needs to be changed and the list goes on..

ii) The conclusion I have come to is that it would be rather lesser amount of work for me if I had to implement a new GitLab Branch Source Plugin which will be heavily inspired from Gitea Plugin (as suggested by Robert Sandall in mailing list) and also some inspiration will be taken from GitLab Branch Source and GitHub Branch Source Plugins.

iii) I will send my compelete list of reasons not to develop the existing GitLab Branch Source Plugin.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

marky.r.jackson@gmail.com (JIRA)

unread,
May 24, 2019, 3:53:02 PM5/24/19
to jenkinsc...@googlegroups.com

o.v.nenashev@gmail.com (JIRA)

unread,
May 25, 2019, 10:01:02 AM5/25/19
to jenkinsc...@googlegroups.com

parichay.barpanda@gmail.com (JIRA)

unread,
May 25, 2019, 10:09:08 AM5/25/19
to jenkinsc...@googlegroups.com

Marky Jackson I got this. I have already hosted a plugin so I am aware of the procedure. In that case there was also a conflicting plugin name and the older plugin was renamed and archived. You just have to handle this initial part. i.e. discuss with Kohsuke Kawaguchi to either allow us push access to GitLab Branch Source Plugin or follow the archiving procedure. 

After ^this is done, I will proceed with the hosting process accordingly.

marky.r.jackson@gmail.com (JIRA)

unread,
May 25, 2019, 10:25:02 AM5/25/19
to jenkinsc...@googlegroups.com

Parichay Barpanda Oleg Nenashev I think in the interest of time we should just use the current plugin GitHub repo (https://github.com/jenkinsci/gitlab-branch-source-plugin). So we will need to request access to this by becoming the maintainers, is that correct Oleg Nenashev and to do so we will need to request that through the jenkins-dev mailing? If so, I fear that the usual time it takes for the to happen can be lengthily, is there something we can do to expedite that faster Oleg Nenashev

marky.r.jackson@gmail.com (JIRA)

unread,
May 25, 2019, 10:40:03 AM5/25/19
to jenkinsc...@googlegroups.com

parichay.barpanda@gmail.com (JIRA)

unread,
May 25, 2019, 10:40:04 AM5/25/19
to jenkinsc...@googlegroups.com

I don't think hosting our plugin I'm 'jenkinsci' org is an urgent requirement. Although I agree we should start this process early lest it takes time. I will start a new repo on the test org I created for GSoC (I'll add you there) and when our plugin reaches releasable state, we can always fork it into 'jenkinsci' org.

linuxsuren@gmail.com (JIRA)

unread,
May 25, 2019, 11:14:03 AM5/25/19
to jenkinsc...@googlegroups.com
Rick commented on Task JENKINS-57677

That's a good idea. We can start from design, coding. When we think it's ready. Then fork it.

mark.earl.waite@gmail.com (JIRA)

unread,
May 25, 2019, 1:38:04 PM5/25/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
 
Change By: Mark Waite
For the GSoC project   [gitlab-branch-source-plugin|https://issues.jenkins-ci.org/issues/?jql=project+%3D+JENKINS+AND+component+%3D+gitlab-branch-source-plugin] the student is requesting a new repo be created titled "gitlab-branch-plugin


 

Detailed reasoning for this is here: 

2) I read the documentation of {{SCM API}}and {{Branch API}} Plugins to understand the classes needs to be implemented in {{GitLab Branch Source Plugin}}. Based on which I prepared the design document. This design document will be improved throughout the course of development. Will add apis, workflow, issues etc to it.

3) I have been studing the codebases of {{ArgelBargel's GitLab Branch Source Plugin}}, {{GitHub Branch Source Plugin}}and {{Gitea Plugin}}. My takeaway was {{GitLab BS}} has been implemented in a way that is not very different from the other Branch Source Plugins in terms of the underlying APIs implementation but still exists some differences that cannot be ignored. For example,


i) The class names are different and many code refractories has been done so it creates a difficulty in implementing the same logic while extending the plugin. Like {{SCMSource}} has been broken down to other sub classes , {{SCMHeadCategory}} has some different implementation, {{SCMFileSystem}} is not implemented, APIs implementation also needs to be changed and the list goes on..

ii) The conclusion I have come to is that it would be rather lesser amount of work for me if I had to implement a new {{GitLab Branch Source Plugin}} which will be heavily inspired from {{Gitea Plugin}} (as suggested by Robert Sandall in mailing list) and also some inspiration will be taken from {{GitLab Branch Source}} and {{GitHub Branch Source}} Plugins.

iii) I will send my compelete list of reasons not to develop the existing {{GitLab Branch Source}} Plugin.

mark.earl.waite@gmail.com (JIRA)

unread,
May 25, 2019, 1:38:04 PM5/25/19
to jenkinsc...@googlegroups.com

parichay.barpanda@gmail.com (JIRA)

unread,
May 25, 2019, 5:47:02 PM5/25/19
to jenkinsc...@googlegroups.com

parichay.barpanda@gmail.com (JIRA)

unread,
May 25, 2019, 5:52:03 PM5/25/19
to jenkinsc...@googlegroups.com

parichay.barpanda@gmail.com (JIRA)

unread,
May 25, 2019, 5:52:03 PM5/25/19
to jenkinsc...@googlegroups.com
Parichay Barpanda commented on Task JENKINS-57677
 
Re: Create new repo for GSoC gitlab-branch-source-plugin

GitLab Branch Source Plugin has been created here - [#https://github.com/baymac/gitlab-branch-source-plugin] 

The repository will also contain server configuration implementation and later moved into a different plugin.

parichay.barpanda@gmail.com (JIRA)

unread,
May 25, 2019, 5:53:02 PM5/25/19
to jenkinsc...@googlegroups.com
Parichay Barpanda updated an issue
Change By: Parichay Barpanda
For the GSoC project   [gitlab-branch-source-plugin|https://issues.jenkins-ci.org/issues/?jql=project+%3D+JENKINS+AND+component+%3D+gitlab-branch-source-plugin] the student is requesting a new repo be created titled "gitlab-branch-plugin

 

Detailed reasoning for this is here: 

2) I read the documentation of {{SCM API}} and {{Branch API}} Plugins to understand the classes needs to be implemented in {{GitLab Branch Source Plugin}}. Based on which I prepared the design document. This design document will be improved throughout the course of development. Will add apis, workflow, issues etc to it.

3) I have been studing the codebases of {{ArgelBargel's GitLab Branch Source Plugin}}, {{GitHub Branch Source Plugin}} and {{Gitea Plugin}}. My takeaway was {{GitLab BS}} has been implemented in a way that is not very different from the other Branch Source Plugins in terms of the underlying APIs implementation but still exists some differences that cannot be ignored. For example,

i) The class names are different and many code refractories has been done so it creates a difficulty in implementing the same logic while extending the plugin. Like {{SCMSource}} has been broken down to other sub classes , {{SCMHeadCategory}} has some different implementation, {{SCMFileSystem}} is not implemented, APIs implementation also needs to be changed and the list goes on..

ii) The conclusion I have come to is that it would be rather lesser amount of work for me if I had to implement a new {{GitLab Branch Source Plugin}} which will be heavily inspired from {{Gitea Plugin}} (as suggested by Robert Sandall in mailing list) and also some inspiration will be taken from {{GitLab Branch Source}} and {{GitHub Branch Source}} Plugins.

iii) I will send my compelete list of reasons not to develop the existing {{GitLab Branch Source}} Plugin.

parichay.barpanda@gmail.com (JIRA)

unread,
May 25, 2019, 5:53:04 PM5/25/19
to jenkinsc...@googlegroups.com
iii) I will send my compelete complete list of reasons not to develop the existing {{GitLab Branch Source}} Plugin.

parichay.barpanda@gmail.com (JIRA)

unread,
May 29, 2019, 7:05:02 AM5/29/19
to jenkinsc...@googlegroups.com
Parichay Barpanda updated an issue
Change By: Parichay Barpanda
Sprint: GSoC 2019. Community Bonding Coding Phase 1

parichay.barpanda@gmail.com (JIRA)

unread,
May 29, 2019, 11:31:01 AM5/29/19
to jenkinsc...@googlegroups.com
Parichay Barpanda assigned an issue to Parichay Barpanda
Change By: Parichay Barpanda
Assignee: Oleg Nenashev Parichay Barpanda

marky.r.jackson@gmail.com (JIRA)

unread,
May 29, 2019, 11:33:03 AM5/29/19
to jenkinsc...@googlegroups.com
Marky Jackson commented on Task JENKINS-57677
 
Re: Create new repo for GSoC gitlab-branch-source-plugin

Parichay Barpanda since you created the repo, I would say this task is completed

parichay.barpanda@gmail.com (JIRA)

unread,
May 29, 2019, 11:36:02 AM5/29/19
to jenkinsc...@googlegroups.com

Okay, we will create a new issue when about to host the plugin. Can you resolve it Marky Jackson?

marky.r.jackson@gmail.com (JIRA)

unread,
May 29, 2019, 11:37:02 AM5/29/19
to jenkinsc...@googlegroups.com
Marky Jackson updated Task JENKINS-57677
 

Student has completed this task

Change By: Marky Jackson
Status: Open Fixed but Unreleased
Resolution: Fixed
Reply all
Reply to author
Forward
0 new messages