[JIRA] (JENKINS-57672) Determine Dependencies between PluginManager.java on Jenkins Core

0 views
Skip to first unread message

natasha.stopa@gmail.com (JIRA)

unread,
May 24, 2019, 2:06:01 PM5/24/19
to jenkinsc...@googlegroups.com
Natasha Stopa created an issue
 
Jenkins / Task JENKINS-57672
Determine Dependencies between PluginManager.java on Jenkins Core
Issue Type: Task Task
Assignee: Natasha Stopa
Components: core
Created: 2019-05-24 18:05
Labels: gsoc-2019
Priority: Minor Minor
Reporter: Natasha Stopa
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

natasha.stopa@gmail.com (JIRA)

unread,
May 27, 2019, 10:25:02 AM5/27/19
to jenkinsc...@googlegroups.com
Natasha Stopa updated an issue
Change By: Natasha Stopa
Priority: Minor Major
Labels: gsoc-2019 plugin-manager

natasha.stopa@gmail.com (JIRA)

unread,
May 27, 2019, 10:29:02 AM5/27/19
to jenkinsc...@googlegroups.com
Natasha Stopa updated an issue
The goal of this task is to identify dependencies between the PluginManager class and Jenkins core to understand the effects of pulling plugin management out of the core into its own module.  

natasha.stopa@gmail.com (JIRA)

unread,
May 29, 2019, 5:04:03 PM5/29/19
to jenkinsc...@googlegroups.com
Natasha Stopa started work on Task JENKINS-57672
 
Change By: Natasha Stopa
Status: Open In Progress

natasha.stopa@gmail.com (JIRA)

unread,
May 29, 2019, 5:15:02 PM5/29/19
to jenkinsc...@googlegroups.com
Natasha Stopa commented on Task JENKINS-57672
 
Re: Determine Dependencies between PluginManager.java on Jenkins Core

I started looking into splitting a separate module out from Jenkins core that would contain the plugin management class and its dependencies, but it appears that the number of dependencies will be quite large https://github.com/stopalopa/jenkins/tree/plugin-manager-dependencies.  Next I will look into mapping out and documenting the more direct dependencies of the plugin management to see if these can more easily be cut out from the core. 

natasha.stopa@gmail.com (JIRA)

unread,
May 30, 2019, 4:40:02 PM5/30/19
to jenkinsc...@googlegroups.com

I created a diagram showing some of the dependencies between the Plugin Manager and Jenkins Core. Black arrows represent a superclass/subclass or interface relationship; green arrows represent some other kind of relationship/dependency, and next to the methods in red are dependencies on Jenkins Core. Because of the intricacy of the dependencies on Jenkins core, on the mentor call today we talked about instead either trying to only pull out the part of Plugin Manager that does plugin installations or having the library be completely separate, but input from mentors to confirm this decision would be appreciated.  

https://www.lucidchart.com/invitations/accept/f35d3b14-0d41-4dd8-a787-e765f4582de8

 

Kristin Whetstone, Arnab Banerjee Baptiste Mathus, Oleg Nenashev, Jon Brohauge

natasha.stopa@gmail.com (JIRA)

unread,
May 30, 2019, 4:40:05 PM5/30/19
to jenkinsc...@googlegroups.com

jnz@topdanmark.dk (JIRA)

unread,
May 31, 2019, 3:45:02 AM5/31/19
to jenkinsc...@googlegroups.com
Jon Brohauge commented on Task JENKINS-57672
 
Re: Determine Dependencies between PluginManager.java on Jenkins Core

In the essence of loosely coupled components playing nicely together, I personally would like it to be a separate component, but I fear that might be too big at task within the given timeframe.

natasha.stopa@gmail.com (JIRA)

unread,
May 31, 2019, 12:11:01 PM5/31/19
to jenkinsc...@googlegroups.com

Jon Brohauge, I'd definitely like to do something that would be most beneficial to the Jenkins community, but I get kind of overwhelmed when I look at this and I'm not even really sure how to start.  I'd still be open to going that route, but I'd probably need a lot of active help. 

bmathus+ossjira@cloudbees.com (JIRA)

unread,
Jun 3, 2019, 8:37:02 AM6/3/19
to jenkinsc...@googlegroups.com

Yeah, I was the one advising to try and see to split this. But it might be a starting point that is too rough. I still believe that would be desirable in the long term, but that an intermediate move can indeed be to introduce a brand new component that will offer that high level API to the "outside" world.

I think starting small by introducing this and use it from install-plugins.sh might be a smaller scope and achievable task.

Really sorry for the wrong advice that might have turned more stressful than anticipated. 

natasha.stopa@gmail.com (JIRA)

unread,
Jun 12, 2019, 1:36:04 AM6/12/19
to jenkinsc...@googlegroups.com

So I'm going to close this Jira task since I think it was more or less completed and we've since decided to go a different direction to start.  Perhaps a little later in the summer we can circle back to incorporating the high level API and Jenkins core. 

natasha.stopa@gmail.com (JIRA)

unread,
Jun 12, 2019, 1:36:04 AM6/12/19
to jenkinsc...@googlegroups.com
Natasha Stopa closed an issue as Postponed
 
Change By: Natasha Stopa
Status: In Progress Closed
Resolution: Postponed

natasha.stopa@gmail.com (JIRA)

unread,
Jun 12, 2019, 1:36:04 AM6/12/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages