[JIRA] (JENKINS-57602) NPE in Support Core Plugin when reporting agents

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev created an issue

Jenkins / JENKINS-57602 NPE in Support Core Plugin when reporting agents Issue Type: Bug Assignee: Emilio Escobar Components: support-core-plugin Created: 2019-05-22 11:18 Environment: support-core-2.56 Priority: Minor Reporter: Oleg Nenashev I have a node which has been configured with JCasC and then never connected. When Support  Core Plugin generates a bundle, I see NPE in System logs. WARNING: Could not attach ''nodes.md'' to support bundle java.lang.NullPointerException at com.cloudbees.jenkins.support.util.Markdown.escapeBacktick(Markdown.java:17) at com.cloudbees.jenkins.support.impl.AboutJenkins$NodesContent.printTo(AboutJenkins.java:877) at com.cloudbees.jenkins.support.api.PrintedContent.writeTo(PrintedContent.java:56) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:316) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:278) at com.cloudbees.jenkins.support.SupportPlugin$PeriodicWorkImpl.lambda$doRun$0(SupportPlugin.java:820) at java.lang.Thread.run(Thread.java:748) Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated an issue

Jenkins / JENKINS-57602 NPE in Support Core Plugin when reporting agents

Change By: Oleg Nenashev

I have a node which has been configured with JCasC and then never connected. When Support  Core Plugin generates a bundle, I see NPE in System logs.

Acceptance criteria: * There is handling of null inputs in the reporting path Nice 2 have: * Methods are annotated to ensure that there is no such mistakes happening in the future {code:java}

WARNING: Could not attach ''nodes.md'' to support bundle java.lang.NullPointerException at com.cloudbees.jenkins.support.util.Markdown.escapeBacktick(Markdown.java:17) at com.cloudbees.jenkins.support.impl.AboutJenkins$NodesContent.printTo(AboutJenkins.java:877) at com.cloudbees.jenkins.support.api.PrintedContent.writeTo(PrintedContent.java:56) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:316) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:278) at com.cloudbees.jenkins.support.SupportPlugin$PeriodicWorkImpl.lambda$doRun$0(SupportPlugin.java:820) at java.lang.Thread.run(Thread.java:748)

{code}

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus commented on JENKINS-57602

Re: NPE in Support Core Plugin when reporting agents I think we should check if this also reproducible out of JCasC configured. At this stage, Oleg is saying it looks only like log spam, but we'd need to double check.

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus updated an issue

Jenkins / JENKINS-57602

NPE in Support Core Plugin when reporting agents

Change By: Baptiste Mathus Labels: triaged

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus assigned an issue to Unassigned

Jenkins / JENKINS-57602 NPE in Support Core Plugin when reporting agents

Change By: Baptiste Mathus Assignee: Emilio  Escobar

Add Comment

[manuelramonleonjimenez@gmail.com (JIRA)]

Ramon Leon started work on JENKINS-57602

Change By: Ramon Leon Status: Open In Progress

Add Comment

[manuelramonleonjimenez@gmail.com (JIRA)]

Ramon Leon assigned an issue to Ramon Leon

Jenkins / JENKINS-57602 NPE in Support Core Plugin when reporting agents

Change By: Ramon Leon Assignee: Ramon Leon

Add Comment

[manuelramonleonjimenez@gmail.com (JIRA)]

Ramon Leon updated JENKINS-57602

Jenkins / JENKINS-57602 NPE in Support Core Plugin when reporting agents

Change By: Ramon Leon Status: In Progress Review

Add Comment

[manuelramonleonjimenez@gmail.com (JIRA)]

Ramon Leon commented on JENKINS-57602

Re: NPE in Support Core Plugin when reporting agents [PR #157|https://github.com/jenkinsci/support-core-plugin/pull/179]

Add Comment

[manuelramonleonjimenez@gmail.com (JIRA)]

Ramon Leon edited a comment on JENKINS-57602

Re: NPE in Support Core Plugin when reporting agents

[PR # 157 179 |[https://github.com/jenkinsci/support-core-plugin/pull/179]]

Add Comment

[manuelramonleonjimenez@gmail.com (JIRA)]

Ramon Leon edited a comment on JENKINS-57602

Re: NPE in Support Core Plugin when reporting agents

[PR # : https://github.com/jenkinsci/support-core-plugin/pull/ 179| [ https://github.com/jenkinsci/support-core-plugin/pull/179] ]

Add Comment

[manuelramonleonjimenez@gmail.com (JIRA)]

Ramon Leon commented on JENKINS-57602

Re: NPE in Support Core Plugin when reporting agents

It only happens with JCasC because the node configured ha the field to null instead of "" (empty string). Not sure whether it's a bug in JCasC or not because the field is mandatory anyway. Why can you leave it empty in the UI? If we consider that JCasC should do the same as the UI then it's a bug in the UI. Oleg Nenashev WDYT?

Add Comment

[manuelramonleonjimenez@gmail.com (JIRA)]

Ramon Leon edited a comment on JENKINS-57602

Re: NPE in Support Core Plugin when reporting agents

It only happens with JCasC because the node configured ha the field to *null* instead of *""* (empty string). Not sure whether it's a bug in JCasC or not because the field is mandatory anyway. Why can you leave it empty in the UI?

If we consider that JCasC should do the same as the UI then it's a bug in the UI.

[~oleg_nenashev] WDYT? https://github.com/jenkinsci/support-core-plugin/pull/179#issuecomment-510910195

Add Comment

[manuelramonleonjimenez@gmail.com (JIRA)]

Ramon Leon updated JENKINS-57602

Jenkins / JENKINS-57602

NPE in Support Core Plugin when reporting agents

Change By: Ramon Leon Status: In Review Resolved Resolution: Fixed Released As: support-core-2.58

Add Comment

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)