[JIRA] (JENKINS-57602) NPE in Support Core Plugin when reporting agents

Issue Type:	Bug
Assignee:	Emilio Escobar
Components:	support-core-plugin
Created:	2019-05-22 11:18
Environment:	support-core-2.56
Priority:	Minor
Reporter:	Oleg Nenashev

I have a node which has been configured with JCasC and then never connected. When Support Core Plugin generates a bundle, I see NPE in System logs.

 
                                                                WARNING: Could not attach ''nodes.md'' to support bundle java.lang.NullPointerException at com.cloudbees.jenkins.support.util.Markdown.escapeBacktick(Markdown.java:17) at com.cloudbees.jenkins.support.impl.AboutJenkins$NodesContent.printTo(AboutJenkins.java:877) at com.cloudbees.jenkins.support.api.PrintedContent.writeTo(PrintedContent.java:56) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:316) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:278) at com.cloudbees.jenkins.support.SupportPlugin$PeriodicWorkImpl.lambda$doRun$0(SupportPlugin.java:820) at java.lang.Thread.run(Thread.java:748)

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

o.v.nenashev@gmail.com (JIRA)

unread,

May 22, 2019, 7:22:02 AM5/22/19

to jenkinsc...@googlegroups.com

Oleg Nenashev updated an issue

Jenkins /

Change By:	Oleg Nenashev

I have a node which has been configured with JCasC and then never connected. When Support Core Plugin generates a bundle, I see NPE in System logs.

Acceptance criteria:
* There is handling of null inputs in the reporting path

Nice 2 have:
* Methods are annotated to ensure that there is no such mistakes happening in the future

{code:java}

WARNING: Could not attach ''nodes.md'' to support bundle java.lang.NullPointerException at com.cloudbees.jenkins.support.util.Markdown.escapeBacktick(Markdown.java:17) at com.cloudbees.jenkins.support.impl.AboutJenkins$NodesContent.printTo(AboutJenkins.java:877) at com.cloudbees.jenkins.support.api.PrintedContent.writeTo(PrintedContent.java:56) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:316) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:278) at com.cloudbees.jenkins.support.SupportPlugin$PeriodicWorkImpl.lambda$doRun$0(SupportPlugin.java:820) at java.lang.Thread.run(Thread.java:748)

{code}

bmathus+ossjira@cloudbees.com (JIRA)

unread,

May 27, 2019, 4:31:01 AM5/27/19

to jenkinsc...@googlegroups.com

Baptiste Mathus commented on

Re: NPE in Support Core Plugin when reporting agents

I think we should check if this also reproducible out of JCasC configured.

At this stage, Oleg is saying it looks only like log spam, but we'd need to double check.

bmathus+ossjira@cloudbees.com (JIRA)

unread,

May 27, 2019, 4:32:02 AM5/27/19

to jenkinsc...@googlegroups.com

Baptiste Mathus updated an issue

Jenkins /

Change By:	Baptiste Mathus
Labels:	triaged

bmathus+ossjira@cloudbees.com (JIRA)

unread,

Jun 12, 2019, 3:46:02 AM6/12/19

to jenkinsc...@googlegroups.com

Baptiste Mathus assigned an issue to Unassigned

Jenkins /

Change By:	Baptiste Mathus
Assignee:	Emilio Escobar

manuelramonleonjimenez@gmail.com (JIRA)

unread,

Jul 11, 2019, 12:40:02 PM7/11/19

to jenkinsc...@googlegroups.com

Ramon Leon started work on

Change By:	Ramon Leon
Status:	Open In Progress

manuelramonleonjimenez@gmail.com (JIRA)

unread,

Jul 11, 2019, 12:40:02 PM7/11/19

to jenkinsc...@googlegroups.com

Ramon Leon assigned an issue to Ramon Leon

Jenkins /

Change By:	Ramon Leon
Assignee:	Ramon Leon

manuelramonleonjimenez@gmail.com (JIRA)

unread,

Jul 11, 2019, 12:40:03 PM7/11/19

to jenkinsc...@googlegroups.com

Ramon Leon updated

Jenkins /

Change By:	Ramon Leon
Status:	In Progress Review

manuelramonleonjimenez@gmail.com (JIRA)

unread,

Jul 11, 2019, 12:40:03 PM7/11/19

to jenkinsc...@googlegroups.com

Ramon Leon commented on

Re: NPE in Support Core Plugin when reporting agents

[PR #157|https://github.com/jenkinsci/support-core-plugin/pull/179]

manuelramonleonjimenez@gmail.com (JIRA)

unread,

Jul 11, 2019, 12:41:02 PM7/11/19

to jenkinsc...@googlegroups.com

Ramon Leon edited a comment on

Re: NPE in Support Core Plugin when reporting agents

[PR # 157 179 |[https://github.com/jenkinsci/support-core-plugin/pull/179]]

manuelramonleonjimenez@gmail.com (JIRA)

unread,

Jul 11, 2019, 12:41:02 PM7/11/19

to jenkinsc...@googlegroups.com

Ramon Leon edited a comment on

Re: NPE in Support Core Plugin when reporting agents

[PR # : https://github.com/jenkinsci/support-core-plugin/pull/ 179| [ https://github.com/jenkinsci/support-core-plugin/pull/179] ]

manuelramonleonjimenez@gmail.com (JIRA)

unread,

Jul 12, 2019, 10:43:04 AM7/12/19

to jenkinsc...@googlegroups.com

Ramon Leon commented on

Re: NPE in Support Core Plugin when reporting agents

It only happens with JCasC because the node configured ha the field to null instead of "" (empty string). Not sure whether it's a bug in JCasC or not because the field is mandatory anyway. Why can you leave it empty in the UI?

If we consider that JCasC should do the same as the UI then it's a bug in the UI.

Oleg Nenashev WDYT?

manuelramonleonjimenez@gmail.com (JIRA)

unread,

Jul 12, 2019, 10:44:02 AM7/12/19

to jenkinsc...@googlegroups.com

Ramon Leon edited a comment on