[JIRA] (JENKINS-57586) TaskListenerDecorator's close method is not called

10 views
Skip to first unread message

xiao.xj@outlook.com (JIRA)

unread,
May 21, 2019, 1:01:03 PM5/21/19
to jenkinsc...@googlegroups.com
Ted created an issue
 
Jenkins / Bug JENKINS-57586
TaskListenerDecorator's close method is not called
Issue Type: Bug Bug
Assignee: Unassigned
Attachments: update_test.patch
Components: workflow-job-plugin
Created: 2019-05-21 17:00
Priority: Minor Minor
Reporter: Ted

master branch workflow-job-2.33 SNAPSHOT, test case attached (diff file)

close method is not called in the pipeline lifecycle, I would like to leverage the close method to release resources used in TaskListenerDecorator, any suggestions ?

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

xiao.xj@outlook.com (JIRA)

unread,
May 23, 2019, 8:06:02 AM5/23/19
to jenkinsc...@googlegroups.com

o.v.nenashev@gmail.com (JIRA)

unread,
May 23, 2019, 11:58:01 AM5/23/19
to jenkinsc...@googlegroups.com

Ted please ask Pipeline plugin maintainers. 

xiao.xj@outlook.com (JIRA)

unread,
May 24, 2019, 1:58:02 AM5/24/19
to jenkinsc...@googlegroups.com
Ted commented on Bug JENKINS-57586

Sorry for the trouble.

Seems TaskListenerDecorator was added via https://issues.jenkins-ci.org/browse/JENKINS-45693 , Jesse Glick would you mind taking a look?

jglick@cloudbees.com (JIRA)

unread,
Jun 3, 2019, 3:23:01 PM6/3/19
to jenkinsc...@googlegroups.com
Jesse Glick resolved as Not A Defect
 

There is no guarantee close will be called on a decorated stream, particularly if it is remote. If you have something to release, find another way, such as a Callback.

Change By: Jesse Glick
Status: Open Resolved
Resolution: Not A Defect
Reply all
Reply to author
Forward
0 new messages