[JIRA] (JENKINS-57556) Path should be stored relative to workspace

15 views
Skip to first unread message

ullrich.hafner@gmail.com (JIRA)

unread,
May 20, 2019, 7:02:03 AM5/20/19
to jenkinsc...@googlegroups.com
Ulli Hafner created an issue
 
Jenkins / Bug JENKINS-57556
Path should be stored relative to workspace
Issue Type: Bug Bug
Assignee: Ulli Hafner
Components: analysis-model
Created: 2019-05-20 11:01
Priority: Minor Minor
Reporter: Ulli Hafner

Currently, all paths are resolved to an absolute path. It would rather make sense to store a relative path only in the issue and link to the base folder in a report.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ullrich.hafner@gmail.com (JIRA)

unread,
Jul 18, 2019, 10:34:02 AM7/18/19
to jenkinsc...@googlegroups.com
Ulli Hafner updated an issue
 
Jenkins / Improvement JENKINS-57556
Change By: Ulli Hafner
Issue Type: Bug Improvement

andy@andne.net (JIRA)

unread,
Aug 22, 2019, 2:16:03 PM8/22/19
to jenkinsc...@googlegroups.com
Andy Neebel commented on Improvement JENKINS-57556
 
Re: Path should be stored relative to workspace

I think this is also needed in order to properly handle scans of parallel nodes. Different build nodes aren't guaranteed to have the same root folder, or if a single node is running multiple parallel blocks at once the workspace path contains @2, @3, etc... This results in the same warning getting counted either once if workspace paths match or multiple times if the workspace path does not match. We compile C++ for multiple targets in a single job, or to also run unit tests with coverage enabled, so parallel and the same compiler running on the same file is helpful and common. Storing only the relative path should mean that the same warning from different passes on the same file only gets counted once regardless of the number of times it was output.

ullrich.hafner@gmail.com (JIRA)

unread,
Aug 22, 2019, 2:44:02 PM8/22/19
to jenkinsc...@googlegroups.com

Yes, it would also help to reduce the number of false positives for new warnings (due to a changed root folder).

On the other side, I am not sure how this would work with aggregated reports. Currently one can combine several reports into a single one that will be reported in the UI. Should this be possible only if the root paths match? Otherwise the root path would not be unique anymore.

andy@andne.net (JIRA)

unread,
Aug 22, 2019, 5:19:01 PM8/22/19
to jenkinsc...@googlegroups.com

I guess either way would function, but I think I'd rather not have that limitation. My current use case is to run my code through multiple compilers for multiple targets (a couple are GCC based, others are different). I want to merge all of those results into a single report of Compiler Warnings. As long as my number doesn't change, I'm not as worried about what the number is. However, when I'm also running my Windows target twice, once for release and once to get test coverage metrics, I can potentially get duplicate warnings if the root path is part of the check. If the warning otherwise matches (and maybe if the parser matches?, that may already be in the check), identical paths relative to the workspace root (which may not match the reported path from the compiler I suppose) should be able to be treated as one warning since in theory the same change should fix it for however many occurrences exist.

ullrich.hafner@gmail.com (JIRA)

unread,
Feb 4, 2020, 5:52:03 PM2/4/20
to jenkinsc...@googlegroups.com
Ulli Hafner started work on Improvement JENKINS-57556
 
Change By: Ulli Hafner
Status: Open In Progress
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

ullrich.hafner@gmail.com (JIRA)

unread,
Feb 4, 2020, 5:54:02 PM2/4/20
to jenkinsc...@googlegroups.com

ullrich.hafner@gmail.com (JIRA)

unread,
Feb 12, 2020, 5:03:03 PM2/12/20
to jenkinsc...@googlegroups.com
Change By: Ulli Hafner
Status: In Progress Fixed but Unreleased
Resolution: Fixed

ullrich.hafner@gmail.com (JIRA)

unread,
Mar 2, 2020, 1:19:09 PM3/2/20
to jenkinsc...@googlegroups.com
Change By: Ulli Hafner
Status: Fixed but Unreleased Resolved
Released As: 8.0.0
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages