[JIRA] (JENKINS-57493) PreBuildMergeTest fails due to localized git

[ullrich.hafner@gmail.com (JIRA)]

Ulli Hafner created an issue

Jenkins / JENKINS-57493 PreBuildMergeTest fails due to localized git Issue Type: Bug Assignee: Mark Waite Components: git-plugin Created: 2019-05-15 20:35 Priority: Trivial Reporter: Ulli Hafner I'm currently writing some integration tests with Git. I used your tests as example suite and noticed that one test fails on my machine: https://github.com/jenkinsci/git-plugin/blob/master/src/test/java/hudson/plugins/git/extensions/impl/PreBuildMergeTest.java#L70 Latest git versions are localized and so the text that is being searched for is different in my German localized git. You should remove the assertion in line 70 (or use something like alias git='env LANG=en_GB git' when using local git in your tests). Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[ullrich.hafner@gmail.com (JIRA)]

Ulli Hafner updated an issue

Jenkins / JENKINS-57493 PreBuildMergeTest fails due to localized git

Change By: Ulli Hafner I'm currently writing some integration tests with Git. I used use your tests as example suite and noticed that one test fails on my machine:

https://github.com/jenkinsci/git-plugin/blob/master/src/test/java/hudson/plugins/git/extensions/impl/PreBuildMergeTest.java#L70 Latest git versions are localized and so the text that is being searched for is different in my German localized git. You should remove the assertion in line 70 (or use something like {{alias git='env LANG=en_GB git'}} when using local git in your tests).

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-57493

Re: PreBuildMergeTest fails due to localized git Thanks for detecting that!

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite started work on JENKINS-57493

Change By: Mark Waite Status: Open In Progress

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated JENKINS-57493

Jenkins / JENKINS-57493

PreBuildMergeTest fails due to localized git

Change By: Mark Waite Status: In Progress Review

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated JENKINS-57493

Jenkins / JENKINS-57493 PreBuildMergeTest fails due to localized git

Change By: Mark Waite Status: In Review Resolved Resolution: Fixed

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite closed an issue as Fixed

Jenkins / JENKINS-57493 PreBuildMergeTest fails due to localized git

Change By: Mark Waite Status: Resolved Closed

Add Comment