[JIRA] (JENKINS-57373) monitoring-plugin description in manage jenkins looks wrong

0 views
Skip to first unread message

jsoref+jenkins@gmail.com (JIRA)

unread,
May 8, 2019, 9:57:01 AM5/8/19
to jenkinsc...@googlegroups.com
Josh Soref created an issue
 
Jenkins / Bug JENKINS-57373
monitoring-plugin description in manage jenkins looks wrong
Issue Type: Bug Bug
Assignee: evernat
Components: monitoring-plugin
Created: 2019-05-08 13:56
Priority: Minor Minor
Reporter: Josh Soref
Monitoring of Jenkins master

Monitoring of memory, cpu, http requests and more in Jenkins master.
You can also view the monitoring of

Jenkins nodes

.

I believe the description comes from:

https://github.com/jenkinsci/monitoring-plugin/blob/aafbd8ce7c303bd0711117d983fb0d7364168776/src/main/java/org/jvnet/hudson/plugins/monitoring/PluginManagementLink.java#L54-L55

And I think the rendering comes from:

https://github.com/jenkinsci/jenkins/blob/4d65572c6db9099ebcf8d2222159c069996670f9/core/src/main/resources/jenkins/model/Jenkins/manage.jelly#L51-L66

Offhand, the simplest change would be to remove the . from the end of the description. That isn't ideal, but... it'd be better than the current output.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

evernat@free.fr (JIRA)

unread,
May 8, 2019, 6:14:02 PM5/8/19
to jenkinsc...@googlegroups.com
evernat updated an issue
Change By: evernat
Attachment: management links.png

evernat@free.fr (JIRA)

unread,
May 8, 2019, 6:16:02 PM5/8/19
to jenkinsc...@googlegroups.com
evernat commented on Bug JENKINS-57373
 
Re: monitoring-plugin description in manage jenkins looks wrong

Yes, I know this issue. Thanks for reminding it to me.

With the following description in PluginManagementLink, it is better now:

"Monitoring of memory, cpu, http requests and more in Jenkins master."

{{ + "<a href='./monitoring/nodes'>You can also view the monitoring of builds, build queue and Jenkins nodes.</a>"}}

See this screenshot:

It is not immediately obvious but the two first lines have a link to the "/monitoring" page.

And the third line has a link to the "/monitoring/nodes" page.

evernat@free.fr (JIRA)

unread,
May 8, 2019, 6:17:03 PM5/8/19
to jenkinsc...@googlegroups.com
evernat edited a comment on Bug JENKINS-57373
Yes, I know this issue. Thanks for reminding it to me.

With the following description in PluginManagementLink, it is better now:

{{"Monitoring of memory, cpu, http requests and more in Jenkins master."}}
{{ + "<a href='./monitoring/nodes'>You can also view the monitoring of builds, build queue and Jenkins nodes.</a>"}}

See this screenshot:

!management links.png!


It is not immediately obvious but the two first lines have a link to the "/monitoring" page.

And the third line has a link to the "/monitoring/nodes" page.

evernat@free.fr (JIRA)

unread,
May 8, 2019, 7:12:02 PM5/8/19
to jenkinsc...@googlegroups.com

evernat@free.fr (JIRA)

unread,
May 8, 2019, 7:22:02 PM5/8/19
to jenkinsc...@googlegroups.com
Change By: evernat
Status: Open Fixed but Unreleased
Resolution: Fixed

evernat@free.fr (JIRA)

unread,
Jul 22, 2019, 9:38:02 AM7/22/19
to jenkinsc...@googlegroups.com
 

released in 1.78.0

Change By: evernat
Status: Fixed but Unreleased Closed
Reply all
Reply to author
Forward
0 new messages