[JIRA] (JENKINS-57351) Support for making Jenkins a "GitHub App"

Support for making Jenkins a "GitHub App"

Change By:	Liam Newman
Summary:	Support authentication as for making Jenkins a " GitHub App "

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

bitwiseman@gmail.com (JIRA)

unread,

May 9, 2019, 6:41:01 PM5/9/19

to jenkinsc...@googlegroups.com

Liam Newman commented on

Andreas Sieferlinger
This sounds interesting. What would be involved in do this?

irc@webratz.de (JIRA)

unread,

May 10, 2019, 1:44:02 AM5/10/19

to jenkinsc...@googlegroups.com

Andreas Sieferlinger commented on

The exact steps are described at https://developer.github.com/apps/building-github-apps/authenticating-with-github-apps/#authenticating-as-a-github-app

In terms of things that are needed for Jenkins:

A new credential type (storing the private PEM key, App ID, ...)
Authenticating as App and fetching Installation Tokens
Checking the validity of the installation token and renew if required (they are only short lived)
Using the installation token to Authorize (which is just setting the correct HTTP header for all calls to GitHub) (see https://developer.github.com/apps/building-github-apps/authenticating-with-github-apps/#authenticating-as-an-installation )

I'm not sure how exactly the authentication currently works in the context of this plugin. The change to use GitHub App tokens for other things i've worked on often wasn't too difficult.

I could help with writing docs and testing of this.

issc29@aol.com (JIRA)

unread,

Jun 27, 2019, 12:23:03 PM6/27/19

to jenkinsc...@googlegroups.com

Isaac Cohen commented on

This would definitely be very helpful. As a GitHubber, I can tell you that this is the #1 challenge of my customers when integrating Jenkins with GitHub. Another huge benefit of GitHub Apps is that they are not tied to a specific user but rather to the Organization which means you don't need to create a "machine-user" with full access to the entire Organization. Happy to provide more context on this one!

issc29@aol.com (JIRA)

unread,

Jun 27, 2019, 5:27:02 PM6/27/19

to jenkinsc...@googlegroups.com

Isaac Cohen commented on

depends on https://github.com/kohsuke/github-api/pull/522 which would implement GitHub Apps for kohsuke/github-api plugin

irc@webratz.de (JIRA)

unread,

Jul 25, 2019, 11:03:02 AM7/25/19

to jenkinsc...@googlegroups.com

Andreas Sieferlinger commented on

Hope that PR will go through soon. Maybe Liam Newman could merge it

paulo.miguel.almeida.rodenas@gmail.com (JIRA)

unread,

Jul 25, 2019, 7:35:02 PM7/25/19

to jenkinsc...@googlegroups.com

Paulo Almeida commented on

Hi guys,

I'm the author of the pull request that adds Github App integration to the kohsuke/github-api source code. Let me know if I can assist you guys on anything to get it merged.

paulo.miguel.almeida.rodenas@gmail.com (JIRA)

unread,

Oct 6, 2019, 5:53:03 PM10/6/19

to jenkinsc...@googlegroups.com

Paulo Almeida commented on

Andreas Sieferlinger Isaac Cohen the PR was merged a couple of days ago. Is there anything I can do for helping this new feature to get implemented? (Both directly or indirectly)

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

eric.dales-de-corbet@sgcib.com (JIRA)

unread,

Dec 19, 2019, 5:41:04 AM12/19/19

to jenkinsc...@googlegroups.com

Eric D'ALES DE CORBET commented on

This is definitely a most-wanted.

as stated, it avoids putting some user credential that can expire
it also brings the capability to enrich pull requests with the github check api

ojacques2@gmail.com (JIRA)

unread,

Dec 19, 2019, 6:32:03 AM12/19/19

to jenkinsc...@googlegroups.com

Olivier Jacques commented on

Not finished yet, but some have in progress work to have Jenkins act as a GitHub app. See https://github.com/github-api/github-api/issues/570#issuecomment-562200472

o.v.nenashev@gmail.com (JIRA)

unread,

Dec 20, 2019, 5:49:03 AM12/20/19

to jenkinsc...@googlegroups.com

Oleg Nenashev commented on