[JIRA] (JENKINS-57328) Should not use secret name as credential ID

4 views
Skip to first unread message

zsy19980307@gmail.com (JIRA)

unread,
May 5, 2019, 3:23:02 AM5/5/19
to jenkinsc...@googlegroups.com
Share Cheng created an issue
 
Jenkins / Bug JENKINS-57328
Should not use secret name as credential ID
Issue Type: Bug Bug
Assignee: James Nord
Components: kubernetes-credentials-provider-plugin
Created: 2019-05-05 07:22
Priority: Major Major
Reporter: Share Cheng

Currently, this plugin will use secret's name as the credential ID to create a credential. It may cause problems when there are secrets have the same name but in different namespaces.

It is better to use namespace and name to generate the credential ID - like '{namespace}-{name}'.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

jnord@cloudbees.com (JIRA)

unread,
Jun 28, 2019, 2:42:02 PM6/28/19
to jenkinsc...@googlegroups.com
James Nord commented on Bug JENKINS-57328
 
Re: Should not use secret name as credential ID

we only support a single namespace so this should not be an issue unless JENKINS-57329 is implemented

ankur485@gmail.com (JIRA)

unread,
Sep 19, 2019, 10:43:03 AM9/19/19
to jenkinsc...@googlegroups.com

For my case, I am using a Helm Chart to deploy Jenkins and its naming standard prefixes the secret names with the chart name. (ex: '{chartName}-{credname}'.)   I've resolved to modify the secret template and use the name as written to get around this, so breaking convention to workaround it.

Another issue is that, Kubernetes naming convention doesn't allow mixed-case names.  So credential names are forced to follow the same convention. ("lower case alphanumeric characters, -, and .")   Not a terrible issue, just forced to update all the pipelines.

So this change would afford a good deal of flexibility.

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages