[JIRA] (JENKINS-57122) ToolDescriptor#getDefaultProperties should be marked as Restricted No External Use

12 views
Skip to first unread message

josephp90@gmail.com (JIRA)

unread,
Apr 19, 2019, 2:20:02 PM4/19/19
to jenkinsc...@googlegroups.com
Joseph Petersen created an issue
 
Jenkins / Bug JENKINS-57122
ToolDescriptor#getDefaultProperties should be marked as Restricted No External Use
Issue Type: Bug Bug
Assignee: Unassigned
Components: core
Created: 2019-04-19 18:19
Labels: jcasc-compatibility
Priority: Minor Minor
Reporter: Joseph Petersen

JCasC will attempt to export which has no setter
Since this is used for form binding it is best to mark this as restricted signaling no one should override it.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

josephp90@gmail.com (JIRA)

unread,
Apr 19, 2019, 2:39:02 PM4/19/19
to jenkinsc...@googlegroups.com
Joseph Petersen updated an issue
Change By: Joseph Petersen
JCasC will attempt to export which has no setter
Since this is used for form binding it is best to mark this as restricted signaling no one should override it.
Add Comment Add Comment
 

josephp90@gmail.com (JIRA)

unread,
Apr 19, 2019, 2:41:01 PM4/19/19
to jenkinsc...@googlegroups.com
Joseph Petersen updated an issue
JCasC will attempt to export defaultProperties and if users than tries to roundtrip the configuration it will say no attribute is available for defaultProperties   which has no setter .
Since this is used for form binding it is best to mark this as restricted signaling no one should override it.

josephp90@gmail.com (JIRA)

unread,
Apr 19, 2019, 2:44:01 PM4/19/19
to jenkinsc...@googlegroups.com
Joseph Petersen updated an issue
JCasC will attempt to export defaultProperties , and if users than tries to roundtrip the configuration , it will say no attribute is available for defaultProperties which has no setter.
 Since this The method is used for form binding it is , so best to mark this as restricted signaling .
Signaling to JCasC export it should not be exported, and no one should override it.

o.v.nenashev@gmail.com (JIRA)

unread,
May 20, 2019, 6:01:02 AM5/20/19
to jenkinsc...@googlegroups.com
Change By: Oleg Nenashev
Status: In Progress Review

o.v.nenashev@gmail.com (JIRA)

unread,
May 20, 2019, 6:01:02 AM5/20/19
to jenkinsc...@googlegroups.com
Oleg Nenashev started work on Bug JENKINS-57122
 
Change By: Oleg Nenashev
Status: Open In Progress

o.v.nenashev@gmail.com (JIRA)

unread,
May 20, 2019, 6:02:02 AM5/20/19
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Joseph Petersen
Change By: Oleg Nenashev
Assignee: Joseph Petersen

o.v.nenashev@gmail.com (JIRA)

unread,
May 20, 2019, 6:02:02 AM5/20/19
to jenkinsc...@googlegroups.com

o.v.nenashev@gmail.com (JIRA)

unread,
Jun 3, 2019, 3:01:02 AM6/3/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Change By: Oleg Nenashev
Component/s: configuration-as-code-plugin

o.v.nenashev@gmail.com (JIRA)

unread,
Jun 3, 2019, 3:02:02 AM6/3/19
to jenkinsc...@googlegroups.com
 
Re: ToolDescriptor#getDefaultProperties should be marked as Restricted No External Use

My suggestion is that we actually implement it as a blacklist on the JCasC side.

 

o.v.nenashev@gmail.com (JIRA)

unread,
Jul 21, 2019, 6:34:02 PM7/21/19
to jenkinsc...@googlegroups.com
Change By: Oleg Nenashev
Status: In Review Resolved
Resolution: Fixed
Released As: Configuration As Code 1.22

josephp90@gmail.com (JIRA)

unread,
Mar 7, 2020, 1:08:09 AM3/7/20
to jenkinsc...@googlegroups.com
Joseph Petersen assigned an issue to Joseph Petersen
Change By: Joseph Petersen
Assignee: Joseph Petersen (old)
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages