[JIRA] (JENKINS-57108) Pipeline-Maven-Plugin - UNSTABLE build with downstream list of parent job

0 views
Skip to first unread message

bentocquec@yahoo.fr (JIRA)

unread,
Apr 18, 2019, 8:13:02 AM4/18/19
to jenkinsc...@googlegroups.com
benjamin tocquec created an issue
 
Jenkins / Bug JENKINS-57108
Pipeline-Maven-Plugin - UNSTABLE build with downstream list of parent job
Issue Type: Bug Bug
Assignee: Cyrille Le Clerc
Components: pipeline-maven-plugin
Created: 2019-04-18 12:12
Environment: Jenkins ver. 2.164.1
pipeline-maven-plugin: 3.6.9
Priority: Major Major
Reporter: benjamin tocquec

Hi,
 
Here is my context.
I have a pipeline with main steps:

  • mvn clean deploy
  • mvn test
  • sonar quality gate

I choose to set currentBuild.result = 'UNSTABLE' if last step (quality gate from Sonar) is not OK.
I want my dependencies to build automatically downstream projects when SNAPSHOT.
Everything works well when quality gate is OK (means the job is SUCCESS):
If my newly SUCCESSed project A contains SNAPSHOTed dependencies B, I can see on "Downstream Jobs" of this dependency B the newly build project.
So, when I build this dependency B, on finished, job from project A is launched.
 
BUT
 
If my job from project A is UNSTABLE, it won't be referenced as a downstream Job from dependency B (so building B will no trigger A). I have to build at least once in SUCCESS (by ex. by bypassing SONAR GATE) to see it in "Downstream Jobs" of my parent project.
 
I'd like my parent "Downstream jobs" list updated for a project that is SUCCESS or UNSTABLE.
 
Thanks
 
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

cleclerc@cloudbees.com (JIRA)

unread,
May 1, 2019, 10:57:03 AM5/1/19
to jenkinsc...@googlegroups.com
Cyrille Le Clerc commented on Bug JENKINS-57108
 
Re: Pipeline-Maven-Plugin - UNSTABLE build with downstream list of parent job

Can you provide a sample of your pipeline explaining how you set the build status to unstable?

bentocquec@yahoo.fr (JIRA)

unread,
May 3, 2019, 3:37:02 AM5/3/19
to jenkinsc...@googlegroups.com
benjamin tocquec updated an issue
 
Change By: benjamin tocquec
Attachment: pipeline.groovy

bentocquec@yahoo.fr (JIRA)

unread,
May 3, 2019, 3:39:02 AM5/3/19
to jenkinsc...@googlegroups.com
benjamin tocquec commented on Bug JENKINS-57108
 
Re: Pipeline-Maven-Plugin - UNSTABLE build with downstream list of parent job

Here is a lighter version of my pipeline used by each project:pipeline.groovy

cleclerc@cloudbees.com (JIRA)

unread,
May 7, 2019, 5:00:02 PM5/7/19
to jenkinsc...@googlegroups.com
Cyrille Le Clerc updated an issue
 
Change By: Cyrille Le Clerc
Hi,
 
Here is my context.
I have a pipeline with main steps:
* mvn clean deploy
* mvn test
* sonar quality gate


I choose to set currentBuild.result = 'UNSTABLE' if last step (quality gate from Sonar) is not OK.
I want my dependencies to build automatically downstream projects when SNAPSHOT.
Everything works well when quality gate is OK (means the job is SUCCESS):
If my newly SUCCESSed project A contains SNAPSHOTed dependencies B, I can see on "Downstream Jobs" of this dependency B the newly build project.
So, when I build this dependency B, on finished, job from project A is launched.
 
BUT
 
If my job from project A is UNSTABLE, it won't be referenced as a downstream Job from dependency B (so building B will no trigger A). I have to build at least once in SUCCESS (by ex. by bypassing SONAR GATE) to see it in "Downstream Jobs" of my parent project.
 
I'd like my parent "Downstream jobs" list updated for a project that is SUCCESS or UNSTABLE.
 
Thanks
 

{code:groovy}
def call(body) {
  // evaluate the body block, and collect configuration into the object
  def pipelineParams = [:]
  body.resolveStrategy = Closure.DELEGATE_FIRST
  body.delegate = pipelineParams
  body()

  // Get Artifactory server instance, defined in the Artifactory Plugin administration page.
  def artifactory = Artifactory.server "ARTIFACTORY"

  def scmUrl

  def trimOrigin = {
    it.startsWith('origin/') ? it.trim() - 'origin/' : it.trim()
  }

  node('maven') {
    try {
      stage('Clone sources') {
        // Keep only last 3 builds + disable concurrent builds
        properties([
            buildDiscarder(
                logRotator(
                    artifactDaysToKeepStr: '',
                    artifactNumToKeepStr: '',
                    daysToKeepStr: '',
                    numToKeepStr: '3')
            ),
            disableConcurrentBuilds()
        ])

        testFailure = false
        buildFailure = false

        // MULTIBRANCH: Branch is part of the context: so use BRANCH_NAME
        branchTobuild = env.BRANCH_NAME
        echo "branchTobuild=${branchTobuild}"

        // Scm url
        scmUrl = scm.getUserRemoteConfigs()[0].getUrl()

        // Clean
        step([$class: 'WsCleanup', cleanWhenFailure: false])

        // Get code from a Gitlab repository
        git branch: trimOrigin(branchTobuild), credentialsId: 'jenkins', url: scmUrl

        shortCommit = sh(returnStdout: true, script: "git log -n1 --pretty=format:'%H'").trim()

         // Get deployPath
        deployPath = pipelineParams.deployPath ?: ""
        echo "deployPath:${deployPath}"

        // Is this component deployable (if not, no need to display deploy buttons in Slack)
        deployable = pipelineParams.isDeployable ?: true
        echo "deployable:${deployable}"
      }

      stage('Maven build') {
        withMaven(maven: 'Maven 3.6.0', options: [junitPublisher(disabled: true)]) {
          try {
            sh 'mvn -U -T 2 clean deploy -DskipTests -Dmaven.javadoc.skip=true'
          } catch (e) {
            buildFailure = true
            throw e
          }
        }
      }

      stage('Running tests') {
        try {
          sh 'mvn -T 2 --errors test -DfailIfNoTests=false -Dsurefire.useSystemClassLoader=false'
        } catch (e) {
          // if any exception occurs, mark the build as failed
          testFailure = true
          throw e
        } finally {
          junit(testResults: '**/surefire-reports/*xml', allowEmptyResults: true)
        }
      }

      stage('SonarQube analysis') {
        withSonarQubeEnv('Sonar') {
          sh "mvn org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar \
             -Dsonar.sources='.' \
             -Dsonar.inclusions='pom.xml,src/main/web/**,src/main/java/**' \
             -Dsonar.exclusions='src/main/web/node_modules/**' \
             -Dsonar.upsource.url='https://upsource.ehtrace.com' \
             -Dsonar.upsource.project=${pomArtifactId} \
             -Dsonar.upsource.revision=${shortCommit} \
             -Dsonar.upsource.token='MHqwzb4IcQ'"
        }
      }

      stage("Notify slack Quality Gate") {
        timeout(time: 1, unit: 'HOURS') {
          // Just in case something goes wrong, pipeline will be killed after a timeout
          def qg = waitForQualityGate() // Reuse taskId previously collected by withSonarQubeEnv
          if (qg.status != 'OK') {
            currentBuild.result = 'UNSTABLE'
            echo "Pipeline aborted due to quality gate failure: ${qg.status}"
            notifySlackStatus('SONAR_QUALITY_GATE_FAILURE')
          } else {
            currentBuild.result = 'SUCCESS'
            notifySlackStatus('SUCCESS')
          }
        }
      }
    } catch (Exception e) {
      // if any exception occurs, mark the build as failed
      echo e.message

      currentBuild.result = 'FAILURE'
      if (buildFailure == true) {
        notifySlackStatus('BUILD_FAILURE')
      } else if (testFailure == true) {
        notifySlackStatus('TEST_FAILURE')
      } else {
        notifySlackStatus('FAILURE')
      }
      throw e // rethrow so the build is considered failed
    }
  }
}
{code}

cleclerc@cloudbees.com (JIRA)

unread,
May 7, 2019, 5:07:02 PM5/7/19
to jenkinsc...@googlegroups.com
             -Dsonar.upsource.token=' MHqwzb4IcQ *********** '"

cleclerc@cloudbees.com (JIRA)

unread,
May 7, 2019, 5:22:02 PM5/7/19
to jenkinsc...@googlegroups.com
Cyrille Le Clerc commented on Bug JENKINS-57108
 
Re: Pipeline-Maven-Plugin - UNSTABLE build with downstream list of parent job

This is an unexpected behaviour:

org.jenkinsci.plugins.pipeline.maven.publishers.PipelineGraphPublisher records all the dependencies and generated artifacts of a pipeline. It is executed at the end of the "withMaven(){...}" wrapping step, it should not be ignored even if the maven build is a failure as long as it gracefully finishes.
Please enable logs to FINER for org.jenkinsci.plugins.pipeline.maven.publishers.PipelineGraphPublisher, rerun the downstream pipeline A and see in the console of your newbuild of A the message 

[withMaven] pipelineGraphPublisher - Record dependency: " + dependency.getId() + ", ignoreUpstreamTriggers: " + ignoreUpstreamTriggers"

ref: https://github.com/jenkinsci/pipeline-maven-plugin/blob/pipeline-maven-3.6.11/jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/PipelineGraphPublisher.java#L172

you should also rerun the upstream pipeline and see in the pipeline build console logs the message

[withMaven] pipelineGraphPublisher - Record generated artifact:...

Ref https://github.com/jenkinsci/pipeline-maven-plugin/blob/pipeline-maven-3.6.11/jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/PipelineGraphPublisher.java#L210

bentocquec@yahoo.fr (JIRA)

unread,
May 13, 2019, 6:00:03 AM5/13/19
to jenkinsc...@googlegroups.com

Ok. I understand your point saying : if logs are present during build, it should work even if status is not SUCCESS.

However, I tried with FINER logs and saw for parent:
[withMaven] pipelineGraphPublisher - Record generated artifact: com.xxx.common:eht-error-codes:jar:3.1.0-SNAPSHOT, version: 3.1.0-20190513.093918-6, executedLifecyclePhases: [clean, initialize, process-resources, compile, process-test-resources, test-compile, test, prepare-package, package, install, deploy], skipDownstreamTriggers: false, lifecycleThreshold:deploy, file: /home/jenkins/agent/workspace/Common_eht-error-codes_develop/target/eht-error-codes-3.1.0-SNAPSHOT.jar

bentocquec@yahoo.fr (JIRA)

unread,
May 13, 2019, 6:03:02 AM5/13/19
to jenkinsc...@googlegroups.com
benjamin tocquec edited a comment on Bug JENKINS-57108
Ok. I understand your point saying : if logs are present during build, it should work even if status is not SUCCESS.

However, I tried with FINER logs and saw for parent:
{code}
[withMaven] pipelineGraphPublisher - Record generated artifact: com.xxx.common:eht-error-codes:jar:3.1.0-SNAPSHOT, version: 3.1.0-20190513.093918-6, executedLifecyclePhases: [clean, initialize, process-resources, compile, process-test-resources, test-compile, test, prepare-package, package, install, deploy], skipDownstreamTriggers: false, lifecycleThreshold:deploy, file: /home/jenkins/agent/workspace/Common_eht-error-codes_develop/target/eht-error-codes-3.1.0-SNAPSHOT.jar

{code}

and for child:
{code}
[withMaven] pipelineGraphPublisher - Record dependency: com.ehtrace.common:eht-error-codes:jar:3.1.0-SNAPSHOT, ignoreUpstreamTriggers: false
{code}

but result is the same on"Maven" view:
* child has parent in "Upstream builds" => ok
* parent has nothing in "Downstream Jobs" => ko

Parent build is SUCCESS
Child build is UNSTABLE because of Sonar gate failure

bentocquec@yahoo.fr (JIRA)

unread,
May 13, 2019, 6:04:02 AM5/13/19
to jenkinsc...@googlegroups.com
benjamin tocquec edited a comment on Bug JENKINS-57108
Ok. I understand your point saying : if logs are present during build, it should work even if status is not SUCCESS.

However, I tried with FINER logs and saw for parent:
{code}
[withMaven] pipelineGraphPublisher - Record generated artifact: com.xxx.common:eht-error-codes:jar:3.1.0-SNAPSHOT, version: 3.1.0-20190513.093918-6, executedLifecyclePhases: [clean, initialize, process-resources, compile, process-test-resources, test-compile, test, prepare-package, package, install, deploy], skipDownstreamTriggers: false, lifecycleThreshold:deploy, file: /home/jenkins/agent/workspace/Common_eht-error-codes_develop/target/eht-error-codes-3.1.0-SNAPSHOT.jar
{code}

and for child:
{code}
[withMaven] pipelineGraphPublisher - Record dependency: com. ehtrace xxx .common:eht-error-codes:jar:3.1.0-SNAPSHOT, ignoreUpstreamTriggers: false

{code}

but result is the same on"Maven" view:
* child has parent in "Upstream builds" => ok
* parent has nothing in "Downstream Jobs" => ko

Parent build is SUCCESS
Child build is UNSTABLE because of Sonar gate failure

bentocquec@yahoo.fr (JIRA)

unread,
May 13, 2019, 6:18:02 AM5/13/19
to jenkinsc...@googlegroups.com
benjamin tocquec edited a comment on Bug JENKINS-57108
Ok. I understand your point saying : if logs are present during build, it should work even if status is not SUCCESS.

However, I tried with FINER logs and saw for parent:
{code}
[withMaven] pipelineGraphPublisher - Record generated artifact: com.xxx.common:eht-error-codes:jar:3.1.0-SNAPSHOT, version: 3.1.0-20190513.093918-6, executedLifecyclePhases: [clean, initialize, process-resources, compile, process-test-resources, test-compile, test, prepare-package, package, install, deploy], skipDownstreamTriggers: false, lifecycleThreshold:deploy, file: /home/jenkins/agent/workspace/Common_eht-error-codes_develop/target/eht-error-codes-3.1.0-SNAPSHOT.jar
{code}

and for child:
{code}
[withMaven] pipelineGraphPublisher - Record dependency: com.xxx.common:eht-error-codes:jar:3.1.0-SNAPSHOT, ignoreUpstreamTriggers: false

{code}

but result is the same on"Maven" view:
* child has parent in "Upstream builds" => ok
* parent has nothing in "Downstream Jobs" => ko

Parent build is SUCCESS
Child build is UNSTABLE because of Sonar gate failure


EDIT:
Just tested with {code}currentBuild.result = 'SUCCESS'{code} instead of {code}currentBuild.result = 'UNSTABLE'{code} in my sonar stage. My child is now present in the "Downstream Jobs" list of the parent !!

cleclerc@cloudbees.com (JIRA)

unread,
May 14, 2019, 9:46:02 AM5/14/19
to jenkinsc...@googlegroups.com

I think that I understood the problem: listing upstream/downstream jobs is based on "job.last_successful_build_id". This problem may not be easy to solve.

See https://github.com/jenkinsci/pipeline-maven-plugin/blob/pipeline-maven-3.6.12/jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/dao/AbstractPipelineMavenPluginDao.java#L883

 protected Map<String, Integer> listUpstreamPipelinesBasedOnMavenDependencies(@Nonnull String downstreamJobFullName, int downstreamBuildNumber) {
        LOGGER.log(Level.FINER, "listUpstreamPipelinesBasedOnMavenDependencies({0}, {1})", new Object[]{downstreamJobFullName, downstreamBuildNumber});

        String sql = "select  upstream_job.full_name, upstream_build.number\n" +
                "from JENKINS_JOB as upstream_job\n" +
                "inner join JENKINS_BUILD as upstream_build on (upstream_job.id = upstream_build.job_id and upstream_job.last_successful_build_number = upstream_build.number)\n" +
                "inner join GENERATED_MAVEN_ARTIFACT on (upstream_build.id = GENERATED_MAVEN_ARTIFACT.build_id  and GENERATED_MAVEN_ARTIFACT.skip_downstream_triggers = false)\n" +
                "inner join MAVEN_ARTIFACT on GENERATED_MAVEN_ARTIFACT.artifact_id = MAVEN_ARTIFACT.id\n" +
                "inner join MAVEN_DEPENDENCY on (MAVEN_DEPENDENCY.artifact_id = MAVEN_ARTIFACT.id and MAVEN_DEPENDENCY.ignore_upstream_triggers = false)\n" +
                "inner join JENKINS_BUILD as downstream_build on MAVEN_DEPENDENCY.build_id = downstream_build.id\n" +
                "inner join JENKINS_JOB as downstream_job on downstream_build.job_id = downstream_job.id\n" +
                "where downstream_job.full_name = ? and downstream_job.jenkins_master_id = ? and  downstream_build.number = ? and upstream_job.jenkins_master_id = ?";

        Map<String, Integer> upstreamJobsFullNames = new HashMap<>();
        LOGGER.log(Level.FINER, "sql: {0}, jobFullName:{1}, buildNumber: {2}", new Object[]{sql, downstreamJobFullName, downstreamBuildNumber});

        try (Connection cnn = ds.getConnection()) {
            try (PreparedStatement stmt = cnn.prepareStatement(sql)) {
                stmt.setString(1, downstreamJobFullName);
                stmt.setLong(2, getJenkinsMasterPrimaryKey(cnn));
                stmt.setInt(3, downstreamBuildNumber);
                stmt.setLong(4, getJenkinsMasterPrimaryKey(cnn));
                try (ResultSet rst = stmt.executeQuery()) {
                    while (rst.next()) {
                        upstreamJobsFullNames.put(rst.getString(1), rst.getInt(2));
                    }
                }
            }
        } catch (SQLException e) {
            throw new RuntimeSqlException(e);
        }
        LOGGER.log(Level.FINE, "listUpstreamPipelinesBasedOnMavenDependencies({0}, {1}): {2}", new Object[]{downstreamJobFullName, downstreamBuildNumber, upstreamJobsFullNames});

        return upstreamJobsFullNames;
    }

bentocquec@yahoo.fr (JIRA)

unread,
May 14, 2019, 10:07:02 AM5/14/19
to jenkinsc...@googlegroups.com

I don't know how I can help.

Perhaps change :
https://github.com/jenkinsci/pipeline-maven-plugin/blob/f52b76dfe8a22a22feeb01f11c1cfe44682a5de3/jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/dao/AbstractPipelineMavenPluginDao.java#L1148
to add SUCCESS and UNSTABLE ? (but may cause side effects)

Or add another entry in table that sounds like "last_not_failed_build_id" ?

bentocquec@yahoo.fr (JIRA)

unread,
Jun 6, 2019, 8:40:07 AM6/6/19
to jenkinsc...@googlegroups.com

Any update on this ticket? Do you have any idea how to fix it?
Thanks

stefan@sedelmaier.at (JIRA)

unread,
Oct 9, 2019, 6:30:03 PM10/9/19
to jenkinsc...@googlegroups.com

A possible solution may be to update LAST_SUCCESSFUL_BUILD_NUMBER also on UNSTABLE result in AbstractPipelineMavenPluginDao:updateBuildOnCompletion :

if (Result.SUCCESS.ordinal == buildResultOrdinal
 || Result.UNSTABLE.ordinal == buildResultOrdinal) {

 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

stefan@sedelmaier.at (JIRA)

unread,
Oct 10, 2019, 2:16:03 AM10/10/19
to jenkinsc...@googlegroups.com
Stefan Sedelmaier edited a comment on Bug JENKINS-57108
The Problem is if you change the setting "Trigger downstream upon result" to anything else than stable, the downstream build will not be triggered on unstable

 A possible solution workaround may be to update LAST_SUCCESSFUL_BUILD_NUMBER also on UNSTABLE result in AbstractPipelineMavenPluginDao:updateBuildOnCompletion :
{code:java}

if (Result.SUCCESS.ordinal == buildResultOrdinal
|| Result.UNSTABLE.ordinal == buildResultOrdinal) {
{code}
 

stefan@sedelmaier.at (JIRA)

unread,
Oct 10, 2019, 5:10:02 AM10/10/19
to jenkinsc...@googlegroups.com

I did a fix and created PullRequest #228 for that issue.

It uses configuration settings from "Trigger downstream upon result" to determine if the build is successfull

bentocquec@yahoo.fr (JIRA)

unread,
Oct 10, 2019, 5:45:02 AM10/10/19
to jenkinsc...@googlegroups.com

Thanks a lot Stefan Sedelmaier !
Hope this PR will be merged soon

Reply all
Reply to author
Forward
0 new messages