[JIRA] (JENKINS-56643) hudson.Util.createSymlink is not atomic which means lastSuccessfulBuild updates are not atomic

2 views

Skip to first unread message

jsoref+jenkins@gmail.com (JIRA)

unread,

Mar 20, 2019, 4:09:03 PM3/20/19

to jenkinsc...@googlegroups.com

Josh Soref created an issue

Jenkins /

JENKINS-56643

hudson.Util.createSymlink is not atomic which means lastSuccessfulBuild updates are not atomic

Issue Type:	Bug
Assignee:	Josh Soref
Components:	core
Created:	2019-03-20 20:08
Priority:	Minor
Reporter:	Josh Soref

 
                                                                    public static void createSymlink(@Nonnull File baseDir, @Nonnull String targetPath,            @Nonnull String symlinkPath, @Nonnull TaskListener listener) throws InterruptedException {  
                                                            

https://github.com/jenkinsci/jenkins/blob/5562b2fec6428b730a7b88ad6390a7ed741ba792/core/src/main/java/hudson/Util.java#L1192

 
                                                                                Files.deleteIfExists(path);  
                                                            

https://github.com/jenkinsci/jenkins/blob/5562b2fec6428b730a7b88ad6390a7ed741ba792/core/src/main/java/hudson/Util.java#L1194

 
                                                                                    Files.createSymbolicLink(path, target);  
                                                            

Called from:

jenkins.model.PeepholePermalink.updateCache

https://github.com/jenkinsci/jenkins/blob/22aa2e6e766074d11249893e3f35e0b99e20d3d0/core/src/main/java/jenkins/model/PeepholePermalink.java#L148

 
                                                                                // (re)create the build Number->Id symlink
                Util.createSymlink(job.getBuildDir(),b.getId(),target,TaskListener.NULL);

Related to:

hudson.model.PermalinkProjectAction.Permalink

https://github.com/jenkinsci/jenkins/blob/22aa2e6e766074d11249893e3f35e0b99e20d3d0/core/src/main/java/hudson/model/PermalinkProjectAction.java#L129