[JIRA] (JENKINS-56612) Message filter does not work for multiple-line messages

12 views
Skip to first unread message

ullrich.hafner@gmail.com (JIRA)

unread,
Mar 19, 2019, 6:20:02 AM3/19/19
to jenkinsc...@googlegroups.com
Ulli Hafner updated an issue
 
Jenkins / Bug JENKINS-56612
Message filter does not work for multiple-line messages

Fixed with commit/44e3b6d. The problem was that now the parser reads multi-line messages.

Change By: Ulli Hafner
Summary: Can't create fingerprints Message filter does not work for Qt auto multiple - generated files line messages
Component/s: analysis-model
Component/s: warnings-ng-plugin
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ullrich.hafner@gmail.com (JIRA)

unread,
Mar 19, 2019, 6:20:06 AM3/19/19
to jenkinsc...@googlegroups.com
Change By: Ulli Hafner
Status: Open Fixed but Unreleased
Resolution: Fixed

ullrich.hafner@gmail.com (JIRA)

unread,
Mar 19, 2019, 6:22:01 AM3/19/19
to jenkinsc...@googlegroups.com
Ulli Hafner edited a comment on Bug JENKINS-56612
 
Re: Message filter does not work for multiple-line messages
I wonder if we should add another issue for your logs: the details view (+) button in the issues table should also show the messages in multiple lines. The message is currently is separated by newline which does nothing in HTML.

ullrich.hafner@gmail.com (JIRA)

unread,
Mar 19, 2019, 6:22:02 AM3/19/19
to jenkinsc...@googlegroups.com

I wonder if we should add another issue for your logs: the details view button in the issues table should also show the messages in multiple lines. The message is currently is separated by newline which does nothing in HTML.

ullrich.hafner@gmail.com (JIRA)

unread,
Mar 19, 2019, 6:25:02 AM3/19/19
to jenkinsc...@googlegroups.com

And another tip/question: Normally the gcc parser detects the absolute path by combining the path of the current work directory and the relative path of the warning. In your case there is no current work directory printed. We currently have support for make and ninja messages. Would it be possible to add those messages to your build?

lars.bilke@ufz.de (JIRA)

unread,
Mar 19, 2019, 6:33:02 AM3/19/19
to jenkinsc...@googlegroups.com

Thanks a lot for the quick fix!

What do you mean with "add those messages to your build"? The log is already generated with ninja although we build via cmake --build:

#!/bin/bash set -eo pipefail cd build cmake --build . --config Release --target package -j 4 2>&1 | tee build1.log

ullrich.hafner@gmail.com (JIRA)

unread,
Mar 19, 2019, 7:00:02 AM3/19/19
to jenkinsc...@googlegroups.com

I don't know how to invoke ninja, I'm a Java guy I just added support for ninja path detection: https://github.com/jenkinsci/analysis-model/blob/master/src/main/java/edu/hm/hafner/analysis/LookaheadParser.java#L28

Is there an option in ninja to get those log messages in your build as well?

lars.bilke@ufz.de (JIRA)

unread,
Mar 19, 2019, 7:35:02 AM3/19/19
to jenkinsc...@googlegroups.com

Ah I see. But this is output from CMake not Ninja. CMake configures the build and generates e.g. Makefiles or Ninja build files. CMake-based projects are often built out-of-source (i.e. having a build-directory separate from the source directory) so with your implementation you detect the build-directory (not the usage of Ninja).

Yep, I can try to get the log message into the build log. Would it be enough to have it in one of several build files? I.e. adding a file which contains that line to pattern: 'build/build*.log'? Because what I do is like this:

$ mkdir build; cd build
$ cmake -G Ninja ../sources
  ...
  -- Build files have been written to ...
$ ninja

Every command is piped to a log file.

ullrich.hafner@gmail.com (JIRA)

unread,
Mar 19, 2019, 7:57:01 AM3/19/19
to jenkinsc...@googlegroups.com

ullrich.hafner@gmail.com (JIRA)

unread,
May 8, 2019, 6:20:14 PM5/8/19
to jenkinsc...@googlegroups.com
Change By: Ulli Hafner
Status: Fixed but Unreleased Resolved
Released As: 5.0.0 (analysis-model and warnings-ng)
Reply all
Reply to author
Forward
0 new messages