[JIRA] (JENKINS-56471) Construct view using full path even when only one depot path is given

4 views
Skip to first unread message

j.f.brown@sbcglobal.net (JIRA)

unread,
Mar 7, 2019, 8:09:02 PM3/7/19
to jenkinsc...@googlegroups.com
Joel Brown created an issue
 
Jenkins / Improvement JENKINS-56471
Construct view using full path even when only one depot path is given
Issue Type: Improvement Improvement
Assignee: Unassigned
Components: p4-plugin
Created: 2019-03-08 01:08
Priority: Minor Minor
Reporter: Joel Brown

When your pipeline has a single filespec in the depotSource like this

p4sync charset: 'none',

                <snip>

                source: depotSource('//Depot/Branch/...')

 

Then the generated client view is

 //depot/branch/...   //P4CLIENT/...

 

This is request for that client view to be like it would be if you had two or more filespecs:

//depot/branch/...   //P4CLIENT/depot/branch/...

 

Code:

In org.jenkinsci.plugins.p4.client.ViewMapHelper.java, allow an option to make multi = true regardless of views.size().

 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

j.f.brown@sbcglobal.net (JIRA)

unread,
Mar 7, 2019, 8:10:01 PM3/7/19
to jenkinsc...@googlegroups.com

j.f.brown@sbcglobal.net (JIRA)

unread,
Mar 7, 2019, 8:13:26 PM3/7/19
to jenkinsc...@googlegroups.com
Joel Brown updated an issue
When your pipeline has a single filespec in the depotSource like this

 

p4sync charset: 'none',

                <snip>

                source: depotSource('// Depot depot / Branch branch /...')


 

Then the generated client view is

 //depot/branch/...   // P4CLIENT P4_CLIENT /...


 

This is request for that client view to be like it would be if you had two or more filespecs:

//depot/branch/...   // P4CLIENT P4_CLIENT /depot/branch/...

 

Use case:   all existing "make" files assume a branch name in the path.

Workaround:

add a second depotPath to the list - e.g., source: depotSource('//depot/branch/...' '//depot/not/there')

 

Code:

In org.jenkinsci.plugins.p4.client.ViewMapHelper.java, allow an option to make multi = true regardless of views.size().

 

kwirth@perforce.com (JIRA)

unread,
Mar 8, 2019, 3:10:06 AM3/8/19
to jenkinsc...@googlegroups.com

cbopardikar@perforce.com (JIRA)

unread,
Jan 6, 2020, 9:40:02 AM1/6/20
to jenkinsc...@googlegroups.com
Charusheela Bopardikar started work on Improvement JENKINS-56471
 
Change By: Charusheela Bopardikar
Status: Open In Progress
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

cbopardikar@perforce.com (JIRA)

unread,
Jan 7, 2020, 4:49:03 AM1/7/20
to jenkinsc...@googlegroups.com
Charusheela Bopardikar closed an issue as Won't Fix
 

Jenkins projects depend on Jenkinsfile being available directly under P4_CLIENT. For "make" files, workaround of adding dummy path is possible. Hence closing without fixing.

Change By: Charusheela Bopardikar
Status: In Progress Closed
Resolution: Won't Fix
Reply all
Reply to author
Forward
0 new messages