[JIRA] (JENKINS-59761) Security update notifications list plugins w/ a name that can't be found in the available updates

2 views
Skip to first unread message

dbeck@cloudbees.com (JIRA)

unread,
Oct 13, 2019, 7:01:01 AM10/13/19
to jenkinsc...@googlegroups.com
Daniel Beck moved an issue
 
Jenkins / Bug JENKINS-59761
Security update notifications list plugins w/ a name that can't be found in the available updates
Change By: Daniel Beck
Project: Infrastructure Jenkins
Key: INFRA JENKINS - 2047 59761
Issue Type: Task Bug
Workflow: classic default workflow JNJira + In-Review
Component/s: core
Component/s: update-center
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

dbeck@cloudbees.com (JIRA)

unread,
Oct 13, 2019, 7:14:06 AM10/13/19
to jenkinsc...@googlegroups.com
Daniel Beck commented on Bug JENKINS-59761
 
Re: Security update notifications list plugins w/ a name that can't be found in the available updates

Really not sure what to do about this.

There are two components involved here, core and the update site, which independently attempt to strip redundant parts out of plugin names.

The server side is (mostly) at https://github.com/jenkins-infra/update-center2/blob/b82c5dac759a868042e9b3c42b017bdc0bda40ae/src/main/java/org/jvnet/hudson/update_center/Plugin.java#L395-L403 with some particularly bad examples at https://github.com/jenkins-infra/update-center2/blob/ef26174817aad3cd838ba188a97374fad3cf7567/src/test/java/org/jvnet/hudson/update_center/PluginTest.java 

While client side we only do https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/PluginWrapper.java#L437

I like the aggressive approach a lot better because the results are cleaner, even if the results are not always great in case of really insane plugin names. It is however not an approach well suited for software that gets published and used indefinitely on new inputs.

Reply all
Reply to author
Forward
0 new messages