[JIRA] (JENKINS-56403) Renaming jenkins agents persists previously named agent on restart

[anish.dangi@gmail.com (JIRA)]

Anish Dangi updated an issue

Jenkins / JENKINS-56403 Renaming jenkins agents persists previously named agent on restart Change By: Anish Dangi Summary: Renaming jenkins agents persists old agents alongside old agents previously named agent on restart Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[anish.dangi@gmail.com (JIRA)]

Anish Dangi commented on JENKINS-56403

Re: Renaming jenkins agents persists previously named agent on restart Oleg Nenashev Jesse Glick

Add Comment

[anish.dangi@gmail.com (JIRA)]

Anish Dangi updated an issue

Jenkins / JENKINS-56403

Renaming jenkins agents persists previously named agent on restart

Change By: Anish Dangi Labels: core jenkins

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick commented on JENKINS-56403

Re: Renaming jenkins agents persists previously named agent on restart If it is a regression my casual guess would be that it was introduced with Nodes by Stephen Connolly in JENKINS-27565. Either way, it ought to be easy enough to fix given a functional test with RestartableJenkinsRule. I suspect Nodes.replaceNode needs to do a directory rename when the old and new names differ.

Add Comment

[anish.dangi@gmail.com (JIRA)]

Anish Dangi commented on JENKINS-56403

Re: Renaming jenkins agents persists previously named agent on restart

Jesse Glick This was caused by JENKINS-33780 . It replaced the prior method which performed a config save after updating the list of nodes, with the replaceNode method, which didn't do so. I opened a PR to address this. https://github.com/jenkinsci/jenkins/pull/3925

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick started work on JENKINS-56403

Change By: Jesse Glick Status: Open In Progress

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick assigned an issue to Anish Dangi

Jenkins / JENKINS-56403

Renaming jenkins agents persists previously named agent on restart

Change By: Jesse Glick Assignee: Anish Dangi

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick updated JENKINS-56403

Jenkins / JENKINS-56403 Renaming jenkins agents persists previously named agent on restart

Change By: Jesse Glick Status: In Progress Review

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus updated an issue

Jenkins / JENKINS-56403 Renaming jenkins agents persists previously named agent on restart

Change By: Baptiste Mathus Labels: core jenkins lts-candidate

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus updated JENKINS-56403

Jenkins / JENKINS-56403 Renaming jenkins agents persists previously named agent on restart

Change By: Baptiste Mathus Status: In Review Fixed but Unreleased Resolution: Fixed Released As: 2.174 (tentative)

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus commented on JENKINS-56403

Re: Renaming jenkins agents persists previously named agent on restart Thanks Anish Dangi this was merged earlier today, and should land in next weekly release. Likely 2.174

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus updated an issue

Jenkins / JENKINS-56403

Renaming jenkins agents persists previously named agent on restart

Change By: Baptiste Mathus Labels: core jenkins lts-candidate regression

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated JENKINS-56403

Jenkins / JENKINS-56403 Renaming jenkins agents persists previously named agent on restart

Change By: Oleg Nenashev Status: Fixed but Unreleased Resolved Released As: 2.174 (tentative)

Add Comment

[anish.dangi@gmail.com (JIRA)]

Anish Dangi commented on JENKINS-56403

Re: Renaming jenkins agents persists previously named agent on restart Baptiste Mathus Thanks. This seems like a safe candidate for backporting to older LTS releases. Would you consider that?

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus updated an issue

Jenkins / JENKINS-56403

Renaming jenkins agents persists previously named agent on restart

Change By: Baptiste Mathus Labels: 2.164.3-rejected core jenkins lts-candidate regression

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus commented on JENKINS-56403

Re: Renaming jenkins agents persists previously named agent on restart Anish Dangi I proposed it for upcoming 2.164.3, but it has been rejected. See https://groups.google.com/d/msgid/jenkinsci-dev/845a8da6-c20e-1f50-e69e-319fe283b1f7%40gmail.com for the discussion. Given the new selected baseline for lts is higher than 2.174, no backport will be needed. Thanks

Add Comment

[anish.dangi@gmail.com (JIRA)]

Anish Dangi commented on JENKINS-56403

Re: Renaming jenkins agents persists previously named agent on restart

Baptiste Mathus I don't see this mentioned in the jenkins 2.176 LTS changelog at https://jenkins.io/changelog-stable/. Is this actually included?

Add Comment

[anish.dangi@gmail.com (JIRA)]