[JIRA] (JENKINS-56315) Add "docker" alias for DockerTool

4 views
Skip to first unread message

james@howeswho.co.uk (JIRA)

unread,
Feb 27, 2019, 1:44:02 PM2/27/19
to jenkinsc...@googlegroups.com
James Howe created an issue
 
Jenkins / Improvement JENKINS-56315
Add "docker" alias for DockerTool
Issue Type: Improvement Improvement
Assignee: Unassigned
Components: docker-commons-plugin
Created: 2019-02-27 18:43
Labels: pipeline-improvement
Priority: Minor Minor
Reporter: James Howe

Most other tool implementations provide a short name for use in pipelines (jdk, maven, etc.) but there's no docker. You have to use the full quoted class name instead.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 28, 2019, 2:56:02 AM2/28/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Labels: newbie-friendly pipeline-improvement

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 28, 2019, 2:57:02 AM2/28/19
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Improvement JENKINS-56315
 
Re: Add "docker" alias for DockerTool

relatively easy to do.

The only problem might be with JCasC Plugin compatibility. AFAIK he does not filter by extension type when looking for aliases, so such change may cause regressions there. CC Nicolas De Loof Ewelina Wilkosz

james@howeswho.co.uk (JIRA)

unread,
Mar 1, 2019, 11:52:08 AM3/1/19
to jenkinsc...@googlegroups.com
James Howe updated an issue
 
Change By: James Howe
Most other tool implementations provide a short name for use in pipelines (jdk, maven, etc.) but there's no docker. You have to use the full quoted class name instead.
{code:groovy|title=Current}
tools {
    'org.jenkinsci.plugins.docker.commons.tools.DockerTool': 'latest'
}
{ code }
{code :groovy |title=Proposed }
tools {
    docker: 'latest'
}
{code}

james@howeswho.co.uk (JIRA)

unread,
Mar 1, 2019, 11:52:08 AM3/1/19
to jenkinsc...@googlegroups.com
James Howe updated an issue
Most other tool implementations provide a short name for use in pipelines (jdk, maven, etc.) but there's no docker. You have to use the full quoted class name instead.


{code:groovy}
tools {
    docker: 'latest'
}
{code}

james@howeswho.co.uk (JIRA)

unread,
Mar 1, 2019, 11:52:24 AM3/1/19
to jenkinsc...@googlegroups.com
James Howe updated an issue
Most other tool implementations provide a short name for use in pipelines (jdk, maven, etc.) but there's no docker. You have to use the full quoted class name instead.
{code:groovy|title=Current}
tools {
    'org.jenkinsci.plugins.docker.commons.tools.DockerTool': 'latest'
}
{ code }
{code :groovy |title=Proposed
}
tools {
    docker: 'latest'
}
{code}

james@howeswho.co.uk (JIRA)

unread,
Mar 1, 2019, 11:52:24 AM3/1/19
to jenkinsc...@googlegroups.com
James Howe updated an issue
Most other tool implementations provide a short name for use in pipelines (jdk, maven, etc.) but there's no docker. You have to use the full quoted class name instead.


{code:groovy}
tools {
    docker: 'latest'
}
{code}

james@howeswho.co.uk (JIRA)

unread,
Mar 1, 2019, 11:54:03 AM3/1/19
to jenkinsc...@googlegroups.com
James Howe commented on Improvement JENKINS-56315
 
Re: Add "docker" alias for DockerTool

Hopefully it doesn't collide with pipeline.agent.docker or the global docker (which also provides docker.withTool()).

james@howeswho.co.uk (JIRA)

unread,
May 20, 2019, 5:57:02 AM5/20/19
to jenkinsc...@googlegroups.com
James Howe closed an issue as Duplicate
 

Seems there's already a PR for this, but it was closed without explanation.
Change By: James Howe
Status: Open Closed
Resolution: Duplicate

james@howeswho.co.uk (JIRA)

unread,
May 20, 2019, 6:00:03 AM5/20/19
to jenkinsc...@googlegroups.com
James Howe edited a comment on Improvement JENKINS-56315
 
Re: Add "docker" alias for DockerTool
Seems there's already a PR for this, but it was closed without explanation further development .
Reply all
Reply to author
Forward
0 new messages