[JIRA] (JENKINS-56150) git plugin with repo that has empty .gitmodules file NPE during submodule update

[jacob.keller@gmail.com (JIRA)]

Jacob Keller created an issue

Jenkins / JENKINS-56150 git plugin with repo that has empty .gitmodules file NPE during submodule update Issue Type: Bug Assignee: Mark Waite Components: git-client-plugin Created: 2019-02-14 23:44 Priority: Major Reporter: Jacob Keller If a git repository happens to have an empty .gitmodules file, then the git client plugin will assume that the repository has submodules. Then, when the submodule Update code is run, it will crash with what appeared to be a Null Pointer exception. (my jenkins instance is having other issues, which prevent me from extracting the exceptions stack trace at the moment, but once I have it, I will update the bug.). Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-56150

Re: git plugin with repo that has empty .gitmodules file NPE during submodule update Thanks for the report. I'm unable to duplicate the problem with the simple minded test case I attempted. See https://github.com/MarkEWaite/jenkins-bugs/blob/JENKINS-56150/Jenkinsfile for my attempt. Any other details on the conditions which cause the NPE or the stack trace from the NPE?

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite assigned an issue to Unassigned

Jenkins / JENKINS-56150

git plugin with repo that has empty .gitmodules file NPE during submodule update

Change By: Mark Waite Assignee: Mark Waite

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite edited a comment on JENKINS-56150

Re: git plugin with repo that has empty .gitmodules file NPE during submodule update

Thanks for the report.  I'm unable to duplicate the problem with the [ simple minded test case |https://github.com/MarkEWaite/jenkins-bugs/blob/JENKINS-56150/Jenkinsfile] I attempted.

See https://github.com/MarkEWaite/jenkins-bugs/blob/JENKINS-56150/Jenkinsfile for my attempt. Any other details on the conditions which cause the NPE or the stack trace from the NPE?

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated an issue

Jenkins / JENKINS-56150

git plugin with repo that has empty .gitmodules file NPE during submodule update

Change By: Mark Waite

If a git repository happens to have an empty .gitmodules file, then the git client plugin will assume that the repository has submodules. Then, when the submodule Update code is run, it will crash with what appeared to be a Null Pointer exception. (my jenkins instance is having other issues, which prevent me from extracting the exceptions stack trace at the moment, but once I have it, I will update the bug.).

{noformat} java.lang.NullPointerException                 at hudson.plugins.git.extensions.impl.SubmoduleOption.onCheckoutCompleted(SubmoduleOption.java:133)                 at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1256)                 at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:120)                 at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:90)                 at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:77)                 at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)                 at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)                 at java.util.concurrent.FutureTask.run(FutureTask.java:266)                 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)                 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)                 at java.lang.Thread.run(Thread.java:748) {noformat}

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated JENKINS-56150

Fixed in git client plugin 3.0.0 once that releases

Jenkins / JENKINS-56150 git plugin with repo that has empty .gitmodules file NPE during submodule update

Change By: Mark Waite Status: Open Fixed but Unreleased Resolution: Fixed

Add Comment

[rene.scheibe@gmail.com (JIRA)]

René Scheibe commented on JENKINS-56150

Re: git plugin with repo that has empty .gitmodules file NPE during submodule update Is there any commit/pull request for the fix that can be referenced here? The ticket status should then also be set to "Resolved" and the "Released As" info be populated.

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-56150

Re: git plugin with repo that has empty .gitmodules file NPE during submodule update

Sorry, no pull request to reference. Since there was no response to my request for information, it can either be resolved as "Cannot reproduce" or as "Fixed in 3.0.0". Either is fine with me.

Add Comment

[rene.scheibe@gmail.com (JIRA)]

René Scheibe updated an issue

Jenkins / JENKINS-56150

git plugin with repo that has empty .gitmodules file NPE during submodule update

Change By: René Scheibe Component/s: git-plugin Component/s: git-client-plugin

Add Comment

[rene.scheibe@gmail.com (JIRA)]

René Scheibe commented on JENKINS-56150

Re: git plugin with repo that has empty .gitmodules file NPE during submodule update I found the respective pull request and added a link to the ticket.

Add Comment

[rene.scheibe@gmail.com (JIRA)]

René Scheibe updated JENKINS-56150

Jenkins / JENKINS-56150

git plugin with repo that has empty .gitmodules file NPE during submodule update

Change By: René Scheibe Status: Fixed but Unreleased Resolved Released As: git-4.0.0

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite closed an issue as Fixed

Jenkins / JENKINS-56150 git plugin with repo that has empty .gitmodules file NPE during submodule update

Change By: Mark Waite Status: Resolved Closed

Add Comment