[JIRA] (JENKINS-56109) Change jenkins configuration ui from tables to divs

[jsoref+jenkins@gmail.com (JIRA)]

Josh Soref created an issue

Jenkins / JENKINS-56109 Change jenkins configuration ui from tables to divs Issue Type: Story Assignee: Unassigned Attachments: image-2019-02-12-15-44-44-739.png, image-2019-02-12-15-45-51-351.png, image-2019-02-12-15-46-51-006.png Components: core Created: 2019-02-12 20:48 Priority: Minor Reporter: Josh Soref Currently jenkins's jelly framework generates lots of tables. These tables are very mobile hostile. The ui it generates is also not in line with modern UIs.   Here's one example from Windows 10's settings: Note that the label for a field is above the field – not to the left of the field. Here's a much older UI from Windows: Note that the labels for checkboxes/radios are to the right of the buttons, not to their left (* with RTL layouts, this changes, but that's due to mirroring and applies to almost everything).   Even so, labels for other things are above, not to their left (see this example for invitation duration – which is also pre Windows 10):   I can provide examples from macOS, Maemo/MeeGo, and pretty much every system (including Chrome/Firefox/Android). I happen to be using a Windows 10 laptop today (snow day), but normally I use macOS / Android. Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[jsoref+jenkins@gmail.com (JIRA)]

Josh Soref assigned an issue to Josh Soref

Jenkins / JENKINS-56109 Change jenkins configuration ui from tables to divs

Change By: Josh Soref Assignee: Josh Soref

Add Comment

[jsoref+jenkins@gmail.com (JIRA)]

Josh Soref started work on JENKINS-56109

Change By: Josh Soref Status: Open In Progress

Add Comment

[fqueiruga@cloudbees.com (JIRA)]

Félix Queiruga Balado commented on JENKINS-56109

Re: Change jenkins configuration ui from tables to divs I'm gonna go ahead and put the checklist of TODO items here: Style for hierarchies of nested elements. This includes hetero lists and repeatable elements. Indentation problems caused by the .container class and the 15px padding it sets. Maybe we should create a new class for forms instead of reusing .container. This would also work to remove the width changes on this class. Checkbox fixes for the Git plugin & similar (I have a JS based solution for this but it needs a bit more work). <f:entry> refactor: move the helper text to inside the form entry element. <f:entry> refactor: move the validation errors to inside the form entry element - not the easiest due to the javascript. Verify that form submission (buildFormTree) still works properly. Too much spacing on the API key list on the user configuration (easy). Broken scroll-aware headers on the job configuration (this one is medium at best, difficult if we need to do lots of fixing for the JS tests). ⚠️ Broken drag & drop of repetable elements Pending: Forms are IMO too wide. I'd suggest adding a max-width for inputs but maybe it is out of scope for this. Fix offset of .validation-error-area

Add Comment

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)

[fqueiruga@cloudbees.com (JIRA)]

Félix Queiruga Balado edited a comment on JENKINS-56109

Re: Change jenkins configuration ui from tables to divs

I'm gonna go ahead and put the checklist of TODO items here:

* -Style for hierarchies of nested elements. This includes _hetero lists_ and repeatable elements.- * -Indentation problems caused by the {{.container}} class and the 15px padding it sets. Maybe we should create a new class for forms instead of reusing {{.container}}. This would also work to remove the width changes on this class.- * -Checkbox fixes for the Git plugin & similar (I have a JS based solution for this but it needs a bit more work).- * -{{<f:entry>}} refactor: move the helper text to inside the form entry element.- * -{{<f:entry>}} refactor: move the validation errors to inside the form entry element - not the easiest due to the javascript.- * -Verify that form submission (_buildFormTree_) still works properly.- * -Too much spacing on the API key list on the user configuration (easy).- * -Broken scroll-aware headers on the job configuration (this one is medium at best, difficult if we need to do lots of fixing for the JS tests).- * -⚠️ Broken drag & drop of repetable elements- Pending: * Forms are IMO too wide. I'd suggest adding a max-width for inputs but maybe it is out of scope for this. * Fix offset Tune styling of _ nesting indicator * Provide backwards compatibility for {{findFollowingTR(e, "validation-error-area")}} . Used directly in many plugins ([https://github.com/search?q=org%3Ajenkinsci+ validation-error- area_ area&type=Code])

Add Comment