[JIRA] (JENKINS-55787) Switch labels from entry to checkbox

1 view
Skip to first unread message

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 6, 2019, 5:26:02 PM2/6/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
 
Jenkins / Improvement JENKINS-55787
Switch labels from entry to checkbox
Change By: Josh Soref
Summary: Switch labels from entry to optional block checkbox
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 6, 2019, 5:27:02 PM2/6/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
This is the preferred style:

!https://user-images.githubusercontent.com/2119212/51774426-47af6f00-20c0-11e9-8f58-ce82bd17dee4.png!
As opposed to:

!https://user-images.githubusercontent.com/2119212/51774439-539b3100-20c0-11e9-9c96-6569a173d80c.png!
or
!https://user-images.githubusercontent.com/2119212/51774473-6f9ed280-20c0-11e9-922c-42ea7ddedd34.png!

 

 -- –

I'm going to point to this issue for a bunch of plugins.

 

Note: my initial efforts relied on using optionalBlock instead of entry+checkbox. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving fields from the entry to the checkbox. The rendering won't generally change from the examples above.

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 12, 2019, 3:52:02 PM2/12/19
to jenkinsc...@googlegroups.com
Josh Soref started work on Improvement JENKINS-55787
 
Change By: Josh Soref
Status: Open In Progress

olamy@apache.org (JIRA)

unread,
Feb 12, 2019, 7:38:01 PM2/12/19
to jenkinsc...@googlegroups.com
Olivier Lamy closed an issue as Fixed
Change By: Olivier Lamy
Status: In Progress Closed
Resolution: Fixed

olamy@apache.org (JIRA)

unread,
Feb 12, 2019, 7:39:02 PM2/12/19
to jenkinsc...@googlegroups.com
Olivier Lamy updated an issue
Change By: Olivier Lamy
Labels: jira-plugin-3.0.6

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 14, 2019, 12:02:02 AM2/14/19
to jenkinsc...@googlegroups.com
Josh Soref reopened an issue
Change By: Josh Soref
Resolution: Fixed
Status: Closed Reopened

brunodepaulak@yahoo.com.br (JIRA)

unread,
Feb 14, 2019, 3:45:02 AM2/14/19
to jenkinsc...@googlegroups.com
Change By: Bruno P. Kinoshita
Status: Reopened Open

brunodepaulak@yahoo.com.br (JIRA)

unread,
Feb 14, 2019, 3:45:02 AM2/14/19
to jenkinsc...@googlegroups.com
Change By: Bruno P. Kinoshita
Status: Open Fixed but Unreleased
Resolution: Fixed

brunodepaulak@yahoo.com.br (JIRA)

unread,
Feb 14, 2019, 3:49:01 AM2/14/19
to jenkinsc...@googlegroups.com
Change By: Bruno P. Kinoshita
Status: Fixed but Unreleased Resolved

brunodepaulak@yahoo.com.br (JIRA)

unread,
Feb 14, 2019, 3:50:02 AM2/14/19
to jenkinsc...@googlegroups.com
Change By: Bruno P. Kinoshita
Resolution: Fixed
Status: Resolved In Review

brunodepaulak@yahoo.com.br (JIRA)

unread,
Feb 14, 2019, 3:50:02 AM2/14/19
to jenkinsc...@googlegroups.com
Bruno P. Kinoshita commented on Improvement JENKINS-55787
 
Re: Switch labels from entry to checkbox

Sorry Josh Soref! I am so used to add the link to the release notes in the Wiki, move to released, and close... then after a few minutes I realized it was not a tap-plugin issue, nor assigned to me.

I apologize. Re-opened.

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 14, 2019, 4:16:02 AM2/14/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
Change By: Josh Soref
Component/s: datadog-plugin

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 14, 2019, 8:40:02 AM2/14/19
to jenkinsc...@googlegroups.com
Josh Soref commented on Improvement JENKINS-55787
 
Re: Switch labels from entry to checkbox

I'm not used to using this JIRA either.

Since this JIRA allows selecting multiple components, it made sense to use a single ticket for all the instances, so I'm trying to take advantage of that feature.

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 19, 2019, 11:58:02 PM2/19/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
Change By: Josh Soref
Component/s: qc-plugin

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 27, 2019, 11:35:03 PM2/27/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
Change By: Josh Soref
Component/s: hubot-steps-plugin

jsoref+jenkins@gmail.com (JIRA)

unread,
Mar 3, 2019, 12:02:02 AM3/3/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
Change By: Josh Soref
Labels: jira-plugin-3.0.6 pipeline-model-definition-plugin

jsoref+jenkins@gmail.com (JIRA)

unread,
Mar 3, 2019, 2:33:02 PM3/3/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
Change By: Josh Soref
Labels: jira-plugin-3.0.6 pipeline-model-definition-plugin xunit

naresh.rayapati@gmail.com (JIRA)

unread,
Mar 6, 2019, 8:50:03 PM3/6/19
to jenkinsc...@googlegroups.com
Naresh Rayapati updated an issue
Change By: Naresh Rayapati
Component/s: hubot-steps-plugin

adrien.lecharpentier@gmail.com (JIRA)

unread,
Mar 29, 2019, 5:20:02 PM3/29/19
to jenkinsc...@googlegroups.com
Adrien Lecharpentier commented on Improvement JENKINS-55787
 
Re: Switch labels from entry to checkbox

Thank you Josh Soref! I'm speaking about mailer-plugin, as you filled a PR on this plugin. I've attached the screenshots in the PR you opened to see the diff.

Even if I agree with you that we should have the checkbox before the label, the fact that all Jenkins configurations are structured like a table (with the left column the label and the right column for the field), I fear that changing this might cause some incomprehension.

jsoref+jenkins@gmail.com (JIRA)

unread,
Mar 29, 2019, 5:25:02 PM3/29/19
to jenkinsc...@googlegroups.com

Adrien Lecharpentier: once this change is mostly done, JENKINS-56109 / jenkinsci/jenkins#3895 will change the layout away from tables. Note: I'm currently taking a short hiatus from jenkins.

radek.antoniuk@quiddia.com (JIRA)

unread,
Apr 30, 2019, 7:11:02 AM4/30/19
to jenkinsc...@googlegroups.com
Radek Antoniuk updated an issue
 
Change By: Radek Antoniuk
Labels: jira-plugin-3.0.6 pipeline-model-definition-plugin xunit

o.v.nenashev@gmail.com (JIRA)

unread,
May 27, 2019, 2:09:04 AM5/27/19
to jenkinsc...@googlegroups.com
Change By: Oleg Nenashev
Status: In Review Resolved
Resolution: Fixed
Released As: Jenkins 2.179

jsoref+jenkins@gmail.com (JIRA)

unread,
Jun 11, 2019, 7:49:02 PM6/11/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
Change By: Josh Soref
Component/s: analysis-core-plugin

jsoref+jenkins@gmail.com (JIRA)

unread,
Sep 3, 2019, 6:17:02 PM9/3/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
Change By: Josh Soref
Component/s: timestamper-plugin

jsoref+jenkins@gmail.com (JIRA)

unread,
Sep 3, 2019, 6:18:01 PM9/3/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
Change By: Josh Soref
Component/s: jobconfighistory-plugin

jsoref+jenkins@gmail.com (JIRA)

unread,
Sep 3, 2019, 7:35:01 PM9/3/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
Change By: Josh Soref
Component/s: jclouds-plugin

fritz@fritz-elfert.de (JIRA)

unread,
Sep 4, 2019, 6:26:02 AM9/4/19
to jenkinsc...@googlegroups.com
Fritz Elfert commented on Improvement JENKINS-55787
 
Re: Switch labels from entry to checkbox

Why is the state of this ticked resolved(fixed) ?
IMO, it should be set to resolved, once all plugins have the PRs merged, and for the jclouds-plugin, I can say the PR is incomplete: You missed 10 more checkboxes. Therefore; not (yet) merged!

fritz@fritz-elfert.de (JIRA)

unread,
Sep 4, 2019, 6:31:09 AM9/4/19
to jenkinsc...@googlegroups.com
Fritz Elfert reopened an issue
 
Change By: Fritz Elfert
Resolution: Fixed
Status: Resolved Reopened

fritz@fritz-elfert.de (JIRA)

unread,
Sep 4, 2019, 6:32:02 AM9/4/19
to jenkinsc...@googlegroups.com
Fritz Elfert edited a comment on Improvement JENKINS-55787
Why is the state of this ticked resolved(fixed) ?
IMO, it should be set to resolved, once * all * plugins have the PRs merged, and for the jclouds-plugin, I can say the PR is incomplete: You missed 10 more checkboxes. Therefore; not (yet) merged!

jsoref+jenkins@gmail.com (JIRA)

unread,
Sep 4, 2019, 9:07:01 AM9/4/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
 
Jenkins / Epic JENKINS-55787
Change By: Josh Soref
Issue Type: Improvement Epic

jsoref+jenkins@gmail.com (JIRA)

unread,
Sep 4, 2019, 9:12:03 AM9/4/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
This is the preferred style:

!https://user-images.githubusercontent.com/2119212/51774426-47af6f00-20c0-11e9-8f58-ce82bd17dee4.png!
As opposed to:

!https://user-images.githubusercontent.com/2119212/51774439-539b3100-20c0-11e9-9c96-6569a173d80c.png!
or
!https://user-images.githubusercontent.com/2119212/51774473-6f9ed280-20c0-11e9-922c-42ea7ddedd34.png!

 

–

I'm going to point to this issue for a bunch of plugins.

 

Note: my initial efforts relied on using {{ optionalBlock }} instead of {{ entry }} + {{ checkbox }} . Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving fields {{label}}'s from the {{ entry }} to the {{ checkbox }} . The rendering won't generally change from the examples above.

 

Please don't close this ticket when an individual PR is merged, I'm using the same ticket for many plugins.

fritz@fritz-elfert.de (JIRA)

unread,
Sep 6, 2019, 7:34:03 AM9/6/19
to jenkinsc...@googlegroups.com

igor.rondarev@gmail.com (JIRA)

unread,
Sep 19, 2019, 9:40:02 AM9/19/19
to jenkinsc...@googlegroups.com

Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrian that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very convenient (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report (JENKINS-59388) and have rewritten several jobs in out organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

igor.rondarev@gmail.com (JIRA)

unread,
Sep 19, 2019, 9:56:02 AM9/19/19
to jenkinsc...@googlegroups.com

I've also read JENKINS-56109 story and in common i agree that these 'name'/'value' tables look a bit old-fashioned, and a gap between label and checkbox isn't good too (especially when it's large), but now we've got 'mix' of styles.

igor.rondarev@gmail.com (JIRA)

unread,
Sep 19, 2019, 9:57:02 AM9/19/19
to jenkinsc...@googlegroups.com
Igor Rondarev edited a comment on Epic JENKINS-55787
Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrian that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very  convenient easy to read (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report (JENKINS-59388) and have rewritten several jobs in out organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.

igor.rondarev@gmail.com (JIRA)

unread,
Sep 19, 2019, 10:03:02 AM9/19/19
to jenkinsc...@googlegroups.com
Igor Rondarev edited a comment on Epic JENKINS-55787
Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrian that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very easy to read (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report (JENKINS-59388) and have rewritten several jobs in out our organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.

igor.rondarev@gmail.com (JIRA)

unread,
Sep 19, 2019, 10:24:02 AM9/19/19
to jenkinsc...@googlegroups.com
Igor Rondarev edited a comment on Epic JENKINS-55787
Josh, i'm terrbily sorry, but don't you think that this decision is a bit premature? I agree with Adrian Adrien that currently all job parameters looks like a table that's easy to watch and use, and 'jumping' to the right side at boolean parameters is, to be honest, not very easy to read (also from the same UX point of view, we get empty gap at the left side where label originally was; i've even created a bug report (JENKINS-59388) and have rewritten several jobs in our organization from 'booleanParam' to 'choice' with 'true'/'false' values before i found this ticket). Probably it would be better to make it configurable or add another type (e.g. BooleanLabel) with UI you propose.

mark.earl.waite@gmail.com (JIRA)

unread,
Oct 1, 2019, 4:34:03 PM10/1/19
to jenkinsc...@googlegroups.com
Change By: Mark Waite
Status: Reopened Open

gregory.zussa@datadoghq.com (JIRA)

unread,
Jan 10, 2020, 7:15:05 AM1/10/20
to jenkinsc...@googlegroups.com

me@basilcrow.com (JIRA)

unread,
Feb 18, 2020, 10:44:02 AM2/18/20
to jenkinsc...@googlegroups.com

FYI, the changes to the Timestamper plugin have been merged in jenkinsci/timestamper-plugin#32 and released in Timestamper 1.11.

me@basilcrow.com (JIRA)

unread,
Mar 3, 2020, 11:26:04 AM3/3/20
to jenkinsc...@googlegroups.com
Basil Crow updated an issue
 
Change By: Basil Crow
Component/s: timestamper-plugin
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages