[JIRA] (JENKINS-55728) Fix Access violations and update to latest parent pom

batmat@batmat.net (JIRA)

unread,

Jan 22, 2019, 7:40:02 AM1/22/19

to jenkinsc...@googlegroups.com

Baptiste Mathus created an issue

Jenkins /

JENKINS-55728

Fix Access violations and update to latest parent pom

Issue Type:	Improvement
Assignee:	Unassigned
Components:	github-branch-source-plugin
Created:	2019-01-22 12:39
Labels:	incrementals
Priority:	Minor
Reporter:	Baptiste Mathus

I tried to quickly update parent and incrementalify the plugin, but it fails because I believe the parent pom update revealed a forbidden usage of the @Restricted org/jenkinsci/plugins/github_branch_source/MergeWithGitSCMExtension class

 
                                                                [INFO] --- access-modifier-checker:1.15:enforce (default-enforce) @ github-branch-source ---
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.BranchDiscoveryTrait
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.BranchDiscoveryTrait$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.BranchSCMHead$MigrationImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.Endpoint$DesciptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.ForkPullRequestDiscoveryTrait$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubConsoleNote
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubSCMSource
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$MergeWith
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.Messages
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.OriginPullRequestDiscoveryTrait$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.PullRequestAction
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.PullRequestSCMHead$FixMetadata
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.PullRequestSCMHead$FixMetadataMigration
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.PullRequestSCMHead$FixOrigin
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.PullRequestSCMHead$FixOriginMigration
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.SSHCheckoutTrait$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.BranchDiscoveryTrait
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.BranchDiscoveryTrait$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.BranchSCMHead$MigrationImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.Endpoint$DesciptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.ForkPullRequestDiscoveryTrait$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubConsoleNote
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubSCMSource
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$MergeWith
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.Messages
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.OriginPullRequestDiscoveryTrait$DescriptorImpl
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.PullRequestAction
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.PullRequestSCMHead$FixMetadata
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.PullRequestSCMHead$FixMetadataMigration
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.PullRequestSCMHead$FixOrigin
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.PullRequestSCMHead$FixOriginMigration
[WARNING] null Failed to find class file for org.jenkinsci.plugins.github_branch_source.SSHCheckoutTrait$DescriptorImpl
[ERROR] org/jenkinsci/plugins/github_branch_source/MergeWithGitSCMExtension:48 org/jenkinsci/plugins/github_branch_source/MergeWithGitSCMExtension must not be used
[ERROR] org/jenkinsci/plugins/github_branch_source/MergeWithGitSCMExtension:48 org/jenkinsci/plugins/github_branch_source/MergeWithGitSCMExtension must not be used
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
 
                                                            

Not knowing the code of this plugin, fixing this in a few minutes is way beyond my reach, but I still believe this plugin ought to be: