[JIRA] (JENKINS-55719) Allow to configure the git blame command to suppress whitespace changes

0 views
Skip to first unread message

steinbach.till@gmx.de (JIRA)

unread,
Jan 22, 2019, 1:59:02 AM1/22/19
to jenkinsc...@googlegroups.com
Till Steinbach created an issue
 
Jenkins / Improvement JENKINS-55719
Allow to configure the git blame command to suppress whitespace changes
Issue Type: Improvement Improvement
Assignee: Ulli Hafner
Components: warnings-ng-plugin
Created: 2019-01-22 06:58
Priority: Minor Minor
Reporter: Till Steinbach

Sometimes the git blame command does not find the right person as there were whitespace changes (e.g. due to formatting) or code was moved. In this case it is possible to use "git blame -w -M" to suppress commits that only contain those changes and get better results

I suggest to make the used git blame command configurable.

 

There are two possible places:

  1. in the global configuration.
  2. in the warnings step itself.

As the implementation in the global settings is much easier I guess it could be done there. The only reason not to have it there would be to have different settings for different parsers (e.g. if you have one parser in the job that would be sensitive to whitespace changes).

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ullrich.hafner@gmail.com (JIRA)

unread,
Feb 13, 2019, 5:54:07 AM2/13/19
to jenkinsc...@googlegroups.com
Ulli Hafner assigned an issue to Unassigned
 

I think it would make sense to provide that as part of the IssuesRecorder then it can be adapted for each job.

Change By: Ulli Hafner
Labels: help-wanted
Assignee: Ulli Hafner

steinbach.till@gmx.de (JIRA)

unread,
Feb 14, 2019, 3:17:04 AM2/14/19
to jenkinsc...@googlegroups.com
Till Steinbach commented on Improvement JENKINS-55719
 
Re: Allow to configure the git blame command to suppress whitespace changes

Yes, I agree. This would allow maximum flexibility. For me this would be an ideal solution

ullrich.hafner@gmail.com (JIRA)

unread,
Sep 20, 2019, 2:20:03 PM9/20/19
to jenkinsc...@googlegroups.com
Ulli Hafner updated an issue
 
Change By: Ulli Hafner
Component/s: git-forensics-plugin
Component/s: warnings-ng-plugin
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

ullrich.hafner@gmail.com (JIRA)

unread,
Sep 30, 2019, 4:54:02 PM9/30/19
to jenkinsc...@googlegroups.com

brackett.tc@gmail.com (JIRA)

unread,
Mar 30, 2020, 3:04:06 PM3/30/20
to jenkinsc...@googlegroups.com
Timothy Brackett commented on Improvement JENKINS-55719
 
Re: Allow to configure the git blame command to suppress whitespace changes

Since newer versions of git allow one to ignore specific sha's (Reference), perhaps this could be opened up to allowing arbitrary `git blame` arguments?

Probably out-of-scope for this issue and requires a new issue, but for Git 2.23 and forward, maybe add configuration options specifically for `-ignore-rev` and `-ignore-revs-file`.

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages