[JIRA] (JENKINS-55262) Missing content-type on serverStatuses REST API

florian@ramillien.fr (JIRA)

unread,

Dec 19, 2018, 9:23:01 AM12/19/18

to jenkinsc...@googlegroups.com

Florian Ramillien created an issue

Jenkins /

JENKINS-55262

Missing content-type on serverStatuses REST API

Issue Type:	Bug
Assignee:	rsandell
Components:	gerrit-trigger-plugin
Created:	2018-12-19 14:22
Environment:	Gerrit-trigger-plugin 2.27.7
Priority:	Trivial
Reporter:	Florian Ramillien

Jelly template serving /gerrit-trigger/serverStatuses REST API doesn't add a Content-Type header to HTTP Response.

In almost all cases this is harmless (JSON result is accepted) but on some combination of Browser / HTTP Proxy + Gzip compression this result to corrupted JSON response.

Actual Response headers:

 
                                                                HTTP/1.1 200 OK
Date: Wed, 19 Dec 2018 13:52:44 GMT
X-Content-Type-Options: nosniff
Content-Encoding: gzip
Content-Length: 143
Server: Jetty(9.4.z-SNAPSHOT) 
                                                            

Expected response:

 
                                                                HTTP/1.1 200 OK
Date: Wed, 19 Dec 2018 14:16:50 GMT
X-Content-Type-Options: nosniff
Content-Encoding: gzip
Content-Type: application/json
Content-Length: 145
Server: Jetty(9.4.z-SNAPSHOT 
                                                            

Adding Jelly:stapler 'contentType' tag fix this.

/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement/serverStatuses.jelly

 
                                                                <?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout"
 xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt">
<st:contentType value="application/json" />
${it.serverStatuses}
</j:jelly> 
                                                            

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

florian@ramillien.fr (JIRA)

unread,

Dec 19, 2018, 9:29:01 AM12/19/18

to jenkinsc...@googlegroups.com

Florian Ramillien commented on

JENKINS-55262

Re: Missing content-type on serverStatuses REST API

In our case, missing content-type header cause problem with:

HTTP response compressed in gzip
Proxy: traefik (add wrong content-type: application/x-gzip)
Browser: Firefox (wrap raw gzip in base64)

JS client receive base64 instead of expected JSON leading to "Data error." in servers list.

Add Comment

florian@ramillien.fr (JIRA)

unread,

Dec 19, 2018, 9:33:03 AM12/19/18

to jenkinsc...@googlegroups.com

Florian Ramillien updated an issue

Jenkins /

JENKINS-55262

Missing content-type on serverStatuses REST API

Change By:	Florian Ramillien

Jelly template serving /gerrit-trigger/serverStatuses REST API doesn't add a Content-Type header to HTTP Response.

In almost all cases this is harmless (JSON result is accepted) but on some combination of Browser / HTTP Proxy + Gzip compression this result to corrupted JSON response.

Actual Response response headers:
{code:java}

HTTP/1.1 200 OK
Date: Wed, 19 Dec 2018 13:52:44 GMT
X-Content-Type-Options: nosniff
Content-Encoding: gzip
Content-Length: 143

Server: Jetty(9.4.z-SNAPSHOT){code}
Expected response headers :

{code:java}

HTTP/1.1 200 OK
Date: Wed, 19 Dec 2018 14:16:50 GMT
X-Content-Type-Options: nosniff
Content-Encoding: gzip
Content-Type: application/json
Content-Length: 145

Server: Jetty(9.4.z-SNAPSHOT{code}

Adding Jelly:stapler 'contentType' tag fix this.

/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement/serverStatuses.jelly

{code:java}

<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout"
xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt">
<st:contentType value="application/json" />
${it.serverStatuses}

</j:jelly>{code}