[JIRA] (JENKINS-55150) [jenkins-dev] jenkins-dev:run no longer has hot reload after 2.152

2 views
Skip to first unread message

wfollonier@cloudbees.com (JIRA)

unread,
Dec 12, 2018, 9:00:02 AM12/12/18
to jenkinsc...@googlegroups.com
Wadeck Follonier created an issue
 
Jenkins / Bug JENKINS-55150
[jenkins-dev] jenkins-dev:run no longer has hot reload after 2.152
Issue Type: Bug Bug
Assignee: Unassigned
Components: core
Created: 2018-12-12 13:59
Labels: regression
Priority: Minor Minor
Reporter: Wadeck Follonier

Previously, when I ran mvn jenkins-dev:run the instance was running and the Jelly view (and re-compiled classes) were reloaded automatically.

Since the 2.152 and the PR#3758, the things changed. The documentation cannot be used any longer.

On 2.152+:

  • mvn jenkins-dev:run starts the instance but the hot reload feature does not work, even after pressing enter (was not required before). At least the jelly views are the ones from src.
  • mvn jenkins-dev:run -f war starts the instance but with the jelly views packaged in the war during a previous mvn clean install -DskipTests. No hot reload.

After the migration, the mvn jenkins-dev:run is no longer working for 2.151- instances, the log hangs at "Started Jetty Server" forever. I am forced to run with -f war now in order to make it working.

Request: please re-enable the hot reload feature.

Ping Oleg Nenashev and Olivier Lamy for their Jelly knowledge.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

wfollonier@cloudbees.com (JIRA)

unread,
Dec 12, 2018, 9:02:02 AM12/12/18
to jenkinsc...@googlegroups.com
Wadeck Follonier updated an issue
Change By: Wadeck Follonier
Previously, when I ran {{mvn jenkins-dev:run}} the instance was running and the Jelly view (and re-compiled classes) were reloaded automatically.

Since the {{2.152}} and the [PR#3758|https://github.com/jenkinsci/jenkins/pull/3758], the things changed. The [documentation|https://wiki.jenkins.io/display/JENKINS/Building+Jenkins#BuildingJenkins-DebuggingJenkins] cannot be used any longer.

On 2.152+:
- {{mvn jenkins-dev:run}} starts the instance but the hot reload feature does not work, even after pressing enter (was not required before). At least the jelly views are the ones from {{src}}.
- {{mvn jenkins-dev:run -f war}} starts the instance but with the jelly views packaged in the war during a previous {{mvn clean install -DskipTests}}. No hot reload.


After the migration, the {{mvn jenkins-dev:run}} is no longer working for 2.151- instances, the log hangs at "Started Jetty Server" forever. I am forced to run with {{-f war}} now in order to make it working.

Request: please re-enable the hot reload feature.

Ping [~oleg_nenashev] and [~olamy] for their Jelly Jetty knowledge.

dbeck@cloudbees.com (JIRA)

unread,
Feb 7, 2019, 4:38:02 AM2/7/19
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Priority: Minor Critical

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 7, 2019, 4:42:01 AM2/7/19
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Bug JENKINS-55150
 
Re: [jenkins-dev] jenkins-dev:run no longer has hot reload after 2.152

I assume it is related to Java 11 patches in JENKINS-54599.

It was working for me, but I did not check the auto-reload of resources

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 7, 2019, 4:44:02 AM2/7/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Change By: Oleg Nenashev
Labels: DEVTOOLS regression

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 7, 2019, 4:52:01 AM2/7/19
to jenkinsc...@googlegroups.com
 
Re: [jenkins-dev] jenkins-dev:run no longer has hot reload after 2.152

https://github.com/jenkinsci/maven-hudson-dev-plugin/pull/9 . Our plugin is a copy-paste of the Jetty dev plugin. Apparently it had some custom patches which I missed

 

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 7, 2019, 4:53:02 AM2/7/19
to jenkinsc...@googlegroups.com
Oleg Nenashev edited a comment on Bug JENKINS-55150
[ https://github.com/jenkinsci/maven-hudson-dev-plugin/pull/9 ] is a "root cause" . Our plugin is a copy-paste of the Jetty dev plugin. Apparently it had some custom patches which I missed

 

adrien.lecharpentier@gmail.com (JIRA)

unread,
Feb 11, 2019, 4:27:01 AM2/11/19
to jenkinsc...@googlegroups.com
Adrien Lecharpentier updated an issue
 
Change By: Adrien Lecharpentier
Labels: DEVTOOLS java11 java11-compatibility regression triaged

batmat@batmat.net (JIRA)

unread,
Feb 13, 2019, 3:23:02 AM2/13/19
to jenkinsc...@googlegroups.com
Baptiste Mathus commented on Bug JENKINS-55150
 
Re: [jenkins-dev] jenkins-dev:run no longer has hot reload after 2.152

Maybe we should consider using at some point the upstream plugin, instead of using a fork?

 

 

batmat@batmat.net (JIRA)

unread,
Feb 13, 2019, 3:24:02 AM2/13/19
to jenkinsc...@googlegroups.com
Baptiste Mathus updated an issue
 
Change By: Baptiste Mathus
Previously, when I ran {{mvn jenkins-dev:run}} the instance was running and the Jelly view (and re-compiled classes) were reloaded automatically.

Since the {{2.152}} and the [PR#3758|https://github.com/jenkinsci/jenkins/pull/3758], the things changed. The [documentation|https://wiki.jenkins.io/display/JENKINS/Building+Jenkins#BuildingJenkins-DebuggingJenkins] cannot be used any longer.

On 2.152+:
- {{mvn jenkins-dev:run}} starts the instance but the hot reload feature does not work, even after pressing enter (was not required before). At least the jelly views are the ones from {{src}}.
- {{mvn jenkins-dev:run -f war}} starts the instance but with the jelly views packaged in the war during a previous {{mvn clean install -DskipTests}}. No hot reload.

After the migration, the {{mvn jenkins-dev:run}} is no longer working for 2.151- instances, the log hangs at "Started Jetty Server" forever. I am forced to run with {{-f war}} now in order to make it working.

Request: please re-enable the hot reload feature.

Ping [~oleg_nenashev] and [~olamy] for their Jetty knowledge.

 

h3. Acceptance criteria
* understand the reason this was originally patched
* fix the issue...

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 28, 2019, 9:22:02 AM2/28/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Labels: DEVTOOLS java11 java11- devtools- compatibility regression triaged

dbeck@cloudbees.com (JIRA)

unread,
Mar 1, 2019, 4:57:03 PM3/1/19
to jenkinsc...@googlegroups.com
Daniel Beck commented on Bug JENKINS-55150
 
Re: [jenkins-dev] jenkins-dev:run no longer has hot reload after 2.152

During development of https://github.com/jenkinsci/jenkins/pull/3919 (parent 0dfe346c9c1ccfcc2cca54c64f2850a2a5513d1a) I noticed that the Groovy views did not reload anymore with jenkins-dev:run. Very annoying.

dbeck@cloudbees.com (JIRA)

unread,
Mar 1, 2019, 8:41:02 PM3/1/19
to jenkinsc...@googlegroups.com

Workaround seems to be running:

mvn org.jenkins-ci.tools:maven-jenkins-dev-plugin:9.4.5.v20170502-jenkins-1:run

m.vilacides@gmail.com (JIRA)

unread,
Mar 4, 2019, 5:17:02 AM3/4/19
to jenkinsc...@googlegroups.com
Isa Vilacides updated an issue
 
Change By: Isa Vilacides
Priority: Critical Major

timjacomb1@gmail.com (JIRA)

unread,
Aug 9, 2019, 4:22:02 AM8/9/19
to jenkinsc...@googlegroups.com
Tim Jacomb commented on Bug JENKINS-55150
 
Re: [jenkins-dev] jenkins-dev:run no longer has hot reload after 2.152

The workaround doesn't seem to be working for me Daniel Beck
it just hangs here:

[INFO] Started o.e.j.m.p.JettyWebAppContext@67b8d45{/,file:///Users/timja/projects/jenkinsci/jenkins/target/webapp-tmp/,AVAILABLE}{file:///Users/timja/projects/jenkinsci/jenkins/target/webapp-tmp/}
[INFO] Started ServerConnector@2e44cb34{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
[INFO] Started @10823ms
[INFO] Started Jetty Server

The regular approach works but no hot reload 

mvn jenkins-dev:run

$ mvn --version
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T20:00:29+01:00)
Maven home: /usr/local/Cellar/maven/3.6.1/libexec
Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_202.jdk/Contents/Home/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.5", arch: "x86_64", family: "mac"

Jenkins 2.188-SNAPSHOT

jglick@cloudbees.com (JIRA)

unread,
Nov 12, 2019, 10:08:03 AM11/12/19
to jenkinsc...@googlegroups.com
Jesse Glick resolved as Won't Do
 

Should be irrelevant after jenkins #4351.
Change By: Jesse Glick
Status: Open Resolved
Resolution: Won't Do
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages