[JIRA] (JENKINS-54541) Unreserve doesn't set environment variable

Unreserve doesn't set environment variable

Issue Type:	Bug
Assignee:	Unassigned
Components:	lockable-resources-plugin
Created:	2018-11-08 12:23
Environment:	lockable-resources 2.3
Priority:	Major
Reporter:	Steven Foster

The manual reserve feature doesn't work well with the pipeline variable feature. When a user unreserves a resource and the plugin assigns the resource immediately to a queued build, the environment variable won't be correctly set.

In LockableResourceManager.unreserve, there is a LockStepExecution.proceed call at the end with the variable left null. I have no idea how to retrieve a singular variable to use at this point in the code.

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

f.modler@gmx.net (JIRA)

unread,

Nov 14, 2018, 6:37:03 AM11/14/18

to jenkinsc...@googlegroups.com

Falko Modler commented on

Same here, Jenkins ver. 2.138.2 and lockable-resources 2.3.

PS: First, I was irritated by this closed GitHub ticket because I thought it was the same scenario, but it's not!
That ticket adressed one build waiting for another (to free up the resource), but here we have a job waiting for a manually reserved resource.

f.modler@gmx.net (JIRA)

unread,

Nov 14, 2018, 6:54:01 AM11/14/18

to jenkinsc...@googlegroups.com

Falko Modler edited a comment on

Same here, Jenkins ver. 2.138.2 and lockable-resources 2.3.

This results in a failed build due to {{groovy.lang.MissingPropertyException: No such property: [...] for class: groovy.lang.Binding}}

PS: First, I was irritated by [this closed GitHub ticket|https://github.com/jenkinsci/lockable-resources-plugin/issues/96] because I thought it was the same scenario, but it's not!
That ticket adressed one build waiting for another (to free up the resource), but here we have a job waiting for a _manually reserved_ resource.

niels.wegner@edict.de (JIRA)

unread,

Dec 13, 2018, 9:22:02 AM12/13/18

to jenkinsc...@googlegroups.com

Niels Wegner commented on

As mentioned in JENKINS-50176 this bug will be covered by that bugfix (PR#117) as well

f.modler@gmx.net (JIRA)

unread,

Dec 13, 2018, 1:47:01 PM12/13/18

to jenkinsc...@googlegroups.com

Falko Modler commented on

Thanks for the pointer, Niels Wegner!

tobias-jenkins@23.gs (JIRA)

unread,

Oct 19, 2019, 5:22:03 PM10/19/19

to jenkinsc...@googlegroups.com

Tobias Gruetzmacher updated

Jenkins /