[JIRA] (JENKINS-54072) extension point to write comments to SCM pull request

7 views
Skip to first unread message

jeremystuartmarshall@gmail.com (JIRA)

unread,
Oct 14, 2018, 4:02:02 PM10/14/18
to jenkinsc...@googlegroups.com
Jeremy Marshall created an issue
 
Jenkins / New Feature JENKINS-54072
extension point to write comments to SCM pull request
Issue Type: New Feature New Feature
Assignee: Ulli Hafner
Components: warnings-plugin
Created: 2018-10-14 20:01
Labels: plugin
Priority: Minor Minor
Reporter: Jeremy Marshall

What I was thinking was to allow an extension point to write warnings to the SCM. I was thinking github for my needs but others have similar concepts.

 

The extension points could iterate based on the URL and decide if its a PR and one of its own then invoke it with each line or just send the whole report to be processed.

Any plugin would then decide if to add the warnings into the PR

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ullrich.hafner@gmail.com (JIRA)

unread,
Oct 14, 2018, 5:14:02 PM10/14/18
to jenkinsc...@googlegroups.com
Ulli Hafner commented on New Feature JENKINS-54072
 
Re: extension point to write comments to SCM pull request

Wouldn't that be similar to the violations-to-xyz plugins? They publish warnings in GitHub pull requests.

jeremystuartmarshall@gmail.com (JIRA)

unread,
Oct 14, 2018, 7:23:02 PM10/14/18
to jenkinsc...@googlegroups.com

I looked at that plugin and I think it’s double handling the warnings and logs

Plus you have to do some magic in git to make it work

I’m happy to do a PR once I get the code running

ullrich.hafner@gmail.com (JIRA)

unread,
Oct 16, 2018, 4:09:02 PM10/16/18
to jenkinsc...@googlegroups.com

jeremystuartmarshall@gmail.com (JIRA)

unread,
Oct 26, 2018, 4:31:01 PM10/26/18
to jenkinsc...@googlegroups.com
Jeremy Marshall assigned an issue to Jeremy Marshall
 
Change By: Jeremy Marshall
Assignee: Ulli Hafner Jeremy Marshall

jean_christophe_morin@hotmail.com (JIRA)

unread,
Mar 10, 2019, 9:27:02 PM3/10/19
to jenkinsc...@googlegroups.com
Jean-Christophe Morin commented on New Feature JENKINS-54072
 
Re: extension point to write comments to SCM pull request

Hi Jeremy Marshall, have you progressed on this? On my side I'd be interested into publishing comments to Bitbucket. Maybe we could join our forces to come up with working solution (if you don't have a working solution yet) ? When I look at your GitHub profile, I see that you already started (https://github.com/JeremyMarshall/warnings-ng-plugin/tree/extension and https://github.com/JeremyMarshall/github-violations-warnings-plugin).

 

Would you be up for some collaboration on this?

jeremystuartmarshall@gmail.com (JIRA)

unread,
Mar 11, 2019, 5:29:01 AM3/11/19
to jenkinsc...@googlegroups.com

Jean-Christophe Morin The problem with my code is that I was mainly targeting declarative pipelines when the warning plugin was used as a post step.

It mostly works but, the violations in the lists have a full pathname and I couldn't find a good way of stripping this off as the post step at the point I implemented has no way of getting the workspace.

Another problem is I started writing it in a functional way, which probably has to come out.

 

I though maybe a better way would be to have a standalone plugin which can reprocess the build/job/<job>/branches/<branch>/builds/<num>/xxx_<outstanding|fixed|new>-issues.xml files

I haven't progressed this yet other than a bare bones plugin but again the entries have a full path as per the workspace where it was created.

 

There is another jenkins  github plugin which can write to PRs from the pipeline (maybe there's a similar BitBucker one?) https://github.com/jenkinsci/pipeline-github-plugin#reviewcomment

 

Feel free to lift anything out but I really do need to start again

 

 

ullrich.hafner@gmail.com (JIRA)

unread,
Jan 17, 2020, 5:57:07 AM1/17/20
to jenkinsc...@googlegroups.com
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

jean_christophe_morin@hotmail.com (JIRA)

unread,
Jan 19, 2020, 1:58:02 PM1/19/20
to jenkinsc...@googlegroups.com

So as I said before Christmas on Gitter, I am still interested by this feature. Bitbucket server has something similar to the GitHub Checks API, it's called Code Insights (see https://confluence.atlassian.com/bitbucketserver/code-insights-966660485.html). There is no equivalent with Bitbucket cloud as of now. Services like Codacy simply create comments in pull requests for Bitbucket cloud. GitLab seems to have somthing similar to GitHub and Bitbucket (https://docs.gitlab.com/ee/user/project/merge_requests/code_quality.html), but it might not be exactly the same thing. I'm no GitLab expert.user, so I might be entirely wrong here.

ullrich.hafner@gmail.com (JIRA)

unread,
Jan 27, 2020, 4:22:02 PM1/27/20
to jenkinsc...@googlegroups.com

ullrich.hafner@gmail.com (JIRA)

unread,
Jan 29, 2020, 4:17:02 PM1/29/20
to jenkinsc...@googlegroups.com

We are currently creating a project proposal for GSoC 2020: feel free to add comments at our draft at https://docs.google.com/document/d/1fl3sF0mArtv2THOjPSZvNufGme4P24BtT0BirHMeMRY/edit?usp=sharing

Reply all
Reply to author
Forward
0 new messages