[JIRA] (JENKINS-53931) Role Strategy: Configuration-as-Code compatibility

12 views
Skip to first unread message

o.v.nenashev@gmail.com (JIRA)

unread,
Oct 7, 2018, 2:17:01 PM10/7/18
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Jenkins / Improvement JENKINS-53931
Role Strategy: Configuration-as-Code compatibility
Change By: Oleg Nenashev
Summary: Role Strategy: Configuration-as-Code compatibility
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

o.v.nenashev@gmail.com (JIRA)

unread,
Oct 7, 2018, 2:18:02 PM10/7/18
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Improvement JENKINS-53931
 
Re: Role Strategy: Configuration-as-Code compatibility

https://github.com/jenkinsci/role-strategy-plugin/pull/46 is a foundation pull request for it.

Now the code can be moved from JCasC to Role Strategy

 

o.v.nenashev@gmail.com (JIRA)

unread,
Oct 7, 2018, 2:18:03 PM10/7/18
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Unassigned
Change By: Oleg Nenashev
Assignee: Oleg Nenashev

o.v.nenashev@gmail.com (JIRA)

unread,
Oct 7, 2018, 4:21:02 PM10/7/18
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue

o.v.nenashev@gmail.com (JIRA)

unread,
Oct 7, 2018, 4:21:02 PM10/7/18
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Epic Name: Role Strategy: JCasC

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 28, 2018, 5:18:38 PM12/28/18
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Labels: gsoc-2019-project-idea jcasc-compatibility user-experience

o.v.nenashev@gmail.com (JIRA)

unread,
Dec 28, 2018, 5:24:49 PM12/28/18
to jenkinsc...@googlegroups.com

I have also added this issue as an example of changes which could be done in the plugin for Google Summer of Code 2016

rene.scheibe@gmail.com (JIRA)

unread,
Feb 9, 2019, 5:19:03 AM2/9/19
to jenkinsc...@googlegroups.com

So JCasC is not yet fully supported? I saw it mentioned in the changelog for v2.7.0.

I still see issues with a simple setup:

  • role-strategy plugin v2.9.0
  • enabled Authorization "Role-Based Strategy"
  • no further configuration of this plugin

Exporting the configuration with JCasC results in:

  authorizationStrategy: "FAILED TO EXPORT hudson.model.Hudson#authorizationStrategy:\
    \ \nio.jenkins.plugins.casc.ConfiguratorException: Cannot find configurator for\
    \ type class com.michelin.cio.hudson.plugins.rolestrategy.RoleBasedAuthorizationStrategy\n\
    \tat io.jenkins.plugins.casc.impl.DefaultConfiguratorRegistry$1.load(DefaultConfiguratorRegistry.java:97)\n\
    \tat io.jenkins.plugins.casc.impl.DefaultConfiguratorRegistry$1.load(DefaultConfiguratorRegistry.java:93)\n\
    \tat com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3568)\n\
    \tat com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2350)\n\
    \tat com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2313)\n\
    \tat com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2228)\n\t\
    at com.google.common.cache.LocalCache.get(LocalCache.java:3965)\n\tat com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3969)\n\
    \tat com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4829)\n\
    \tat io.jenkins.plugins.casc.impl.DefaultConfiguratorRegistry.lookupOrFail(DefaultConfiguratorRegistry.java:70)\n\
    \tat io.jenkins.plugins.casc.ConfigurationContext.lookupOrFail(ConfigurationContext.java:71)\n\
    \tat io.jenkins.plugins.casc.impl.configurators.HeteroDescribableConfigurator.describe(HeteroDescribableConfigurator.java:160)\n\
    \tat io.jenkins.plugins.casc.impl.configurators.HeteroDescribableConfigurator.describe(HeteroDescribableConfigurator.java:43)\n\
    \tat io.jenkins.plugins.casc.Attribute.describe(Attribute.java:196)\n\tat io.jenkins.plugins.casc.core.JenkinsConfigurator.describe(JenkinsConfigurator.java:8
    \tat io.jenkins.plugins.casc.core.JenkinsConfigurator.describe(JenkinsConfigurator.java:30)\n\
    \tat io.jenkins.plugins.casc.ConfigurationAsCode.export(ConfigurationAsCode.java:411)\n\
    \tat io.jenkins.plugins.casc.ConfigurationAsCode.doExport(ConfigurationAsCode.java:401)\n\
    ...

nthienan.it@gmail.com (JIRA)

unread,
Mar 29, 2019, 12:03:03 AM3/29/19
to jenkinsc...@googlegroups.com

Really need this to be done. I'm willing to support, please tell me where I can start. 

jnz@topdanmark.dk (JIRA)

unread,
Mar 29, 2019, 5:49:03 AM3/29/19
to jenkinsc...@googlegroups.com

An Nguyen You could fork the project and introduce the fix in a PR. Afterwards ask the maintainer to review the PR.

timjacomb1@gmail.com (JIRA)

unread,
May 28, 2019, 2:31:05 AM5/28/19
to jenkinsc...@googlegroups.com
Change By: Tim Jacomb
Status: In Progress Review

timjacomb1@gmail.com (JIRA)

unread,
May 28, 2019, 2:31:05 AM5/28/19
to jenkinsc...@googlegroups.com
Tim Jacomb started work on Epic JENKINS-53931
 
Change By: Tim Jacomb
Status: Open In Progress

timjacomb1@gmail.com (JIRA)

unread,
May 28, 2019, 2:32:03 AM5/28/19
to jenkinsc...@googlegroups.com
Tim Jacomb assigned an issue to Oleg Nenashev
Change By: Tim Jacomb
Assignee: Oleg Nenashev

timjacomb1@gmail.com (JIRA)

unread,
May 28, 2019, 2:33:03 AM5/28/19
to jenkinsc...@googlegroups.com

v1.17 of JCasC has fixed the exporting issue for this plugin in the support plugin

https://github.com/jenkinsci/role-strategy-plugin/pull/60 migrates the code from support plugin to the role strategy plugin

It's now awaiting review, Oleg Nenashev would you be able to take a look at this please?

o.v.nenashev@gmail.com (JIRA)

unread,
May 28, 2019, 3:55:02 AM5/28/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue

o.v.nenashev@gmail.com (JIRA)

unread,
May 28, 2019, 3:56:02 AM5/28/19
to jenkinsc...@googlegroups.com

Tim Jacomb I provided feedback in the PR. Once I get confirmation from the second maintainer, I am ready to merge and ship the release

o.v.nenashev@gmail.com (JIRA)

unread,
Aug 19, 2019, 1:06:04 AM8/19/19
to jenkinsc...@googlegroups.com
Change By: Oleg Nenashev
Status: In Review Resolved
Resolution: Fixed
Released As: Role Strategy 1.17

o.v.nenashev@gmail.com (JIRA)

unread,
Aug 19, 2019, 1:07:02 AM8/19/19
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Released As: Role Strategy 1 2 . 17 11
Reply all
Reply to author
Forward
0 new messages