[JIRA] (JENKINS-52781) tar function is breaking symlinks

Change By:	Pierre Beitz
Summary:	tar function is now breaking symlinks

This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

pibeitz@gmail.com (JIRA)

unread,

Jul 31, 2018, 6:44:01 AM7/31/18

to jenkinsc...@googlegroups.com

Pierre Beitz assigned an issue to Pierre Beitz

Jenkins /

Change By:	Pierre Beitz
Assignee:	Pierre Beitz

dnusbaum@cloudbees.com (JIRA)

unread,

Jul 31, 2018, 9:04:01 AM7/31/18

to jenkinsc...@googlegroups.com

Devin Nusbaum commented on

Pierre Beitz So if I understand correctly, the problem is that Archiver#visitSymlink does not even get called for symlinks when their target is a directory? If so, then something along the lines of what you proposed seems like the best approach. Do you know when the problem was first introduced?

pibeitz@gmail.com (JIRA)

unread,

Jul 31, 2018, 9:18:01 AM7/31/18

to jenkinsc...@googlegroups.com

Pierre Beitz updated an issue

Jenkins /

Change By:	Pierre Beitz

While debugging the shelve plugin I noticed that the tar function available in the FilePath class is not conserving the symlinks anymore. The shelve plugin is calling the archive function in FilePath:
{code:java}
archive(final ArchiverFactory factory, OutputStream os, final DirScanner scanner) // factory use is TarArchiverFactory with no compression{code}

I did several experiment, and ended up narrowing the issue to the release 2.91. It's still Both tar archiving function do not working in properly handle the latest weekly symlinks to directory ( 2.134 but it works correctly for symlinks to files ) :

* public int tar(OutputStream out, final String glob) -> uses a DirScanner . In Glob (ant style FileSets) that follows the release notes of 2.91 symlink , I saw therefore creates a brand new directory in place of the following that might (or might symlink, not what we want for a tar archive.

* public int tar(OutputStream out, FileFilter filter ) be -> uses a FileFilter wrapper which for some reasons doesn't redirect the cause of this issue: symlink calls to the wrapped FileFilter
{noformat}
Use Java NIO library instead of native code to create and detect symbolic links and Windows junctions to improve compatibility and robustness. {noformat}

I'm not sure I'll have time Why this week end to have a look is important: this issue has been here for long , but I can for sure provide a non working unit test next week if needed change made on 2 . 91 (see my comment below for Issue 2), made this appear more clearly.

pibeitz@gmail.com (JIRA)

unread,

Jul 31, 2018, 11:40:01 AM7/31/18

to jenkinsc...@googlegroups.com

Pierre Beitz commented on

Devin Nusbaum: I just issued a PR, attaching it to this issue (I though there was a bot doing that for me, but it seems I was wrong).

pibeitz@gmail.com (JIRA)

unread,

Aug 13, 2018, 11:58:02 AM8/13/18

to jenkinsc...@googlegroups.com

Pierre Beitz updated

Jenkins /

Change By:	Pierre Beitz
Status:	In Progress Review

pibeitz@gmail.com (JIRA)

unread,

Aug 13, 2018, 11:58:02 AM8/13/18

to jenkinsc...@googlegroups.com

Pierre Beitz started work on

Change By:	Pierre Beitz
Status:	Open In Progress

brian.murrell@intel.com (JIRA)

unread,

Jan 17, 2019, 12:35:02 PM1/17/19

to jenkinsc...@googlegroups.com

Brian J Murrell commented on

This seems to have been In Review for for 5 months now. Is it really in review or is it stalled for some reason? Where is the PR?

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

pibeitz@gmail.com (JIRA)

unread,

Mar 10, 2019, 5:47:02 AM3/10/19

to jenkinsc...@googlegroups.com

Pierre Beitz commented on