[JIRA] (JENKINS-52160) nodes are launched even when in shutdown mode

[mattia@mapreri.org (JIRA)]

Mattia Rizzolo created an issue

Jenkins / JENKINS-52160 nodes are launched even when in shutdown mode Issue Type: Improvement Assignee: Unassigned Components: core Created: 2018-06-25 18:29 Environment: jenkins 2.121.1, running on Debian stretch. Linux nodes. Priority: Minor Reporter: Mattia Rizzolo This instance of jenkins I'm running has a bunch of remote nodes that are configured to be launched on demand and taken offline when no jobs are using them. I also have some recurring jobs that are attached to specific nodes. I noticed that when I put jenkins in quietDown mode, and then those jobs tied to remote nodes are triggered, jenkins still launches the agent and keep the node online, even if it's not going to actually start the jobs due to being in quietDown. IMHO, slaves that are configured to stay down until requested shouldn't be started when in quietDown, but rather brought up once quietDown has been cancelled. Add Comment

This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

[jenkins-ci.org@meneguello.com (JIRA)]

Bruno Meneguello commented on JENKINS-52160

Re: nodes are launched even when in shutdown mode I think the `Jenkins.getInstance().isQuietingDown()` status should be checked here (https://github.com/jenkinsci/jenkins/blob/jenkins-2.177/core/src/main/java/hudson/slaves/NodeProvisioner.java#L302[)|https://github.com/jenkinsci/jenkins/blob/jenkins-2.177/core/src/main/java/hudson/slaves/NodeProvisioner.java#L302] to avoid provisioning new slaves.

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[jenkins-ci.org@meneguello.com (JIRA)]

Bruno Meneguello edited a comment on JENKINS-52160

Re: nodes are launched even when in shutdown mode

I think the ` * Jenkins.getInstance().isQuietingDown() ` * status should be checked here ( [NodeProvisioner.java#L302|[ https://github.com/jenkinsci/jenkins/blob/jenkins-2.177/core/src/main/java/hudson/slaves/NodeProvisioner.java#L302 [) |https://github.com/jenkinsci/jenkins/blob/jenkins-2.177/core/src/main/java/hudson/slaves/NodeProvisioner.java#L302 [ ] ] to avoid provisioning new slaves.

Add Comment

[jenkins-ci.org@meneguello.com (JIRA)]

Bruno Meneguello edited a comment on JENKINS-52160

Re: nodes are launched even when in shutdown mode

I think the *Jenkins.getInstance().isQuietingDown()* status should be checked here [NodeProvisioner.java#L302| [ https://github.com/jenkinsci/jenkins/blob/jenkins-2.177/core/src/main/java/hudson/slaves/NodeProvisioner.java#L302 |https://github.com/jenkinsci/jenkins/blob/jenkins-2.177/core/src/main/java/hudson/slaves/NodeProvisioner.java#L302[ ] ] to avoid provisioning new slaves.

Add Comment