[JIRA] (JENKINS-51932) Directive Generator: `when` is missing `isRestartedRun()`

[kshultz@cloudbees.com (JIRA)]

Karl Shultz created an issue

Jenkins / JENKINS-51932 Directive Generator: `when` is missing `isRestartedRun()` Issue Type: Bug Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2018-06-13 18:56 Environment: Jenkins: - Core 2.127 - Experimental UC plugins - Declarative at 1.3.0-SNAPSHOT, which was master at commit eeb92e42 Priority: Minor Reporter: Karl Shultz Summary When using the Directive Generator, building a when / allOf directive with no conditions attached produces a NPE. This was another accidental find. Steps to recreate 1. Go to the Declarative Directive Generator via http://1.2.3.4:8080/job/your-pipeline-job/directive-generator/ 2. Set it up as follows: Sample Directive: when whenCondition: allOf Execute the stage if all nested conditions are true: no selections made 3. And press the Generate Declarative Directive button, you'll get a NPE in your sample: when { // ERROR TRANSLATING CONDITIONAL: java.lang.NullPointerException } Accidental find. Unable to render embedded object: File (image-2018-06-13-14-36-02-967.png) not found. Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

[kshultz@cloudbees.com (JIRA)]

Karl Shultz updated an issue

Jenkins / JENKINS-51932 Directive Generator: `when` is missing `isRestartedRun()`

Change By: Karl Shultz Attachment: image-2018-06-13-14-59-55-242.png *Summary* When using the Directive Generator, building a the generator for {{when}} / is missing {{ allOf isRestartedRun() }} directive with no conditions attached produces a NPE . This was another accidental find. *Steps to recreate*

1. Go to the Declarative Directive Generator via {{http://1.2.3.4:8080/job/your-pipeline-job/directive-generator/}} 2.

Set it up as follows: * Pick the Sample Directive: {{when}} * whenCondition: {{allOf}} * Execute the stage if all nested conditions are true: no selections made 3. And press Look in the Generate Declarative Directive button dropdown for When Condition. I was expecting to see `isRestartedRun` , you but it ' ll get a NPE in your sample: {code:none} when {   // ERROR TRANSLATING CONDITIONAL: java s not there . lang.NullPointerException } {code} Accidental find. !image-2018-06-13-14- 36 59 - 02 55 - 967 242 .png|thumbnail!

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-51932

Jenkins / JENKINS-51932 Directive Generator: `when` is missing `isRestartedRun()`

Change By: Andrew Bayer Status: In Progress Review

Add Comment

This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-51932

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-51932

Re: Directive Generator: `when` is missing `isRestartedRun()` PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/279

Add Comment

[badevcich@gmail.com (JIRA)]

Blake Devcich commented on JENKINS-51932

Re: Directive Generator: `when` is missing `isRestartedRun()`

Is there documentation how this this isRestartedRun is used? If I put this in the when block of stage 1 and restart at stage 3 will it skip the stage 1 block or will it actually do stage 1 first, and then stage 3 and so on? I ask because I'm looking for a way to always run an earlier stage (to do some setup) no matter what stage is selected as the restart point.

Add Comment

[badevcich@gmail.com (JIRA)]

Blake Devcich edited a comment on JENKINS-51932

Re: Directive Generator: `when` is missing `isRestartedRun()`

Is there documentation how this this isRestartedRun is used? If I put this in the when block of stage 1 and restart at stage 3 will it skip the stage 1 block or will it actually do stage 1 first, and then stage 3 and so on? I ask because I'm looking for a way to always run an earlier stage (to do some setup) no matter what stage is selected as the restart point.

[https://jenkins.io/doc/book/pipeline/syntax/#when] makes no mention of this feature.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-51932

Re: Directive Generator: `when` is missing `isRestartedRun()`

It allows you to only fire a stage if it's part of a restarted run (or, of course, with not, you can have it do the reverse). But this still only applies for stages from the restart point onward - if you restart at stage 3, stages 1 and 2 will always be skipped regardless.

Add Comment

[badevcich@gmail.com (JIRA)]

Blake Devcich commented on JENKINS-51932

Re: Directive Generator: `when` is missing `isRestartedRun()`

Thanks Andrew! So just to confirm there's no way to always run a setup stage when a pipeline is restarted? The only thing I can think of right now is to have a function that is called in the beginning of every stage that is executed only on a restart.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-51932

Re: Directive Generator: `when` is missing `isRestartedRun()`

Blake Devcich - correct. It's an interesting idea, though - probably would be worth opening a JIRA for that as a new feature.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-51932

This'll be in the next release (1.3.2)

Jenkins / JENKINS-51932

Directive Generator: `when` is missing `isRestartedRun()`

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-51932 Directive Generator: `when` is missing `isRestartedRun()`

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)