[JIRA] (JENKINS-51658) Plugin POM should automatically run reincrementalify after the release

3 views
Skip to first unread message

o.v.nenashev@gmail.com (JIRA)

unread,
Jun 1, 2018, 12:39:01 PM6/1/18
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Jenkins / New Feature JENKINS-51658
Plugin POM should automatically run reincrementalify after the release
Change By: Oleg Nenashev
Proposal:

* After the completion of maven-release-plugin, run
** the reincrementalify goal
** commit POM changes as new commit
** Do another push to SCM

Everything can be implemented as a single Maven Mojo (e.g. "incrementals-release")

There is a risk of some edge cases, but it would help plugin developers a lot to keep their master branches release-ready at any time. It's also important for all CD-alike flows which may break if they do not reincrementalify.


Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
Jun 1, 2018, 12:39:01 PM6/1/18
to jenkinsc...@googlegroups.com
Oleg Nenashev created an issue
Issue Type: New Feature New Feature
Assignee: Unassigned
Components: incrementals-tools, plugin-pom
Created: 2018-06-01 16:38
Priority: Minor Minor
Reporter: Oleg Nenashev

Proposal:

  • After the completion of maven-release-plugin, run
    • the reincrementalify goal
    • commit POM changes as new commit
    • Do another push to SCM

    There is a risk of some edge cases, but it would help plugin developers a lot to keep their master branches release-ready at any time. It's also important for all CD-alike flows which may break if they do not reincrementalify.

    jglick@cloudbees.com (JIRA)

    unread,
    Jul 9, 2018, 1:35:01 PM7/9/18
    to jenkinsc...@googlegroups.com
    Jesse Glick commented on New Feature JENKINS-51658
     
    Re: Plugin POM should automatically run reincrementalify after the release

    Was suggested in PR 2 to use a completionGoals configuration parameter. Needs evaluation.

    This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

    josephp90@gmail.com (JIRA)

    unread,
    Jul 9, 2018, 3:48:02 PM7/9/18
    to jenkinsc...@googlegroups.com

    `completionGoals` avoids the extra commit and push and makes it part of the `[maven-release-plugin] prepare for next development iteration{{` step}}

    See https://github.com/jenkinsci/kotlin-v1-stdlib-jdk8-plugin/commit/afc674665f767aeec664536c8b6fb64961fda48f

    josephp90@gmail.com (JIRA)

    unread,
    Jul 9, 2018, 3:48:03 PM7/9/18
    to jenkinsc...@googlegroups.com
    Joseph Petersen edited a comment on New Feature JENKINS-51658
    {{`completionGoals` avoids the extra commit and push and makes it part of the `}}[maven-release-plugin] prepare for next development iteration` which seems like the best of both worlds :)

    See [https://github.com/jenkinsci/kotlin-v1-stdlib-jdk8-plugin/commit/afc674665f767aeec664536c8b6fb64961fda48f]

    josephp90@gmail.com (JIRA)

    unread,
    Jul 9, 2018, 3:48:03 PM7/9/18
    to jenkinsc...@googlegroups.com
    Joseph Petersen edited a comment on New Feature JENKINS-51658
    {{`completionGoals` avoids the extra commit and push and makes it part of the `}}[maven-release-plugin] prepare for next development iteration {{ ` step}}

    See 
    [ https://github.com/jenkinsci/kotlin-v1-stdlib-jdk8-plugin/commit/afc674665f767aeec664536c8b6fb64961fda48f ]

    josephp90@gmail.com (JIRA)

    unread,
    Jul 9, 2018, 3:49:03 PM7/9/18
    to jenkinsc...@googlegroups.com
    Joseph Petersen edited a comment on New Feature JENKINS-51658
    {{`completionGoals` avoids the extra commit and push and makes it part of the `}}[maven-release-plugin] prepare for next development iteration` commit which seems like the best of both worlds :)

    See [https://github.com/jenkinsci/kotlin-v1-stdlib-jdk8-plugin/commit/afc674665f767aeec664536c8b6fb64961fda48f]

    jglick@cloudbees.com (JIRA)

    unread,
    Jul 16, 2018, 10:10:03 PM7/16/18
    to jenkinsc...@googlegroups.com

    jglick@cloudbees.com (JIRA)

    unread,
    Jul 16, 2018, 10:10:04 PM7/16/18
    to jenkinsc...@googlegroups.com
    Jesse Glick started work on New Feature JENKINS-51658
     
    Change By: Jesse Glick
    Status: Open In Progress

    jglick@cloudbees.com (JIRA)

    unread,
    Jul 16, 2018, 10:11:04 PM7/16/18
    to jenkinsc...@googlegroups.com

    jglick@cloudbees.com (JIRA)

    unread,
    Jul 17, 2018, 3:55:02 PM7/17/18
    to jenkinsc...@googlegroups.com
     

    All PRs now merged. I am not inclined to bother trying to consume the jenkinsci/pom update yet, as it should have no practical impact (only jenkinsci/jenkins is incrementalified using it, and Kohsuke Kawaguchi already runs reincrementalification in his release script); the important part was to get a plugin-pom release cut which uses it, and that has happened.

    Change By: Jesse Glick
    Status: In Review Resolved
    Resolution: Fixed

    josephp90@gmail.com (JIRA)

    unread,
    Mar 7, 2020, 1:07:31 AM3/7/20
    to jenkinsc...@googlegroups.com
    Joseph Petersen assigned an issue to Joseph Petersen
    Change By: Joseph Petersen
    Assignee: Joseph Petersen (old)
    This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
    Atlassian logo
    Reply all
    Reply to author
    Forward
    0 new messages